aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/qmldesigner/designercore
diff options
context:
space:
mode:
authorMichael Winkelmann <michael.winkelmann@qt.io>2020-08-19 14:07:10 +0200
committerMichael Winkelmann <michael.winkelmann@qt.io>2020-08-20 09:33:04 +0000
commit95aa7f42dee37ec50150c10863864660885a1574 (patch)
treea4bccd132cef8f78273d26f08c21c88fc7d575b9 /src/plugins/qmldesigner/designercore
parent098d32b37022702acd43cdbd2fba413975a45b11 (diff)
QmlPuppet: Refactor ChangeBindingsCommand
Change-Id: Id3020a73f59a1adfd25066a37d083d923e77956b Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Diffstat (limited to 'src/plugins/qmldesigner/designercore')
-rw-r--r--src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp9
1 files changed, 4 insertions, 5 deletions
diff --git a/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp b/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp
index 4681d32fe3..102c87b0b9 100644
--- a/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp
+++ b/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp
@@ -543,9 +543,8 @@ void NodeInstanceView::auxiliaryDataChanged(const ModelNode &node,
ChangeValuesCommand changeValueCommand({container});
m_nodeInstanceServer->changePropertyValues(changeValueCommand);
} else if (node.hasBindingProperty(name)) {
- PropertyBindingContainer container(instance.instanceId(), name, node.bindingProperty(name).expression(), TypeName());
- ChangeBindingsCommand changeValueCommand({container});
- m_nodeInstanceServer->changePropertyBindings(changeValueCommand);
+ PropertyBindingContainer container{instance.instanceId(), name, node.bindingProperty(name).expression(), TypeName()};
+ m_nodeInstanceServer->changePropertyBindings({{container}});
}
}
}
@@ -1131,7 +1130,7 @@ ChangeBindingsCommand NodeInstanceView::createChangeBindingCommand(const QList<B
{
QVector<PropertyBindingContainer> containerList;
- foreach (const BindingProperty &property, propertyList) {
+ for (const BindingProperty &property : propertyList) {
ModelNode node = property.parentModelNode();
if (node.isValid() && hasInstanceForModelNode(node)) {
NodeInstance instance = instanceForModelNode(node);
@@ -1141,7 +1140,7 @@ ChangeBindingsCommand NodeInstanceView::createChangeBindingCommand(const QList<B
}
- return ChangeBindingsCommand(containerList);
+ return {containerList};
}
ChangeIdsCommand NodeInstanceView::createChangeIdsCommand(const QList<NodeInstance> &instanceList) const