aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/qmljseditor/qmljsquickfix.cpp
diff options
context:
space:
mode:
authorChristian Kamm <christian.d.kamm@nokia.com>2011-08-17 11:35:57 +0200
committerChristian Kamm <christian.d.kamm@nokia.com>2011-08-19 11:12:09 +0200
commit8a6d767a8f2f98ea4e04847f92cff40d661b806f (patch)
tree586e5c539adfbb18623246d00dec5e894288c8e1 /src/plugins/qmljseditor/qmljsquickfix.cpp
parenta07acad516b5fa1ac503493b4ec28d595f6e1ea0 (diff)
Refactoring changes: Cleanup and improvements.
Previously RefactoringFiles were usually passed around by value. However, since a RefactoringFile may sometimes own a QTextDocument (when it was read from a file), that's not great and caused the file to be reread after every copy. With this change RefactoringFile becomes noncopyable and is always owned by a shared pointer. This change also allowed having const RefactoringFiles which is useful because they can be safely used from other threads. See CppRefactoringChanges::fileNoEditor. Change-Id: I9045921d6d0f6349f9558ff2a3d8317ea172193b Reviewed-on: http://codereview.qt.nokia.com/3084 Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
Diffstat (limited to 'src/plugins/qmljseditor/qmljsquickfix.cpp')
-rw-r--r--src/plugins/qmljseditor/qmljsquickfix.cpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/plugins/qmljseditor/qmljsquickfix.cpp b/src/plugins/qmljseditor/qmljsquickfix.cpp
index f00a0eddd1..186442dcd0 100644
--- a/src/plugins/qmljseditor/qmljsquickfix.cpp
+++ b/src/plugins/qmljseditor/qmljsquickfix.cpp
@@ -66,11 +66,10 @@ QmlJSQuickFixOperation::~QmlJSQuickFixOperation()
void QmlJSQuickFixOperation::perform()
{
QmlJSRefactoringChanges refactoring(ExtensionSystem::PluginManager::instance()->getObject<QmlJS::ModelManagerInterface>(),
- //_state.snapshot());
m_interface->semanticInfo().snapshot);
- QmlJSRefactoringFile current = refactoring.file(fileName());
+ QmlJSRefactoringFilePtr current = refactoring.file(fileName());
- performChanges(&current, &refactoring);
+ performChanges(current, refactoring);
}
const QmlJSQuickFixAssistInterface *QmlJSQuickFixOperation::assistInterface() const