diff options
author | Eike Ziller <eike.ziller@qt.io> | 2018-04-20 15:45:11 +0200 |
---|---|---|
committer | Eike Ziller <eike.ziller@qt.io> | 2018-04-23 11:12:26 +0000 |
commit | d1ec4c120410b7351fc31df659a7f3be7ed4e93f (patch) | |
tree | 87f5c7c73ca95e2b2e14747fdc20659c79d5d59d /src/plugins/qmljseditor | |
parent | 4b9945c32981105bfae3ba59f9565757f0dc7417 (diff) |
Clean up options page category display name and icon set up
In cases where plugins extend an existing settings category of a plugin
that they depend on anyhow, they do not need to specify the translated
display name and icon for that category.
Some options pages were already not setting the icon, but still the
translated name, which makes even less sense.
Clean up this mess, only setting display name and icon if that is
necessary.
Change-Id: I8bc9d0c51b11d48f1d847337838704d663e70b45
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Diffstat (limited to 'src/plugins/qmljseditor')
-rw-r--r-- | src/plugins/qmljseditor/qmljseditingsettingspage.cpp | 3 | ||||
-rw-r--r-- | src/plugins/qmljseditor/qmljseditorconstants.h | 1 |
2 files changed, 0 insertions, 4 deletions
diff --git a/src/plugins/qmljseditor/qmljseditingsettingspage.cpp b/src/plugins/qmljseditor/qmljseditingsettingspage.cpp index 1e772df1b3a..be805c8ce12 100644 --- a/src/plugins/qmljseditor/qmljseditingsettingspage.cpp +++ b/src/plugins/qmljseditor/qmljseditingsettingspage.cpp @@ -167,9 +167,6 @@ QmlJsEditingSettingsPage::QmlJsEditingSettingsPage() : setId("C.QmlJsEditing"); setDisplayName(tr("QML/JS Editing")); setCategory(Constants::SETTINGS_CATEGORY_QML); - setDisplayCategory(QCoreApplication::translate("QmlJSEditor", - QmlJSEditor::Constants::SETTINGS_TR_CATEGORY_QML)); - setCategoryIcon(Utils::Icon(QmlJSTools::Constants::SETTINGS_CATEGORY_QML_ICON)); } QWidget *QmlJsEditingSettingsPage::widget() diff --git a/src/plugins/qmljseditor/qmljseditorconstants.h b/src/plugins/qmljseditor/qmljseditorconstants.h index c1a78898b54..624d3b0b169 100644 --- a/src/plugins/qmljseditor/qmljseditorconstants.h +++ b/src/plugins/qmljseditor/qmljseditorconstants.h @@ -40,7 +40,6 @@ const char C_QMLJSEDITOR_ID[] = "QMLProjectManager.QMLJSEditor"; const char C_QMLJSEDITOR_DISPLAY_NAME[] = QT_TRANSLATE_NOOP("OpenWith::Editors", "QMLJS Editor"); const char TASK_SEARCH[] = "QmlJSEditor.TaskSearch"; const char SETTINGS_CATEGORY_QML[] = "J.QtQuick"; -const char SETTINGS_TR_CATEGORY_QML[] = QT_TRANSLATE_NOOP("QmlJSEditor", "Qt Quick"); const char FIND_USAGES[] = "QmlJSEditor.FindUsages"; const char RENAME_USAGES[] = "QmlJSEditor.RenameUsages"; |