diff options
author | hjk <hjk@qt.io> | 2019-02-18 13:02:36 +0100 |
---|---|---|
committer | hjk <hjk@qt.io> | 2019-02-19 09:21:56 +0000 |
commit | 139f700162f4a37e35048b9dce22e4369aae450c (patch) | |
tree | a0dc01b3b52c7f281fa6eaa079ac668d351a02b8 /src/plugins/remotelinux | |
parent | 2562d540f90f708552ec94205135b3b3e9669392 (diff) |
QtSupport: Replace BaseQtVersion::clone()
... by a mechanism that doesn't require re-implementation in each
derived class.
A QtVersion's type() is uniquely defined by the supported type of
the factory creating it, so that factory can be found and used
for cloning. Non-base data is copied by a fromMap(toMap()) dance
as done in the project configurations.
As a side-effect, the *QtVersion copy constructors are not used
and not needed anymore.
Change-Id: I3aa5a0fd90a27dd115769e0573647cb5669641a0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/plugins/remotelinux')
-rw-r--r-- | src/plugins/remotelinux/embeddedlinuxqtversion.cpp | 10 | ||||
-rw-r--r-- | src/plugins/remotelinux/embeddedlinuxqtversion.h | 4 |
2 files changed, 0 insertions, 14 deletions
diff --git a/src/plugins/remotelinux/embeddedlinuxqtversion.cpp b/src/plugins/remotelinux/embeddedlinuxqtversion.cpp index a163f418c4a..10de3a6bf59 100644 --- a/src/plugins/remotelinux/embeddedlinuxqtversion.cpp +++ b/src/plugins/remotelinux/embeddedlinuxqtversion.cpp @@ -35,16 +35,6 @@ namespace RemoteLinux { namespace Internal { -EmbeddedLinuxQtVersion *EmbeddedLinuxQtVersion::clone() const -{ - return new EmbeddedLinuxQtVersion(*this); -} - -QString EmbeddedLinuxQtVersion::type() const -{ - return QLatin1String(RemoteLinux::Constants::EMBEDDED_LINUX_QT); -} - QString EmbeddedLinuxQtVersion::description() const { return QCoreApplication::translate("QtVersion", "Embedded Linux", "Qt Version is used for embedded Linux development"); diff --git a/src/plugins/remotelinux/embeddedlinuxqtversion.h b/src/plugins/remotelinux/embeddedlinuxqtversion.h index d929d812159..e70eea1df36 100644 --- a/src/plugins/remotelinux/embeddedlinuxqtversion.h +++ b/src/plugins/remotelinux/embeddedlinuxqtversion.h @@ -36,10 +36,6 @@ class EmbeddedLinuxQtVersion : public QtSupport::BaseQtVersion public: EmbeddedLinuxQtVersion() = default; - EmbeddedLinuxQtVersion *clone() const override; - - QString type() const override; - QString description() const override; QSet<Core::Id> targetDeviceTypes() const override; |