diff options
author | Friedemann Kleint <Friedemann.Kleint@nokia.com> | 2009-12-08 14:26:41 +0100 |
---|---|---|
committer | Friedemann Kleint <Friedemann.Kleint@nokia.com> | 2009-12-08 14:26:41 +0100 |
commit | 8097879d6d98ce304f742823ccb9bddfcec44839 (patch) | |
tree | f4d54d94f4ef9b88dc3bafebdb02d52a178c8b2d /src/plugins/subversion/subversioncontrol.h | |
parent | 8d6b4e51ab9b8cc2b6642e7de8a644fdec82c07b (diff) |
VCS: Introduce Base class for VCS plugins, use in git.
Fixes:
- Cannot diff a file that does not belong to a project
- Cannot commit when a temporary diff/log view is open
due to the current file pointing to a temporary directory
- git's project-related actions not passing the correct
relative path.
Implementation:
- Centralize code to listen for Qt Creator's relevant state changes
in VCSBasePlugin, dispatching the changes to the instances affected.
(avoiding multiple invocations of searches/QFileInfo on current).
- Do the same for the corelistener catching closing SubmitEditors.
- Introduce VCSBasePluginState representing the relevant state
(current file/project).
- Call git with working directory set and relative arguments
- Remove setEnabled/isEnabled() logic of IVersionControl
- Pass toplevel from VCSManager to avoid duplicate searches.
Diffstat (limited to 'src/plugins/subversion/subversioncontrol.h')
-rw-r--r-- | src/plugins/subversion/subversioncontrol.h | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/plugins/subversion/subversioncontrol.h b/src/plugins/subversion/subversioncontrol.h index 325cfd1098..6e1f0d3866 100644 --- a/src/plugins/subversion/subversioncontrol.h +++ b/src/plugins/subversion/subversioncontrol.h @@ -45,9 +45,6 @@ public: explicit SubversionControl(SubversionPlugin *plugin); virtual QString name() const; - virtual bool isEnabled() const; - virtual void setEnabled(bool enabled); - virtual bool managesDirectory(const QString &directory) const; virtual QString findTopLevelForDirectory(const QString &directory) const; @@ -59,9 +56,6 @@ public: void emitRepositoryChanged(const QString &); void emitFilesChanged(const QStringList &); -signals: - void enabledChanged(bool); - private: bool m_enabled; SubversionPlugin *m_plugin; |