aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/subversion
diff options
context:
space:
mode:
authorOrgad Shaneh <orgad.shaneh@audiocodes.com>2018-11-09 09:59:40 +0200
committerOrgad Shaneh <orgads@gmail.com>2018-11-12 18:35:44 +0000
commit15b176e30c0a3a6e6effe0043a5133241caa9d2f (patch)
tree9e7d7c3ef6527dd7e988b455b13918b793d3e314 /src/plugins/subversion
parent7d56d89f255335511fb22ec43e047a0d2bb38a91 (diff)
VCS: Improve dialog on submit prompt
The dialog appears when closing the commit dialog without committing, or when "prompt to submit" setting is enabled. Fixes: QTCREATORBUG-18799 Change-Id: I8eb20becbcee7281b9f673a35ec698c6f8e04a40 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Robert Loehning <robert.loehning@qt.io> Reviewed-by: André Hartmann <aha_1980@gmx.de>
Diffstat (limited to 'src/plugins/subversion')
-rw-r--r--src/plugins/subversion/subversionplugin.cpp9
1 files changed, 3 insertions, 6 deletions
diff --git a/src/plugins/subversion/subversionplugin.cpp b/src/plugins/subversion/subversionplugin.cpp
index 66b671d1368..5c585ee264b 100644
--- a/src/plugins/subversion/subversionplugin.cpp
+++ b/src/plugins/subversion/subversionplugin.cpp
@@ -425,12 +425,9 @@ bool SubversionPlugin::submitEditorAboutToClose()
// Prompt user. Force a prompt unless submit was actually invoked (that
// is, the editor was closed or shutdown).
VcsBaseClientSettings &newSettings = client()->settings();
- const VcsBaseSubmitEditor::PromptSubmitResult answer =
- editor->promptSubmit(tr("Closing Subversion Editor"),
- tr("Do you want to commit the change?"),
- tr("The commit message check failed. Do you want to commit the change?"),
- newSettings.boolPointer(SubversionSettings::promptOnSubmitKey),
- !m_submitActionTriggered);
+ const VcsBaseSubmitEditor::PromptSubmitResult answer = editor->promptSubmit(
+ this, newSettings.boolPointer(SubversionSettings::promptOnSubmitKey),
+ !m_submitActionTriggered);
m_submitActionTriggered = false;
switch (answer) {
case VcsBaseSubmitEditor::SubmitCanceled: