diff options
| author | hjk <hjk@qt.io> | 2018-05-03 18:15:49 +0200 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2018-06-05 15:08:29 +0000 |
| commit | 0fbb2839f92b001414d1eed2ae2627cf421fd34f (patch) | |
| tree | ceffb29d5f2e3faf2fc12f5dc4612af652bf32e3 /src/plugins/valgrind/valgrindengine.cpp | |
| parent | d384e2398a21608282cb137aa039707a84c80b4e (diff) | |
Remove ApplicationLauncher::Mode
The actual remaining use was to pop up a terminal in some
setups where Mode == Console, with a default of Gui meaning
"no console". In some downstream uses it was used set to
Console (probably to mean "this helper process does not need
a gui") but then luckily ignored when actually starting the
helper processes.
All cases where the console is useful and requested are
nowadays RunWorkers belonging to RunConfigurations with
a TerminalAspect, so they can directly get the relevant bit
from their RunConfiguration without having it part of
all StandardRunnables.
Change-Id: I1368d5968da5cf672656aebf200ccac8d45335d0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Diffstat (limited to 'src/plugins/valgrind/valgrindengine.cpp')
| -rw-r--r-- | src/plugins/valgrind/valgrindengine.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/plugins/valgrind/valgrindengine.cpp b/src/plugins/valgrind/valgrindengine.cpp index 82ed9cc0f9..b286fd138d 100644 --- a/src/plugins/valgrind/valgrindengine.cpp +++ b/src/plugins/valgrind/valgrindengine.cpp @@ -38,6 +38,7 @@ #include <projectexplorer/projectexplorericons.h> #include <projectexplorer/runconfiguration.h> +#include <projectexplorer/runconfigurationaspects.h> #include <QApplication> @@ -85,6 +86,9 @@ void ValgrindToolRunner::start() m_runner.setDevice(device()); m_runner.setDebuggee(runnable()); + if (auto aspect = runControl()->runConfiguration()->extraAspect<TerminalAspect>()) + m_runner.setUseTerminal(aspect->useTerminal()); + connect(&m_runner, &ValgrindRunner::processOutputReceived, this, &ValgrindToolRunner::receiveProcessOutput); connect(&m_runner, &ValgrindRunner::valgrindExecuted, |