diff options
| author | hjk <hjk@qt.io> | 2019-03-12 15:53:54 +0100 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2019-03-12 16:38:45 +0000 |
| commit | efb7d8deb77523cc0294d01d67e277e4ce471d33 (patch) | |
| tree | 6bf9415373ed0e6f7daa9e54d26e7089067e49fe /src/plugins/valgrind | |
| parent | d6dfa7fa77241078098b8ce0b5dad1c1b86ed1d7 (diff) | |
ProjectExplorer: Split RunControl constructor
Into a trivial bit and two setters. Plan is to use it only with information
that is truly there (e.g. kit/device only) at the user side without having
to invent a RunConfiguration "handle".
Also remove some dead code in the test runner.
Change-Id: I987881e41722178b14b91f973b84cbdb67a9f85e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/plugins/valgrind')
| -rw-r--r-- | src/plugins/valgrind/callgrindtool.cpp | 3 | ||||
| -rw-r--r-- | src/plugins/valgrind/memchecktool.cpp | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/src/plugins/valgrind/callgrindtool.cpp b/src/plugins/valgrind/callgrindtool.cpp index 88a63149505..5e54e4bbd7f 100644 --- a/src/plugins/valgrind/callgrindtool.cpp +++ b/src/plugins/valgrind/callgrindtool.cpp @@ -280,7 +280,8 @@ CallgrindTool::CallgrindTool() if (dlg.exec() != QDialog::Accepted) return; m_perspective.select(); - auto runControl = new RunControl(runConfig, CALLGRIND_RUN_MODE); + auto runControl = new RunControl(CALLGRIND_RUN_MODE); + runControl->setRunConfiguration(runConfig); if (auto creator = RunControl::producer(runConfig, CALLGRIND_RUN_MODE)) creator(runControl); const auto runnable = dlg.runnable(); diff --git a/src/plugins/valgrind/memchecktool.cpp b/src/plugins/valgrind/memchecktool.cpp index d2d723027ef..345a4cd2b98 100644 --- a/src/plugins/valgrind/memchecktool.cpp +++ b/src/plugins/valgrind/memchecktool.cpp @@ -671,7 +671,8 @@ MemcheckTool::MemcheckTool() return; TaskHub::clearTasks(Debugger::Constants::ANALYZERTASK_ID); m_perspective.select(); - RunControl *rc = new RunControl(runConfig, MEMCHECK_RUN_MODE); + RunControl *rc = new RunControl(MEMCHECK_RUN_MODE); + rc->setRunConfiguration(runConfig); if (auto creator = RunControl::producer(runConfig, MEMCHECK_RUN_MODE)) creator(rc); const auto runnable = dlg.runnable(); |