diff options
author | Christian Kandeler <christian.kandeler@qt.io> | 2020-02-06 12:20:23 +0100 |
---|---|---|
committer | Christian Kandeler <christian.kandeler@qt.io> | 2020-02-06 12:14:03 +0000 |
commit | 67f66a39be86ad5b361e554355bbe7889d030ca9 (patch) | |
tree | 6893c1b1760f10eb11b701761d5e5d4f8ff50580 /src/plugins/vcsbase | |
parent | 4454873b544a35441547070d75f4a4d36808a699 (diff) |
VcsBase: Fix memory leak
Change-Id: Icb0c2a86ee0d5a1e22dc17fbc2a5d155b928e459
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/vcsbase')
-rw-r--r-- | src/plugins/vcsbase/vcsoutputformatter.cpp | 8 | ||||
-rw-r--r-- | src/plugins/vcsbase/vcsoutputformatter.h | 4 |
2 files changed, 4 insertions, 8 deletions
diff --git a/src/plugins/vcsbase/vcsoutputformatter.cpp b/src/plugins/vcsbase/vcsoutputformatter.cpp index 82b06bf7fe..7a283acd83 100644 --- a/src/plugins/vcsbase/vcsoutputformatter.cpp +++ b/src/plugins/vcsbase/vcsoutputformatter.cpp @@ -25,21 +25,17 @@ #include <QDesktopServices> #include <QPlainTextEdit> -#include <QRegularExpression> #include <QTextCursor> #include <QUrl> namespace VcsBase { -VcsOutputFormatter::VcsOutputFormatter() -{ - m_urlRegexp = new QRegularExpression("https?://\\S*"); -} +VcsOutputFormatter::VcsOutputFormatter() : m_urlRegexp("https?://\\S*") {} void VcsOutputFormatter::appendMessage(const QString &text, Utils::OutputFormat format) { QString out = text; - const QRegularExpressionMatch match = m_urlRegexp->match(text); + const QRegularExpressionMatch match = m_urlRegexp.match(text); if (match.hasMatch()) { const QTextCharFormat normalFormat = charFormat(format); OutputFormatter::appendMessage(text.left(match.capturedStart()), format); diff --git a/src/plugins/vcsbase/vcsoutputformatter.h b/src/plugins/vcsbase/vcsoutputformatter.h index 57757919ea..fd38ffa627 100644 --- a/src/plugins/vcsbase/vcsoutputformatter.h +++ b/src/plugins/vcsbase/vcsoutputformatter.h @@ -25,7 +25,7 @@ #include <utils/outputformatter.h> -QT_FORWARD_DECLARE_CLASS(QRegularExpression); +#include <QRegularExpression> namespace VcsBase { @@ -38,7 +38,7 @@ public: void handleLink(const QString &href) override; private: - QRegularExpression *m_urlRegexp = nullptr; + const QRegularExpression m_urlRegexp; }; } |