Vcs: Separate plugin and QObject parent roles for VcsSubmitEditorFactory

These are different when the factories are used as real members,
as already done in Bazaar.

Change-Id: I3c187896dcbacb5156be1543424ccacb9140a493
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

2 files changed, 5 insertions, 3 deletions

diff --git a/src/plugins/vcsbase/basevcssubmiteditorfactory.cpp b/src/plugins/vcsbase/basevcssubmiteditorfactory.cpp
index b6d862a6e1..be84f19c42 100644
--- a/src/plugins/vcsbase/basevcssubmiteditorfactory.cpp
+++ b/src/plugins/vcsbase/basevcssubmiteditorfactory.cpp
@@ -43,8 +43,9 @@ const char DIFF_SELECTED[] = "Vcs.DiffSelectedFiles";
 VcsSubmitEditorFactory::VcsSubmitEditorFactory
         (const VcsBaseSubmitEditorParameters &parameters,
          const EditorCreator &editorCreator,
-         VcsBasePluginPrivate *plugin)
-    : IEditorFactory(plugin)
+         VcsBasePluginPrivate *plugin,
+         QObject *parent)
+    : IEditorFactory(parent)
 {
     setId(parameters.id);
     setDisplayName(QLatin1String(parameters.displayName));
diff --git a/src/plugins/vcsbase/basevcssubmiteditorfactory.h b/src/plugins/vcsbase/basevcssubmiteditorfactory.h
index 133d9fd0ff..15386b915a 100644
--- a/src/plugins/vcsbase/basevcssubmiteditorfactory.h
+++ b/src/plugins/vcsbase/basevcssubmiteditorfactory.h
@@ -49,7 +49,8 @@ public:
 
     VcsSubmitEditorFactory(const VcsBaseSubmitEditorParameters &parameters,
                            const EditorCreator &editorCreator,
-                           VcsBasePluginPrivate *plugin);
+                           VcsBasePluginPrivate *plugin,
+                           QObject *parent = nullptr);
 
 private:
     QAction *m_submitAction = nullptr;