diff options
author | hjk <hjk@qt.io> | 2019-11-25 17:13:26 +0100 |
---|---|---|
committer | hjk <hjk@qt.io> | 2019-11-25 17:02:40 +0000 |
commit | e5f8d81fc86460a95a9aaf30aae6b56a7a0f1911 (patch) | |
tree | d3d5bd3eb78c20a9f75658cdd5e4e1b4d8ce677f /src/plugins/webassembly | |
parent | 6cc15199640da6e38c7df035ba6628a5a94d490f (diff) |
WebAssembly: Use new runconfiguration aspect update mechanism
And some questions.
Change-Id: Ibedf4ffaa77390c43b36c53ff80c571a47e7ec29
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/plugins/webassembly')
-rw-r--r-- | src/plugins/webassembly/webassemblyrunconfiguration.cpp | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/src/plugins/webassembly/webassemblyrunconfiguration.cpp b/src/plugins/webassembly/webassemblyrunconfiguration.cpp index 9e0b318547..2bb8861b71 100644 --- a/src/plugins/webassembly/webassemblyrunconfiguration.cpp +++ b/src/plugins/webassembly/webassemblyrunconfiguration.cpp @@ -72,20 +72,23 @@ public: effectiveEmrunCall->setDisplayStyle(BaseStringAspect::TextEditDisplay); effectiveEmrunCall->setReadOnly(true); - auto updateConfiguration = [target, effectiveEmrunCall, webBrowserAspect] { + setUpdater([target, effectiveEmrunCall, webBrowserAspect] { effectiveEmrunCall->setValue(emrunCommand(target, webBrowserAspect->currentBrowser(), "<port>").toUserOutput()); - }; + }); - updateConfiguration(); + update(); // FIXME: Looks spurious + // FIXME: A case for acquaintSiblings? connect(webBrowserAspect, &WebBrowserSelectionAspect::changed, - this, updateConfiguration); + this, &RunConfiguration::update); + // FIXME: Is wrong after active build config changes, but probably + // not needed anyway. connect(target->activeBuildConfiguration(), &BuildConfiguration::buildDirectoryChanged, - this, updateConfiguration); + this, &RunConfiguration::update); connect(target->project(), &Project::displayNameChanged, - this, updateConfiguration); + this, &RunConfiguration::update); } }; |