diff options
| author | Orgad Shaneh <orgad.shaneh@audiocodes.com> | 2017-11-16 20:41:58 +0200 |
|---|---|---|
| committer | Orgad Shaneh <orgads@gmail.com> | 2017-11-17 07:53:32 +0000 |
| commit | 951f0e0bbd76230c97b054fb19ab23464f8f77be (patch) | |
| tree | b5d77892b1bc8d44ca8b2d02cd1aa2759cbcd87e /src | |
| parent | a02ee529ef3f172556b8b3fb73683959bedf8e1d (diff) | |
Valgrind: Fix cyclic connect
Editing the widget triggers rawPathChanged(), which calls
setValgrindExecutable, which emits valgrindExecutableChanged(), which calls
setPath on the widget.
No other path reaches any of these functions.
This causes the cursor to jump to the end, so if you want to change
'valgrind' to '/usr/local/bin/valgrind' you have to jump back after each
character.
Removed the now unused signal.
Change-Id: Iaf4e902fb9a42975e9ada6662b7a64e53fab5cad
Reviewed-by: hjk <hjk@qt.io>
Diffstat (limited to 'src')
| -rw-r--r-- | src/plugins/valgrind/valgrindconfigwidget.cpp | 2 | ||||
| -rw-r--r-- | src/plugins/valgrind/valgrindsettings.cpp | 5 | ||||
| -rw-r--r-- | src/plugins/valgrind/valgrindsettings.h | 1 |
3 files changed, 1 insertions, 7 deletions
diff --git a/src/plugins/valgrind/valgrindconfigwidget.cpp b/src/plugins/valgrind/valgrindconfigwidget.cpp index 37c1ad67a5..11352b3088 100644 --- a/src/plugins/valgrind/valgrindconfigwidget.cpp +++ b/src/plugins/valgrind/valgrindconfigwidget.cpp @@ -62,8 +62,6 @@ ValgrindConfigWidget::ValgrindConfigWidget(ValgrindBaseSettings *settings, connect(m_ui->valgrindExeChooser, &Utils::PathChooser::rawPathChanged, m_settings, &ValgrindBaseSettings::setValgrindExecutable); - connect(m_settings, &ValgrindBaseSettings::valgrindExecutableChanged, - m_ui->valgrindExeChooser, &Utils::PathChooser::setPath); connect(m_ui->smcDetectionComboBox, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged), m_settings, &ValgrindBaseSettings::setSelfModifyingCodeDetection); diff --git a/src/plugins/valgrind/valgrindsettings.cpp b/src/plugins/valgrind/valgrindsettings.cpp index a494dbae3e..08e2b62710 100644 --- a/src/plugins/valgrind/valgrindsettings.cpp +++ b/src/plugins/valgrind/valgrindsettings.cpp @@ -143,10 +143,7 @@ void ValgrindBaseSettings::toMap(QVariantMap &map) const void ValgrindBaseSettings::setValgrindExecutable(const QString &valgrindExecutable) { - if (m_valgrindExecutable != valgrindExecutable) { - m_valgrindExecutable = valgrindExecutable; - emit valgrindExecutableChanged(valgrindExecutable); - } + m_valgrindExecutable = valgrindExecutable; } void ValgrindBaseSettings::setSelfModifyingCodeDetection(int smcDetection) diff --git a/src/plugins/valgrind/valgrindsettings.h b/src/plugins/valgrind/valgrindsettings.h index b0d62e8317..4ec154158e 100644 --- a/src/plugins/valgrind/valgrindsettings.h +++ b/src/plugins/valgrind/valgrindsettings.h @@ -78,7 +78,6 @@ public: void setSelfModifyingCodeDetection(int); signals: - void valgrindExecutableChanged(const QString &); void selfModifyingCodeDetectionChanged(int); private: |