diff options
Diffstat (limited to 'src/plugins/qtsupport/baseqtversion.cpp')
-rw-r--r-- | src/plugins/qtsupport/baseqtversion.cpp | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/src/plugins/qtsupport/baseqtversion.cpp b/src/plugins/qtsupport/baseqtversion.cpp index 67cc6b8699..46ac87c90c 100644 --- a/src/plugins/qtsupport/baseqtversion.cpp +++ b/src/plugins/qtsupport/baseqtversion.cpp @@ -54,6 +54,7 @@ #include <utils/macroexpander.h> #include <utils/qtcassert.h> #include <utils/runextensions.h> +#include <utils/stringutils.h> #include <utils/synchronousprocess.h> #include <utils/winutils.h> @@ -220,7 +221,7 @@ public: bool m_qmakeIsExecutable = true; QString m_autodetectionSource; - QSet<Core::Id> m_overrideFeatures; + QSet<Utils::Id> m_overrideFeatures; FilePath m_mkspec; FilePath m_mkspecFullPath; @@ -510,8 +511,7 @@ Tasks BaseQtVersion::validateKit(const Kit *k) if (!tdt.isEmpty() && !tdt.contains(dt)) result << BuildSystemTask(Task::Warning, tr("Device type is not supported by Qt version.")); - ToolChain *tc = ToolChainKitAspect::toolChain(k, ProjectExplorer::Constants::CXX_LANGUAGE_ID); - if (tc) { + if (ToolChain *tc = ToolChainKitAspect::cxxToolChain(k)) { Abi targetAbi = tc->targetAbi(); bool fuzzyMatch = false; bool fullMatch = false; @@ -538,7 +538,7 @@ Tasks BaseQtVersion::validateKit(const Kit *k) version->displayName(), qtAbiString); result << BuildSystemTask(fuzzyMatch ? Task::Warning : Task::Error, message); } - } else if (ToolChainKitAspect::toolChain(k, ProjectExplorer::Constants::C_LANGUAGE_ID)) { + } else if (ToolChainKitAspect::cToolChain(k)) { const QString message = tr("The kit has a Qt version, but no C++ compiler."); result << BuildSystemTask(Task::Warning, message); } @@ -695,7 +695,7 @@ void BaseQtVersion::fromMap(const QVariantMap &map) d->m_data.unexpandedDisplayName.fromMap(map, Constants::QTVERSIONNAME); d->m_isAutodetected = map.value(QTVERSIONAUTODETECTED).toBool(); d->m_autodetectionSource = map.value(QTVERSIONAUTODETECTIONSOURCE).toString(); - d->m_overrideFeatures = Core::Id::fromStringList(map.value(QTVERSION_OVERRIDE_FEATURES).toStringList()); + d->m_overrideFeatures = Utils::Id::fromStringList(map.value(QTVERSION_OVERRIDE_FEATURES).toStringList()); QString string = map.value(QTVERSIONQMAKEPATH).toString(); if (string.startsWith('~')) string.remove(0, 1).prepend(QDir::homePath()); @@ -732,7 +732,7 @@ QVariantMap BaseQtVersion::toMap() const result.insert(QTVERSIONAUTODETECTED, isAutodetected()); result.insert(QTVERSIONAUTODETECTIONSOURCE, autodetectionSource()); if (!d->m_overrideFeatures.isEmpty()) - result.insert(QTVERSION_OVERRIDE_FEATURES, Core::Id::toStringList(d->m_overrideFeatures)); + result.insert(QTVERSION_OVERRIDE_FEATURES, Utils::Id::toStringList(d->m_overrideFeatures)); result.insert(QTVERSIONQMAKEPATH, qmakeCommand().toString()); return result; @@ -2133,7 +2133,7 @@ static QStringList extractFieldsFromBuildString(const QByteArray &buildString) result.append(match.captured(1)); // qtVersion // Abi info string: - QStringList abiInfo = match.captured(2).split('-', QString::SkipEmptyParts); + QStringList abiInfo = match.captured(2).split('-', Utils::SkipEmptyParts); result.append(abiInfo.takeFirst()); // cpu @@ -2217,7 +2217,7 @@ Abis BaseQtVersion::qtAbisFromLibrary(const FilePaths &coreLibraries) { Abis res; for (const FilePath &library : coreLibraries) { - for (Abi abi : Abi::abisOfBinary(library)) { + for (const Abi &abi : Abi::abisOfBinary(library)) { Abi tmp = abi; if (abi.osFlavor() == Abi::UnknownFlavor) tmp = scanQtBinaryForBuildStringAndRefineAbi(library, abi); |