diff options
Diffstat (limited to 'src')
| -rw-r--r-- | src/plugins/git/gerrit/gerritmodel.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/plugins/git/gerrit/gerritmodel.cpp b/src/plugins/git/gerrit/gerritmodel.cpp index ee60343f13..9f3a1014b6 100644 --- a/src/plugins/git/gerrit/gerritmodel.cpp +++ b/src/plugins/git/gerrit/gerritmodel.cpp @@ -67,7 +67,8 @@ QDebug operator<<(QDebug d, const GerritApproval &a) // Sort approvals by type and reviewer bool gerritApprovalLessThan(const GerritApproval &a1, const GerritApproval &a2) { - return a1.type.compare(a2.type) < 0 || a1.reviewer.fullName.compare(a2.reviewer.fullName) < 0; + const int compare = a1.type.compare(a2.type); + return compare == 0 ? a1.reviewer.fullName.compare(a2.reviewer.fullName) < 0 : compare < 0; } QDebug operator<<(QDebug d, const GerritPatchSet &p) |