aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Android: Fix QML debuggingv4.4.0-rc1Vikas Pachdha2017-08-154-5/+14
| | | | | | | | Specify the qml server address and use correct default loop back address in qmlengine Change-Id: I9b77cb3385041bbe79900e7f7a188ca26124bacc Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* More change logEike Ziller2017-08-151-2/+32
| | | | | Change-Id: If236df9562af18867f3dd4d2c0ec4a527751c6e1 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Debugger: Show guts of QString::Data when requestedhjk2017-08-151-5/+3
| | | | | | | | | If people already decide to drill into QString they are likely to want to be able to drill into QString::Data, too. Change-Id: I90cf1bd9b7bed66805fc7493cf1595d27ef3b129 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io> Reviewed-by: hjk <hjk@qt.io>
* Clang: Blacklist override warnings from Q_OBJECTNikolai Kosjar2017-08-151-3/+19
| | | | | | Task-number: QTCREATORBUG-18621 Change-Id: I20d4fd7a93e0557334135bf7bcbd2f6517a6ede6 Reviewed-by: Marco Bubke <marco.bubke@qt.io>
* Debugger: Hex-encode LLDB disassembler source lines for transporthjk2017-08-152-1/+2
| | | | | | | | Unescaped quotes break the protocol. Task-number: QTCREATORBUG-18721 Change-Id: I235c4dc33e599769bc854423ef4a7dc6f46bf58e Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Debugger: Short-circuit part of the parameter fixup machineryhjk2017-08-142-9/+12
| | | | | | | | ... which should not exist to start with, and interferes in some cases where the user code knows better. Change-Id: Ie0b0038af3a4056fad8655d06f677fc800c99f8d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Support debug requests from Task ManagerOliver Wolff2017-08-141-2/+9
| | | | | | | | | | | | | | | | | | | If debugging was started from Task Manager Windows does not follow the format given in the registry but always uses "<debugger> -p <pid>". By ignoring the -p parameter and using "debug" instead of "wincrashevent" we can also support this use case from QtC's debugger. The message which is shown in this case will be adapted as soon as this change hits master but with the current approach the situation is greatly improved for 4.4. Task-number: QTCREATORBUG-18194 Change-Id: I871a19f0cd68f61337d1e6c224ecc3c22a02c989 Reviewed-by: Robert Loehning <robert.loehning@qt.io> Reviewed-by: hjk <hjk@qt.io>
* Merge "Merge remote-tracking branch 'origin/4.3' into 4.4" into 4.4Eike Ziller2017-08-148-9/+139
|\
| * Merge remote-tracking branch 'origin/4.3' into 4.4Eike Ziller2017-08-148-9/+139
| |\ | | | | | | | | | | | | | | | | | | Conflicts: src/plugins/qmlprofiler/qmlprofilertraceview.cpp Change-Id: Ib1d75a8572f650898cb598d008867e2c0514d752
| | * QmlDesigner: Fix macOS menu issue4.3Thomas Hartmann2017-08-101-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introducing the Loader broke the menu on macOS. There is no reason to disable the Loader. This was premature optimization. Task-number: QTCREATORBUG-18662 Change-Id: Ief00246182ab1f1096efec634ed0626aeba95c84 Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
| | * QmlProfiler: Avoid empty timeline when restricting to rangesUlf Hermann2017-08-077-7/+139
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The timeline models were suspended for editing but never restored. To test the correct behavior a test case for the trace view is added. Change-Id: Ic1803e9d84656eed97795f1f1674e3d56c83f650 Task-number: QTCREATORBUG-18354 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | | Clang: Clean up clangassistproposalitem.cppNikolai Kosjar2017-08-141-19/+4
| | | | | | | | | | | | | | | | | | Change-Id: I200041b48a337912e7b3297881db58f7cf1f9b0e Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
* | | Clang: Fix cursor position after completion of overloadsNikolai Kosjar2017-08-143-10/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | struct Foo { void begin(); void begin() const; }; void c(Foo &foo) { foo.beg // complete to foo.begin()| instead of foo.begin(|) } Task-number: QTCREATORBUG-17443 Change-Id: I60ca16bbfeeb75c5c37a0d5bc6f46e9e9913b86e Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
* | | Debugger: Fix location marker update for LLDB Jump to Linehjk2017-08-141-1/+2
| | | | | | | | | | | | | | | Change-Id: I93c46eabb8c91c3e7158454f04cf027d55ece621 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | | Debugger: Re-enable some shutdown cleanup codehjk2017-08-141-29/+27
| | | | | | | | | | | | | | | | | | | | | | | | It is still needed with LLDB. Task-number: QTCREATORBUG-18723 Change-Id: If78dcbf8e074add969c403c37193c9f4ce857625 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | | Clang: Fix highlighting of template function in using declarationNikolai Kosjar2017-08-143-1/+12
|/ / | | | | | | | | | | | | | | | | | | | | This completes commit a3a62e78f7378182138555936b45a885865c00ad Clang: Fix highlighting of function in using declaration Change-Id: I3c163096374d7a1f45a590bb8ebfe5f5a1f8d417 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
* | QmlProfiler: Rebuild the flamegraph model when visible features changeUlf Hermann2017-08-144-14/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | This is more expensive than just setting the filtered items' height to 0. However, this way we implicitly also change the size of the root element, group equal items that end up on the same level by filtering, recalculate the cutoff for too small items and resort all items by width. Change-Id: Ida2c5acd9848c5644ecff052d78e9fe5ad962606 Task-number: QTCREATORBUG-18713 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | QmlProfiler: In statistics use non-recursive time as totalUlf Hermann2017-08-141-5/+5
| | | | | | | | | | | | | | | | | | | | Otherwise the percentages and totals don't match. The extra recursive time is shown in the tooltip, without percentage (as there wouldn't be a sensible base value for a percentage number). Change-Id: I47fcf92aac3f60554219f7da9dd2ac90061ce496 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Fix buildJake Petroules2017-08-141-6/+2
| | | | | | | | | | | | | | | | Amends 5e6ff55 Change-Id: Iab56b5d06335ce916cd9381ea7ea58c4f8759116 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
* | Doc: Describe QML/JS editing optionsLeena Miettinen2017-08-142-0/+6
| | | | | | | | | | Change-Id: I9ee84a08a45796f77bb6acf620327059b4cab93d Reviewed-by: Marco Benelli <marco.benelli@qt.io>
* | Fix deployment to Windows 10 Mobile devicesJake Petroules2017-08-141-1/+7
| | | | | | | | | | | | | | Task-number: QTCREATORBUG-18728 Change-Id: Ib04ca8a0a163611bbb53bc50f2e0009ab460ce35 Reviewed-by: Oliver Wolff <oliver.wolff@qt.io> Reviewed-by: Maurice Kalinowski <maurice.kalinowski@qt.io>
* | ClangStaticAnalyzer: Don't show 'stopped by user' if it wasn'thjk2017-08-111-3/+5
| | | | | | | | | | | | Task-number: QTCREATORBUG-18581 Change-Id: Ib5d2aded5da14e44f3186a2ed67f119764d6d58d Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* | QmlProfiler: Don't add an extra nanosecond to the flame graph bottomUlf Hermann2017-08-111-1/+1
| | | | | | | | | | Change-Id: Icda2b69363439de92a012a0cf46b8084b69d777d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | QmlDesigner: Fix crashThomas Hartmann2017-08-111-5/+5
| | | | | | | | | | | | | | | | | | This was introduced when adjusting the selection behaivour. We have to check for the empty list before we call itemList.first(). Change-Id: I12a12bc17f1f513304c8df738e76db999267854a Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
* | QmlDesigner: Fix crashThomas Hartmann2017-08-111-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | This was introduced when adjusting the selection behaivour. When we change to the selection tool we might delete items. This item could be in itemlist we forward to AbstractFormEditorTool. Therefore we change to the selection tool after calling mouseReleaseEvent(). Change-Id: I5cab902b8560780c6ee4edc3466e7087d719f1ef Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
* | Fix docs about QML debuggingUlf Hermann2017-08-111-29/+10
| | | | | | | | | | | | | | | | | | | | | | You can only debug QtQuick 2, and you need Qt 5.0 for that. Also, the port is not well known as it's chosen at runtime, and various features of the QML inspector have been dropped. Change-Id: Ibb2fa6c4de203423c4e0cb9f240643e7354e7a34 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Andy Shaw <andy.shaw@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* | DiffEditor: Fix saving diff containing new or deleted filesJarek Kobus2017-08-102-18/+56
| | | | | | | | | | | | | | | | Fix also the case when new file was empty. Fix some const correctness. Change-Id: Ied71c3de0398914e595fbf542f1b8ec3659d69b6 Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* | DiffEditor: Optimize patch processingJarek Kobus2017-08-101-282/+375
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Get rid of QRegularExpressions, they are very slow. Simplify readGitPatch() a lot. Make reading of the patch about 20 times faster, especially make readGitDiff() itseft (excluding the calls to readChunks) working about 1000 times faster for huge diffs. So, the processing time for e.g. the bottom commit of qttools module (the import commit) decreased from ~20 seconds to ~1 second. Implement nice progress of patch reading. Change-Id: Ie24786596237bde475e37337663018a8bec086bb Reviewed-by: Tobias Hunger <tobias.hunger@qt.io> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* | QmlProfiler: Include qtcfallthrough.h for Q_FALLTHROUGHUlf Hermann2017-08-101-0/+1
| | | | | | | | | | Change-Id: Iac3b7ea8314eff6e15c3c4a04a612a8026bf040f Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | DeviceSupport: Implement DesktopDevice::portsGatheringMethod()hjk2017-08-107-60/+152
| | | | | | | | | | | | | | | | | | | | | | | | | | The feature is useful in a QtApplicationManager debugging context. Internally, DeviceUsedPortsGatherer uses a DeviceProcess now, not an SshRemoteProcess, to cover cases where the (Windows Desktop) device not have ssh available. Change-Id: I9d33ceac65a135123a376ebd2727dcb540563179 Reviewed-by: Wolfgang Bremer <wolfgang.bremer@pelagicore.com> Reviewed-by: Dan Cape <dcape@qnx.com> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Qnx: Create slog2 runner processes at more reasonable timeshjk2017-08-101-4/+5
| | | | | | | | | | | | | | | | 89f02cba2ca65f introduced a regression. Change-Id: I3ae4ecc7f2dfcd477ffe7a277a87acd90aad5339 Reviewed-by: Dan Cape <dcape@qnx.com> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | QmlProfiler: Clean up some includeshjk2017-08-101-12/+2
| | | | | | | | | | Change-Id: Ia4706170b07070e46c62296a806e785d96d2f4ef Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* | QmlProfiler: Express record button state in a single functionUlf Hermann2017-08-102-53/+45
| | | | | | | | | | | | | | | | | | This way we get a concise description of the inputs it reacts to and we don't have to dereference the pointer in unrelated code, which lead to crashes on shutdown. Change-Id: Ieb75ab95cccc0d1f88420b270909c97867a5c3e0 Reviewed-by: hjk <hjk@qt.io>
* | Debugger: Add some hints on how the Python manual test workshjk2017-08-103-1/+6
| | | | | | | | | | Change-Id: I7a20451739c759510ea2d400493985ae543c6965 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | QmlProfiler: Merge inferior worker into LocalQmlProfilerSupporthjk2017-08-102-31/+7
| | | | | | | | | | Change-Id: Ie9f9db6ecf2891731e90326b4a27b2d819b1e7ca Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* | QmlProfiler: Move TCP connection initialization to runworker's start()hjk2017-08-102-43/+36
| | | | | | | | | | | | | | | | That makes the high level sequence of operation the same as for the local socket case. Change-Id: Ib8af2a7826a482e98b75fe00f3c0e672b98886c5 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* | QmlProfiler: Remove connection timerhjk2017-08-102-63/+0
| | | | | | | | | | | | | | | | | | | | The connection timer was traditionally used in cases where the application was started without being given a port on the commandline. These setups do not exist anymore or have been changed to provide a suitable port on the commandline. Change-Id: Ib4653e73943819762f0c8162cc13e4da789705a7 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* | QmlProfiler: Fix and extend the local qml profiler runner testUlf Hermann2017-08-102-73/+86
| | | | | | | | | | | | | | | | We need to indirectly verify that the profiler support is doing the right thing by watching the RunControl's state transitions. Change-Id: I8f92f21022668ed3bb28477152132ccdcffaaea6 Reviewed-by: hjk <hjk@qt.io>
* | Debugger: Switch perspective when coming from another modeNikolai Kosjar2017-08-101-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | Problematic case was: 1. Run some analyzer (mode switch: edit->debug) 2. Close project, re-open it (mode switch: debug->edit) 3. Run analyzer from 1. again --> Ops, no mode switch to debug mode (and thus no analyzer view) because it's still the same perspective Task-number: QTCREATORBUG-18549 Change-Id: Iccb1e0629454c1373280a55d6c41410c7161520e Reviewed-by: hjk <hjk@qt.io>
* | Doc: Fix paths to Qt Quick Toolbar optionsLeena Miettinen2017-08-101-4/+3
| | | | | | | | | | | | | | The options were moved to the "QML/JS Editing" tab. Change-Id: Ieccc6b1fa2d051a6986a6050bff6d0a6710ffb26 Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
* | QmlProfiler: Connect to timelabel only after it is createdUlf Hermann2017-08-101-1/+1
| | | | | | | | | | | | Change-Id: If9e810cfbd5162f1e40db24db2f8f784accaff4e Task-number: QTCREATORBUG-18597 Reviewed-by: hjk <hjk@qt.io>
* | QmlJs: fix false positives for propertiesMarco Benelli2017-08-101-0/+3
| | | | | | | | | | | | | | | | Resolve references while looking up for object members. Task-number: QTCREATORBUG-18362 Change-Id: I9d2b2457fb3488c723a41e4e8ba1fc0ea9fe800f Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
* | QmlProfiler: Stop the recording timer when the time label is destroyedUlf Hermann2017-08-091-0/+1
| | | | | | | | | | | | | | | | Writing to the label is all it does, and that crashes if the label is gone. Change-Id: I23bbbe0c46603a8de91143ee6167cb404c1b0004 Reviewed-by: hjk <hjk@qt.io>
* | ProjectExplorer: Introduce RunWorker::reportDone()hjk2017-08-093-1/+30
| | | | | | | | | | | | | | | | | | | | | | | | To be used for short-lived tasks to signal that they are done. Essentially an optional reportStarted() followed by reportStopped() Using it in GdbServerPortsGatherer when the port list is ready fixes the wrong "un-stopped" situation in RemoteLinux debugging when the inferior finishes by itself. Change-Id: I310831a7875fe6f2c598302b73cda6c9669efb1d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | QmlDesigner: Some cleanupThomas Hartmann2017-08-091-14/+0
| | | | | | | | | | Change-Id: Ic89c578474d7cdf1f72a61a91d0cdf32f7b70a7f Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
* | ProjectExplorer: Introduce an "essential" flag for RunWorkerUlf Hermann2017-08-092-0/+18
| | | | | | | | | | | | | | | | An essential RunWorker triggers the whole RunControl to stop if it spontaneously stops. Change-Id: Ia05b927e306022e99b45cc8cd7ab9636f4d3c129 Reviewed-by: hjk <hjk@qt.io>
* | QmlProfiler: reportStopped() only when entering Idlehjk2017-08-091-2/+2
| | | | | | | | | | Change-Id: I291ff6506a16e294165109a89f2acf22d24d7928 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* | ProjectExplorer: Allow RunWorker::Starting -> Stoppinghjk2017-08-091-1/+4
| | | | | | | | | | | | | | Can happen on worker startup, e.g. missing binaries, permissions, ... Change-Id: Ibeee0a6992af80d3486b00890664e83525f17204 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* | ProjectExplorer: If a worker fails while we're stopping, continueUlf Hermann2017-08-091-1/+4
| | | | | | | | | | | | | | We don't need to re-initiate the stopping. Change-Id: I2c19dca854c93e0340227d08a381c3bde919363d Reviewed-by: hjk <hjk@qt.io>
* | ScxmlEditor: Make the Attribute Editor table themableAlessandro Portale2017-08-091-3/+1
| | | | | | | | | | | | | | | | ...by not using hardcoded colors. Task-number: QTCREATORBUG-18685 Change-Id: Idbe694b4112cb2c7d82738598fb04c68c510c609 Reviewed-by: Marco Benelli <marco.benelli@qt.io>