aboutsummaryrefslogtreecommitdiffstats
path: root/src/libs/utils/settingsaccessor.h
Commit message (Collapse)AuthorAgeFilesLines
* Utils: Rename FilePathList to simply FilePathshjk2019-12-181-3/+3
| | | | | | | The exact storage type does not really matter here. Change-Id: Iefec40f0f5909c8e7ba3415db4a11962694e1b38 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Utils: Rename FileName to FilePathhjk2019-05-281-23/+23
| | | | | | | | More in line with QFileInfo terminonlogy which appears to be best-of-breed within Qt. Change-Id: I1d051ff1c8363ebd4ee56376451df45216c4c9ab Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Utils: Modernize furtherAlessandro Portale2018-07-241-2/+2
| | | | | | | | | | | | | | | Many issues, mostly in headers, were not addressed in e38410b76c40ffde33cf1ab405926cd243c4e48c modernize-use-auto modernize-use-nullptr modernize-use-override modernize-use-using modernize-use-default-member-init modernize-use-equals-default Change-Id: I320a51726db881e582b898948d53735ebb06887a Reviewed-by: hjk <hjk@qt.io>
* Utils: Remove superfluous qualificationsOrgad Shaneh2018-07-191-19/+19
| | | | | Change-Id: I36e17dac0cff87f82f0ddaf97bc613389110f218 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Utils: Use override consistentlyTobias Hunger2018-05-131-2/+2
| | | | | | | clang-tidy fixes from modernize-use-override check. Change-Id: I89d27f359b6ee507153cb3712f61f81471ff0858 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* ProjectExplorer: Do not overwrite shared project settingsOrgad Shaneh2018-05-081-0/+2
| | | | | Change-Id: Iecf684677599975e6f44df0d354ce7cd8c7aeeb9 Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* ToolChain: Use SettingsAccessor to access XML settingsTobias Hunger2018-04-201-1/+3
| | | | | | | | | This allows for use of the new SettingsAccessor infrastructure for upgrading, backups, etc. Task-number: QTCREATORBUG-20148 Change-Id: I5419c86c0fd576a59ec91c212097c8f987e01da2 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* SettingsAccessor: Rename BasicSettingsAccessor to SettingsAccessorTobias Hunger2018-02-151-12/+12
| | | | | | | | Rename BasicSettingsAccessor to SettingsAccessor, now that the name is available again. Change-Id: I49473f0c701976f992209f06d48decf047ab19de Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* SettingsAccessor: Improve test by mocking out read/write operationsTobias Hunger2018-02-141-2/+2
| | | | | Change-Id: I4d4cf6ff0be3d4b8278a7613c26f2b1752304ad4 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* SettingsAccessor: Extract functionality to merge settingsTobias Hunger2018-02-141-20/+42
| | | | | | | | | | | | | | | | | Move functionality related to merging settings into MergingSettingsAccessor, move code specific to the .user-files into UserFileAccessor. Remove SettingsAccessor class, now that all code has been moved out of it. This patch changes the merge mechanism a bit: It used to upgrade the user and tha shared file to the higher version of these two, merge, and then upgrade the merged result to the newest version. Now it upgrades both the user as well as the shared file to the newest version and only merges afterwards. Change-Id: I2a1605cbe9b9fb1404fcfa9954a9f3410da0abb1 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* SettingsAccessor: Extract upgrading functionalityTobias Hunger2018-02-141-54/+80
| | | | | | | | | | | | | | | Extract upgrading functionality from SettingsAccessor into UpgradingSettingsAccessor. Fixes surprising behavior in test ProjectExplorerPlugin::testUserFileAccessor_prepareToReadSettingsObsoleteVersionNewVersion where the Version was thrown away. Also adds a error/warning distinction to BasicSettingsAccessor::Issue, so that the non-critical ones can be ignored later. Change-Id: Ia38d074f91cd8d8f820f9bec96d3330d748564c7 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* SettingsAccessor: Use optional for return value of BackUpStrategy::backupNameTobias Hunger2018-02-131-6/+6
| | | | | Change-Id: I70aacd5804b10ee51c81c3e3d877f7c142d618b4 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* SettingsAccessor: Extract handling of backupsTobias Hunger2018-02-131-20/+85
| | | | | | | | | | | Extract the code that handles backups from the SettingsAccessor into a BackingUpSettingsAccessor. Move code up from SettingsAccessor into UserFileAccessor where it belongs. This became possible due to the extraction. Change-Id: Icacaa4e7231b3c0c520154c76f9338227f96a614 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* SettingsAccessor: Unify handling of different file locationsTobias Hunger2018-02-061-0/+4
| | | | | | | | Unify the code calculating the different file locations used by the SettingsAccessor. Change-Id: I85283f99618143ce1fbdd309bce12529cec442ca Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Settingsaccessor: Extract file access and error reportingTobias Hunger2018-01-151-39/+64
| | | | | | | | Move file access and error reporting out of SettingsAccessor and into BasicSettingsAccessor. Change-Id: If6cc9157c1a532f117c48b929c05f55d89a339eb Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* UserFileAccessor: Add testsTobias Hunger2018-01-081-1/+2
| | | | | Change-Id: I310fdd542f0629a2353229be3e479a9f916fec19 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* SettingsAccessor: Add setters to VersionUpgraderTobias Hunger2017-11-301-2/+7
| | | | | | | | Add setters to VersionUpgrader and use them. This shortens the implementation classes a bit. Change-Id: I5ffe6f085752bf39bbcb08c286844cc1088eeea5 Reviewed-by: Marco Bubke <marco.bubke@qt.io>
* SettingsAccessor: Factor out basic load/save behaviorTobias Hunger2017-11-221-6/+31
| | | | | Change-Id: I654321167c623b507a9f109e42f77f41df3eccd2 Reviewed-by: Marco Bubke <marco.bubke@qt.io>
* SettingsAccessor: Do not hard-code document typeTobias Hunger2017-11-221-1/+1
| | | | | Change-Id: Ied886eac9fcb4a9c58f088c32ee5ba0646b94fbc Reviewed-by: Marco Bubke <marco.bubke@qt.io>
* SettingsAccessor: Use optional as return value of findIssuesTobias Hunger2017-11-221-28/+5
| | | | | Change-Id: Ib7ef8ec408f812a71735939514d98cf8755d292b Reviewed-by: Marco Bubke <marco.bubke@qt.io>
* SettingsAccessor: Add methods to upgrade to a specific versionTobias Hunger2017-11-221-0/+1
| | | | | Change-Id: If368f4a35d3702dbf680b1306ca6311070aa9bb5 Reviewed-by: Marco Bubke <marco.bubke@qt.io>
* SettingsAccessor: Improve SettingsAccessor::isBetterMatchTobias Hunger2017-11-221-1/+3
| | | | | | | | Improve the behavior of isBetterMatch, so that it now handles invalid versions as well as invalid ids. Simplify code where possible. Change-Id: I2e65c0cc01d32fa77df8b5ec0d62b765e6c458f7 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Move SettingsAccessor from ProjectExplorer into UtilsTobias Hunger2017-11-201-0/+154
Change-Id: I83e9d7ef81f8c0af7220ce2777723db53ef2e02a Reviewed-by: Eike Ziller <eike.ziller@qt.io>