aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/bazaar
Commit message (Collapse)AuthorAgeFilesLines
* Bazaar: Simplify BazaarPluginPrivate::isConfigured() checkhjk2021-08-201-4/+1
| | | | | Change-Id: If3e940c38149f5ae75d99582593918f4847c8c3e Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Use more FilePath for file pathshjk2021-08-023-43/+40
| | | | | Change-Id: I855cde65d034a9647972a7fddf1e8266d7ccfa88 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VCS: Partially use FilePath in VcsBaseClienthjk2021-07-301-1/+1
| | | | | Change-Id: I024b051ab98ece42ec011bd1c92887a946925c1a Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Replace findRepositoryForDirectoryhjk2021-07-303-8/+5
| | | | | | | | By some function findRepositoryForFile operating on any file and using FilePath. Change-Id: I91b8aa38b1c6b33993b9b790fbc2ff4d378ad8a8 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Use FilePath in IVersionControl APIhjk2021-07-291-27/+27
| | | | | | | | Adapt first level of users. Change-Id: Ifcd7bff45631ff3b9e26a9e3176daa6cf0cf2e56 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Fix lupdate issuesEike Ziller2021-07-091-0/+2
| | | | | | | | | Some tr functions missing, some places where we need full qualification because lupdate gets confused with namespaces. Change-Id: Ic1d6ef3b31960dda02bc0788a255857117acdca9 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* All: Replace most SynchronousProcess by QtcProcesshjk2021-06-231-2/+2
| | | | | Change-Id: I0bf22fef2cd4a7297ef5a1e9aa9c3e2b9348ba42 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Rename QtcProcess::Result::Finished to FinishedWithSuccesshjk2021-06-021-4/+4
| | | | | | | | | | | | To make clear that this is not just any finish. Also change FinishedError to FinishedWithError, to create symmetry. Also adapt enum member description to reality. Change-Id: I13e05391eb86fdb24e2ae660f14dfddb282e1104 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Utils: filepathify fileutilsDavid Schulz2021-05-181-1/+1
| | | | | Change-Id: Ic9048369f64d793f5f567cdb0c715488fb5a4ff6 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Utils: Make process results accessible through QtcProcess objecthjk2021-05-141-8/+10
| | | | | | | | | | | | | | | | The result is fully stored in the object anyway. Using the extra SynchronousProcessResponse structure only causes copies of the data and complicates access on the user side in a lot of cases. The result bits are now also accessible individually. There's obvious room for follow-up changes on the topic, e.g. ShellCommand::runCommand's parameter list could shrink to just a SynchronousProcess parameter. Change-Id: I45aa7eb23832340be06905929280c012e1217263 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Utils: Don't expose Utils::defaultExitCodeInterpreterhjk2021-05-111-1/+1
| | | | | | | Instead, make its behavior implicit if none is given. Change-Id: I3c1a054751a0afe22d0f40a2fed6dd00b5aef205 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Vcs/Utils: Use Utils::Environment for ShellCommandhjk2021-05-051-2/+2
| | | | | Change-Id: Ica289ab2f83d52270923c4ff4983860cfbe0b494 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Bazaar: Use the new AspectContainer::applied signalhjk2021-04-073-75/+43
| | | | | | | Also, remove unused BazaarSettings::sameUserId() Change-Id: Ie3e39f2dff506932a2b6ef0a3dbffae9e40db64c Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: Use a full layout row for an aspect for Columns and Formshjk2021-03-251-3/+1
| | | | | | | | | | Avoids some boilerplate on the user code side. This seems to be the only existing case. If there'd ever be a case where this is not appropriate, an extra Row { ... } would solve it. Change-Id: I1ae1102e895640c0acc03b4949e3baabecfcdc49 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Locator: Add longer description to filtersEike Ziller2021-03-231-0/+1
| | | | | | | | | | This is shown as tool tips in the location options, and if any platform supports this also as tool tips on the menu actions of the locator input field. Change-Id: I8b439e45e6097a16a5f932d25d4e5d3e9bddb6ad Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: David Schulz <david.schulz@qt.io>
* VcsBase: Remove VcsBaseClientSettingshjk2021-03-221-1/+1
| | | | | | | It's replaced by VcsBaseSettings. Change-Id: I60a0e4e267337f71e8a32b9b220565b765c973b1 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Bazaar: Aspectify settingshjk2021-03-1910-372/+169
| | | | | Change-Id: I0354698cf3473dd096e57481a945f0f59afc75b3 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* EditorManager: Small API clean-upEike Ziller2020-09-301-1/+1
| | | | | | | | | - Move private enum to private header - Add missing parameter to openEditorAtSearchResult - Remove convenience singular close* methods, we have {} nowadays Change-Id: Ic5b6d831a9f506ffee09b89b3358874433d62998 Reviewed-by: David Schulz <david.schulz@qt.io>
* Utils: Drop Utils::SkipEmptyParts againhjk2020-07-211-1/+1
| | | | | | | | We require Qt 5.14 nowadays. Change-Id: Iff245257d3cb19207007c0445ee13814e66152dd Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Core/Utils: Migrate further to Utils::Idhjk2020-07-063-9/+6
| | | | | | | The coreplugin/id.h header is kept for downstream for now. Change-Id: I8c44590f7b988b3770ecdc177c40783e12353e66 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Bazaar: Replace QRegExphjk2020-06-247-26/+35
| | | | | | Task-number: QTCREATORBUG-24098 Change-Id: I450d5756359596495f501759670970c9c541d4d9 Reviewed-by: Hugues Delorme <delorme.hugues@fougue.pro>
* VCS: Add vcsDescribeOrgad Shaneh2020-06-181-5/+4
| | | | | | | Already exists in all implementations, but there was no common declaration. Change-Id: Ieb3d10d1936c207722b5001712bce41e8114dcdc Reviewed-by: André Hartmann <aha_1980@gmx.de>
* IVersionControl: Change vcsAnnotate return type to voidOrgad Shaneh2020-06-181-3/+2
| | | | | | | | | | | All implementations return true unconditionally, and the return value is never read anyway. + Remove superfluous function with the same name in Perforce. Change-Id: I83f361ec7fd8be3177cb4be52e6276e295cd4279 Reviewed-by: André Hartmann <aha_1980@gmx.de> Reviewed-by: hjk <hjk@qt.io>
* All: Use Utils::SkipEmptyPartshjk2020-06-171-1/+2
| | | | | | Task-number: QTCREATORBUG-24098 Change-Id: Iab45de9a9c17ddc39a0e343b1175d4f6cb94b098 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Replace FileChooser::path() by filePath().toString()hjk2020-04-091-1/+1
| | | | | | | | | | | Keep the old method for now to ease downstream porting. The change is kept mechanical, there's a lot of cleanup possible now on the user code side. Change-Id: I936baedd45b7ba057f1c789a1bec896886f48eff Reviewed-by: André Hartmann <aha_1980@gmx.de> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VCS: Replace QRegExp with QRegularExpression in VcsBaseEditorOrgad Shaneh2020-02-211-3/+2
| | | | | | Change-Id: I8e8a6649e441597e29e88506d494ec69260bebd1 Reviewed-by: Samuel Gaist <samuel.gaist@idiap.ch> Reviewed-by: André Hartmann <aha_1980@gmx.de>
* VCS: Refactor annotationChanges() in VcsBaseEditorOrgad Shaneh2020-02-202-23/+1
| | | | | | | Devirtualize the function, and use QRegularExpression with globalMatch. Change-Id: I18c92cb37b535c616f03f45dff8b18249c961d5d Reviewed-by: hjk <hjk@qt.io>
* VCS: Abstract multi-choice settings in editor configOrgad Shaneh2020-02-131-6/+7
| | | | | Change-Id: Iafc089f5ad3796348ab9521b71b31cb645238292 Reviewed-by: hjk <hjk@qt.io>
* Vcs: Make VcsBaseEditorWidget::test* operate on factories directlyhjk2020-02-131-2/+2
| | | | | | | Saves re-discovery by id. Change-Id: I026c1388d02f125147a9b4f5367d7a1a266bff3c Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Make some editor factories proper plugin pimpl membershjk2020-02-071-27/+43
| | | | | Change-Id: I7f815c53bac8621b2198c57d7f1d7d4bd43eb282 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Move responsibility to set editor parameters to editor factoryhjk2020-02-063-5/+5
| | | | | | | | | | | | So it doesn't need to be named twice in the editor factory setup. This intentially includes a de-optimiztion: storing the parameters by value, not by pointer. That's more natural, does not need to keep the parameters alive on the caller side, and it's uncritical in this context. Change-Id: I92867d3f2f75c38911ae82d3eeb4759cba71b723 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VcsBase: More use of settings instead of client when it sufficeshjk2020-02-041-1/+1
| | | | | | | | Client::vcsBinary() maps directly to Settings::binaryPath() except for git can be replaced by that in non-generic settings. Change-Id: I245659d3c423361e87c92e8995fa3476d798cc7b Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Remove some unneded indirectionshjk2020-01-311-7/+6
| | | | | Change-Id: Ie9d976c06ff424fb106cb344bedb789c9b99e657 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Merge IVersionControl and VcsBasePlugin hierarchieshjk2020-01-317-261/+155
| | | | | | | | | | | | | | They were 1:1 in parallel, with quite a bit of function call ping-pong inbetween, for code-sharing-by-inheritance. Merge them by making VcsBasePlugin inherit IVersionControl and merge the derived classes below. Size of this patch is hard to avoid as all seven systems have to move simultaneously. Non-necessary potential follow-up cleanup have been left out on purpose. Change-Id: Icb71e4182af3db21069cc637e7ae87ffa3829791 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Bazaar: Remove some dead codehjk2020-01-292-11/+0
| | | | | Change-Id: I0598ff3b867246fd73bbb5d118ce85d70d4762fc Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Bazaar: Move plugin pimpl into .cpphjk2020-01-299-303/+169
| | | | | Change-Id: If355d4dc34febcda7da24d85370f3ab607f5cd82 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Drop VcsBaseOptionsPage hierarchy levelhjk2020-01-271-1/+3
| | | | | | | Adapt the remaining users: Cvs,Git,Svn. Change-Id: Idd730a33e5c64d18002b1a21b5f5c715b7fa5ffb Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Bazaar: Remove direct accesses to singletonshjk2020-01-246-40/+33
| | | | | Change-Id: Ie736597dcc17256fc1ef912689ef86e706acbd99 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Move settings ownership from VcsBaseClientImpl to pluginhjk2020-01-243-7/+7
| | | | | | | Turns out CVS and Bazaar already had an unused copy there... Change-Id: I512c4d6322620e2b55d9008600ac676ce09032aa Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Pimpl pluginshjk2020-01-244-75/+92
| | | | | | | | | | | | | | | Essentially rename all *Plugin into *PluginPrivate, and pull out the actual IPlugin related pieces into new *Plugin classes. Shift the construction of the PluginPrivate to initialize(), following the general pattern. I tried to keep the patch as mechanical as possible, giving room to some obvious but less mechanical cleanup needs, that are intentionally left out of this here. Change-Id: Iac662bf73338f9f7669064ed67b960246875c23c Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Move static functions out of VcsPlugin "namespace"hjk2020-01-231-4/+2
| | | | | | | | | | | | Plan is to split VcsPlugin in the pure IPlugin and a new class the remaining non-IPlugin bits of VcsPlugin, call it VcsPluginPrivate and use that d-ptr for VcsPlugin. VcsPlugin-derived classes can then use VcsPluginPrivate derived private, later pointer members of the *Privates can be made proper members, moving towards the otherwise predominant plugin setup pattern. Change-Id: I62db9269e8ca50633c24b6d1d735d59c8fa8e5a5 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Dissolve VcsManager::registerVersionControlhjk2020-01-221-1/+3
| | | | | | | | It's a somewhat unusual pattern, spelling it out will help to move the vcs plugins setup closer to the now-usual pattern. Change-Id: Ie7b70e52d75e34cd36b6a1d55ca868e3edab44a7 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Bazaar: Add Optionspage category information againhjk2020-01-161-0/+1
| | | | | | | Amends 4f5287d30fa5bec2f52514f6ba5405ed855d28ec. Change-Id: I6c119bffcfd4891a5a2710c08f17d1b5ca0179b3 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Bazaar: Remove VcsClientOptionsPage level in settings class hierarchyhjk2020-01-162-18/+22
| | | | | | | | ... by inlining the code from the intermediate layer. The base IOptionsPage infrastructure is now good enough. Change-Id: I9999c02c290c4ad024b7c8c5480d3db579b7f454 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Move Settings widget definitions to .cpp fileshjk2020-01-152-28/+24
| | | | | | | | In preparation of replacing the VcsBase* layer by the new IOption* functions, which are almost the same now. Change-Id: I39f7da137434ed33d2d42f09f4213e74b3e29f7e Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Base VcsClientOptionsPageWidget on Core::IOptionsPageWidgethjk2020-01-152-2/+2
| | | | | | | | In preparation of the using the new ICore::IOptionsPage convenience functions. Change-Id: Iafe61e287987b3b75758f81bfce7adcdc1d50b64 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: Add a FilePath::isDir() convenience functionhjk2019-09-111-1/+1
| | | | | Change-Id: I1df0ee1b136299ae6e4f2e5bd0bdc24bfeca33dd Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Avoid warning on empty expressionshjk2019-07-231-2/+2
| | | | | | | | For some reason, Q_UNUSED includes already a semicolon, adding one on the user side creates an additional empty statement. Change-Id: I9c5e8fac381345a60792cb75e2938fd53958d3b0 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Use CommandLine in ShellCommandhjk2019-06-111-1/+1
| | | | | | | ... and adapt users. Change-Id: I218523ffe34720d5fe199aa0ca6892a8dc2985fc Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: Rename FileName to FilePathhjk2019-05-284-7/+7
| | | | | | | | More in line with QFileInfo terminonlogy which appears to be best-of-breed within Qt. Change-Id: I1d051ff1c8363ebd4ee56376451df45216c4c9ab Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-21 12:57:01 +0000