aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/clearcase
Commit message (Collapse)AuthorAgeFilesLines
* EditorManager: Small API clean-upEike Ziller2020-09-301-2/+2
| | | | | | | | | - Move private enum to private header - Add missing parameter to openEditorAtSearchResult - Remove convenience singular close* methods, we have {} nowadays Change-Id: Ic5b6d831a9f506ffee09b89b3358874433d62998 Reviewed-by: David Schulz <david.schulz@qt.io>
* VCS: Fix build with Qt6Eike Ziller2020-09-212-2/+2
| | | | | | | | | QStringRef is gone. Task-number: QTCREATORBUG-24098 Change-Id: I38dd1602294fcabf5cf7c1553bcfd93f3c47b601 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: Drop Utils::SkipEmptyParts againhjk2020-07-211-5/+5
| | | | | | | | We require Qt 5.14 nowadays. Change-Id: Iff245257d3cb19207007c0445ee13814e66152dd Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Core/Utils: Migrate further to Utils::Idhjk2020-07-061-4/+4
| | | | | | | The coreplugin/id.h header is kept for downstream for now. Change-Id: I8c44590f7b988b3770ecdc177c40783e12353e66 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* ClearCase: Cleanup ClearCaseSyncOrgad Shaneh2020-06-241-28/+17
| | | | | | | | * Simplify regexp matching * Remove QLatin1String Change-Id: Id362c8dd0dfe70c96990bd98800e8c4fb886300f Reviewed-by: hjk <hjk@qt.io>
* ClearCase: Compile fix for Qt 5.15hjk2020-06-241-2/+7
| | | | | | | Amends 9efa934ae099585. Change-Id: I4ef9caf61f708f94ad2bda6ea826be4567238282 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* ClearCase: Drop QRegExp usehjk2020-06-243-28/+39
| | | | | Change-Id: Ia47d2efec42e9df59c5d30a695b4becee942e085 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Move InfoBar to UtilsEike Ziller2020-06-181-1/+1
| | | | | | | | | The only reason it was required to be in Core plugin, was its use of Id, which now is available in Utils. Change-Id: I66ce863c24924e6448d339b3422538a7fe167336 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* VCS: Add vcsDescribeOrgad Shaneh2020-06-181-5/+5
| | | | | | | Already exists in all implementations, but there was no common declaration. Change-Id: Ieb3d10d1936c207722b5001712bce41e8114dcdc Reviewed-by: André Hartmann <aha_1980@gmx.de>
* IVersionControl: Change vcsAnnotate return type to voidOrgad Shaneh2020-06-181-3/+2
| | | | | | | | | | | All implementations return true unconditionally, and the return value is never read anyway. + Remove superfluous function with the same name in Perforce. Change-Id: I83f361ec7fd8be3177cb4be52e6276e295cd4279 Reviewed-by: André Hartmann <aha_1980@gmx.de> Reviewed-by: hjk <hjk@qt.io>
* All: Use Utils::SkipEmptyPartshjk2020-06-171-10/+14
| | | | | | Task-number: QTCREATORBUG-24098 Change-Id: Iab45de9a9c17ddc39a0e343b1175d4f6cb94b098 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Fix lupdate issuesEike Ziller2020-03-181-1/+1
| | | | | Change-Id: I26f08ae82354c178f6d26f9138796328b50bfba8 Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* VCS: Replace QRegExp with QRegularExpression in VcsBaseEditorOrgad Shaneh2020-02-212-8/+7
| | | | | | Change-Id: I8e8a6649e441597e29e88506d494ec69260bebd1 Reviewed-by: Samuel Gaist <samuel.gaist@idiap.ch> Reviewed-by: André Hartmann <aha_1980@gmx.de>
* VCS: Refactor annotationChanges() in VcsBaseEditorOrgad Shaneh2020-02-202-19/+2
| | | | | | | Devirtualize the function, and use QRegularExpression with globalMatch. Change-Id: I18c92cb37b535c616f03f45dff8b18249c961d5d Reviewed-by: hjk <hjk@qt.io>
* Vcs: Make VcsBaseEditorWidget::test* operate on factories directlyhjk2020-02-131-2/+2
| | | | | | | Saves re-discovery by id. Change-Id: I026c1388d02f125147a9b4f5367d7a1a266bff3c Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Make some editor factories proper plugin pimpl membershjk2020-02-071-38/+42
| | | | | Change-Id: I7f815c53bac8621b2198c57d7f1d7d4bd43eb282 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* ClearCase: Make a some items proper data membershjk2020-02-073-23/+24
| | | | | Change-Id: I7d1c8490ca72c6ba0b16111d2191826583037c6e Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* ClearCase: Partially move plugin pimpl to .cpphjk2020-02-077-273/+310
| | | | | | | | | Unfortuately, some deep accesses are not easy to get rid of. Make them available by static functions in the plugin itself. Definitely not the favorite setup, but allows to proceed with the QObject removals. Change-Id: Idc1624d2a4751b15159c3e36dcf8d2d476550167 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Separate plugin and QObject parent roles for VcsSubmitEditorFactoryhjk2020-02-061-1/+1
| | | | | | | | These are different when the factories are used as real members, as already done in Bazaar. Change-Id: I3c187896dcbacb5156be1543424ccacb9140a493 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Move responsibility to set editor parameters to editor factoryhjk2020-02-063-5/+4
| | | | | | | | | | | | So it doesn't need to be named twice in the editor factory setup. This intentially includes a de-optimiztion: storing the parameters by value, not by pointer. That's more natural, does not need to keep the parameters alive on the caller side, and it's uncritical in this context. Change-Id: I92867d3f2f75c38911ae82d3eeb4759cba71b723 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Merge IVersionControl and VcsBasePlugin hierarchieshjk2020-01-317-311/+173
| | | | | | | | | | | | | | They were 1:1 in parallel, with quite a bit of function call ping-pong inbetween, for code-sharing-by-inheritance. Merge them by making VcsBasePlugin inherit IVersionControl and merge the derived classes below. Size of this patch is hard to avoid as all seven systems have to move simultaneously. Non-necessary potential follow-up cleanup have been left out on purpose. Change-Id: Icb71e4182af3db21069cc637e7ae87ffa3829791 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Pimpl pluginshjk2020-01-249-213/+229
| | | | | | | | | | | | | | | Essentially rename all *Plugin into *PluginPrivate, and pull out the actual IPlugin related pieces into new *Plugin classes. Shift the construction of the PluginPrivate to initialize(), following the general pattern. I tried to keep the patch as mechanical as possible, giving room to some obvious but less mechanical cleanup needs, that are intentionally left out of this here. Change-Id: Iac662bf73338f9f7669064ed67b960246875c23c Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Move static functions out of VcsPlugin "namespace"hjk2020-01-231-1/+1
| | | | | | | | | | | | Plan is to split VcsPlugin in the pure IPlugin and a new class the remaining non-IPlugin bits of VcsPlugin, call it VcsPluginPrivate and use that d-ptr for VcsPlugin. VcsPlugin-derived classes can then use VcsPluginPrivate derived private, later pointer members of the *Privates can be made proper members, moving towards the otherwise predominant plugin setup pattern. Change-Id: I62db9269e8ca50633c24b6d1d735d59c8fa8e5a5 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Vcs: Dissolve VcsManager::registerVersionControlhjk2020-01-221-1/+2
| | | | | | | | It's a somewhat unusual pattern, spelling it out will help to move the vcs plugins setup closer to the now-usual pattern. Change-Id: Ie7b70e52d75e34cd36b6a1d55ca868e3edab44a7 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Core/Utils: Use {} instead of nullptr for flagshjk2020-01-171-1/+1
| | | | | | | Deprecated in current 5.15 Change-Id: I4222c67f2da3919e3476178f52dae909327431d4 Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Vcs: Dissolve VcsBaseOptionsPage intermediate hierarchy levelhjk2020-01-172-3/+6
| | | | | | | | It's effectively setting only three properties nowadays, not enough to justify a case of reuse-by-inheritance anymore. Change-Id: Ia0aedbd0dc460a70bed580a3402cf928c7221a77 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Core: Provide empty implementation for IOptionPageWidget::finish()hjk2020-01-151-1/+0
| | | | | | | | Having it pure virtual only lead to a lot of unnecessary re-implementation. Change-Id: I37f71d1a160e21b93c7c73a6304b0eb6d5f0441d Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* ClearCase: Use new IOptionPage convenience functionshjk2020-01-143-75/+51
| | | | | Change-Id: Ie239a972de57f8f145fc3343f7cabac86917760e Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: Add CommandLine convenience constructorshjk2019-07-231-2/+2
| | | | | | | | | | | | | ... taking a QString for the executable. This weakens the very explicit QString -> FileName conversion via the named constructors for the special case of constructing a CommandLine. I think that's worthwhile here, as it reduces the noise on the caller site under circumstance where the nature of the thing is obvious. Change-Id: I27b4a73639728893d053b2e7ba65cb745f0ffe83 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Avoid warning on empty expressionshjk2019-07-231-1/+1
| | | | | | | | For some reason, Q_UNUSED includes already a semicolon, adding one on the user side creates an additional empty statement. Change-Id: I9c5e8fac381345a60792cb75e2938fd53958d3b0 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Use CommandLine in ShellCommandhjk2019-06-111-2/+3
| | | | | | | ... and adapt users. Change-Id: I218523ffe34720d5fe199aa0ca6892a8dc2985fc Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Use Utils::FilePath in SynchronousProcesshjk2019-06-111-4/+4
| | | | | | | Adapt callers and surrounding code. Change-Id: Ie6c1883a44169cf9d790d06b660f46d24dc24c89 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Rename FileName to FilePathhjk2019-05-283-6/+6
| | | | | | | | More in line with QFileInfo terminonlogy which appears to be best-of-breed within Qt. Change-Id: I1d051ff1c8363ebd4ee56376451df45216c4c9ab Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Translations: Do not translate *.mimetypes.xml filesTobias Hunger2019-05-231-7/+0
| | | | | | | There are no such files anymore. Change-Id: I9e5a744f3cb5d5bc8000fc5c8da202302fff50d8 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Qt Creator CMake portCristian Adam2019-05-171-0/+18
| | | | | | | | | | | | | | Based on Tobias Hunger's work from a few months ago. The CMake configuration needs libclang and Qt paths specified as CMAKE_PREFIX_PATH. Auto tests are run with "ctest". At the moment the pass rate is 87%. Change-Id: Iba98e39bf22077d52706dce6c85986be67a6eab0 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> Reviewed-by: Tobias Hunger <tobias.hunger@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Replace static_casts by QOverload where possiblehjk2019-02-261-3/+3
| | | | | | | | | Mainly to get rid of the QProcess::finished deprecation warning. Also adjust coding style in the surrounding connects when needed. Change-Id: I12f9b248c7974b892c4a069356e578e80f8c59e9 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-11-191-1/+1
|\ | | | | | | | | | | | | Conflicts: src/plugins/winrt/winrtdevicefactory.cpp Change-Id: I33b8697e2ebf2bea051d7f1144449e0743ee16a5
| * Remove unneeded member initializersOrgad Shaneh2018-11-121-1/+1
| | | | | | | | | | Change-Id: Ie68b15079d93c48c5027871743c88d9e051e3fbe Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* | VCS: Improve dialog on submit promptOrgad Shaneh2018-11-121-4/+1
| | | | | | | | | | | | | | | | | | | | | | The dialog appears when closing the commit dialog without committing, or when "prompt to submit" setting is enabled. Fixes: QTCREATORBUG-18799 Change-Id: I8eb20becbcee7281b9f673a35ec698c6f8e04a40 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Robert Loehning <robert.loehning@qt.io> Reviewed-by: André Hartmann <aha_1980@gmx.de>
* | ClearCase: ModernizeAlessandro Portale2018-11-056-8/+9
|/ | | | | | | | modernize-use-using Turn a parameter of ClearCaseSync::updateTotalFilesCount into a &. Change-Id: I1ee95b64374c77abb228e586544c8675ec74433a Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Merge remote-tracking branch 'origin/master' into 4.8Eike Ziller2018-09-251-3/+6
|\ | | | | | | Change-Id: Ic7fc44a9533d5d5abd384ff1185ec10811912314
| * ClearCase: Pass dialogParent where neededOrgad Shaneh2018-09-221-3/+6
| | | | | | | | | | Change-Id: I5f2de5191472fc0414fc5aa7074ad5e8e8251db1 Reviewed-by: André Hartmann <aha_1980@gmx.de>
* | ExtensionSystem: Relax platform regexp matchingOrgad Shaneh2018-09-251-1/+1
|/ | | | | | | | Match anywhere, not only exact matches. Change-Id: I3f530e9ee796250252108f835f7435c57f8d516b Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* ClearCase: ModernizeOrgad Shaneh2018-09-204-27/+28
| | | | | | | override, auto, nullptr Change-Id: I07ba03d44e2560797cc496acc96b57b41703320c Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* VCS: Consolidate submit editor actions setupOrgad Shaneh2018-08-283-26/+2
| | | | | Change-Id: I36754779b6a9aa35de705b368daf8c2a1de058c6 Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* VCS: Capitalize commitDisplayNameOrgad Shaneh2018-08-281-1/+1
| | | | | | | | To be used by the submit editor. Change-Id: I73fc13abfd37f207d92669c1893b7edda35ed1e4 Reviewed-by: André Hartmann <aha_1980@gmx.de> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* VCS: Unify default and maximum timeout in all setting pagesOrgad Shaneh2018-06-191-0/+3
| | | | | | | Task-number: QTCREATORBUG-16009 Change-Id: Ibbaaef441ac2dc0147af2bc0631e0b0d98b4f57d Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: André Hartmann <aha_1980@gmx.de>
* Vcs/Text search: Remove a few addAutoReleaseObject useshjk2018-02-063-8/+8
| | | | | | | Using a QObject parent suffices here. Change-Id: I4dc5448511d55bf14fbd8f810e91336a49e94094 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Core: make useMacShortcut constexprDavid Schulz2018-02-021-9/+9
| | | | | Change-Id: I293b96428784b6efecac6dae4f2f9690af0027da Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Move HTML out of translated stringsRobert Loehning2018-01-241-3/+4
| | | | | | | | Change-Id: I4664427086619f33e9a882eb3f0a5f2f52e1b42a Reviewed-by: Jochen Becher <jochen_becher@gmx.de> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-21 22:49:08 +0000