aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/debugger/breakhandler.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Fix clang 10 warnings about unnecessary copies in range loopsChristian Kandeler2020-05-121-1/+1
| | | | | Change-Id: I3b57869b5a04528518bc432b76768b01e3f53e81 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Start breakpoint manipulation syncronouslyhjk2020-05-071-3/+3
| | | | | | | | | | | | The original reason for this was gdb's inability to set certain break point properties in one go (commands and so parts of the setup are async anyway, and using only async paths made the overall setup simpler. The need to tweak some properties asyncronously still remains, but for the caller side it's better when at least the initial round is synchronous. Change-Id: Ibe542533a6026c7f0f4e49f4244b7e9d2aea7062 Reviewed-by: David Schulz <david.schulz@qt.io>
* Debugger: Handle failed breakpoints as unclaimedhjk2020-04-241-0/+5
| | | | | | Change-Id: I02a44db5391b174e75fc326ce217b271ee73c464 Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Some FileName cosmeticshjk2020-04-141-1/+1
| | | | | | | Use {from,to}Variant for settings, and one time fromUserInput is enough. Change-Id: I5774f425a4c775b0d78b87c60eabf7f48d78a082 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Replace FileChooser::path() by filePath().toString()hjk2020-04-091-1/+1
| | | | | | | | | | | Keep the old method for now to ease downstream porting. The change is kept mechanical, there's a lot of cleanup possible now on the user code side. Change-Id: I936baedd45b7ba057f1c789a1bec896886f48eff Reviewed-by: André Hartmann <aha_1980@gmx.de> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: Rename PathChooser::{f,setF}ileName() to {f,setF}ilePath()hjk2020-04-091-1/+1
| | | | | | | | | | It's returning a FilePath, so it's a better fit. Keep the old versions as inline function now to ease downstream migration. Change-Id: I535887928018f42b92895c8b0c82527f0d55e5ca Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: André Hartmann <aha_1980@gmx.de>
* Merge remote-tracking branch 'origin/4.12'Eike Ziller2020-03-201-3/+3
|\ | | | | | | Change-Id: Ia8254720b2ba6e3e7b859017e1c2b6e289bed771
| * Debugger: Fix some breakpoint file name display breakagehjk2020-03-191-3/+3
| | | | | | | | | | | | | | | | | | | | For unclaimed breakpoints the wodking directory was shown as path. Amends commit a7dd0e50a28595eb976d77b1b23b8120b0a9395a. Change-Id: I9614b3672d32fb18e35dc98c12a60e3b27eebf84 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Add some additional shortcuts for actionsEike Ziller2020-03-171-2/+2
|/ | | | | | | | | | | | | | | | | Add Cmd+Shift+- for decreasing font size on macOS. Do not add Cmd+= for increasing size, because it conflicts with the existing shortcut for "Replace and Find Next". Sprinkle some Backspace shortcuts in addition to Delete for removing items. There are (laptop) keyboards that either do not have a designated Delete key (requiring Fn+Backspace) or where the Delete key is not conveniently located/sized, and there is no benefit in making the distinction in that case anyhow. Fixes: QTCREATORBUG-706 Fixes: QTCREATORBUG-13733 Change-Id: I06274a9810b82800ec6158a883c95d2a7ae2465e Reviewed-by: David Schulz <david.schulz@qt.io>
* Globally disable WindowContextHelpButtonHintKai Koehne2020-02-251-1/+0
| | | | | | | | | | | Do set the global application flag AA_DisableWindowContextHelpButton to avoid having to unset the default WindowContextHelpButtonHint in every single dialog. AA_DisableWindowContextHelpButton was added in Qt 5.10. Change-Id: I21fe8bc5ddfa4c01ec7a799b04bfb6ff1c9d6d86 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Debugger: Do not highlight global breakpoints in scrollbarDavid Schulz2020-01-091-1/+0
| | | | | | | | | | The color red is perceived as an error indicator. So only highlight breakpoints if they have been assigned to an engine to reduce the visual distraction. Fixes: QTCREATORBUG-23433 Change-Id: I852d94a7637c958c65c94acacc8233b6553bb612 Reviewed-by: hjk <hjk@qt.io>
* Debugger: make BreakpointParameters::fileName a Utils::FilePathDavid Schulz2020-01-061-67/+46
| | | | | | Task-number: QTCREATORBUG-23339 Change-Id: Ifc497c14589cd6df10d8219533e100f1919213b3 Reviewed-by: hjk <hjk@qt.io>
* Debugger: Add ability to hide view columnshjk2019-12-131-4/+2
| | | | | | | | | | | Not perfect, e.g. one would probably expect the items to appear in the context menu of the header views, too, not just on the main background of the view, but better than nothing. Task-number: QTCREATORBUG-23342 Change-Id: Ifdc44dcfd390112faa7b15bb8a51d809e42d7b29 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Delete breakpoint markers on session switchhjk2019-11-281-9/+4
| | | | | | | | | | | | | | There were some left-over "ghost markers" when switching sessions, which should be gone now. This also pointed to a wrong use of SessionManager::aboutToUnloadSession which mustn't save data re-created in a save/load cycle as it is called during any session load, including the very first on startup no such data (e.g. breakpoints) have been created yet. Change-Id: I237a9e3500a786841618941ce85a97f7bd4f318c Fixes: QTCREATORBUG-22856 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Fix conditional operator with identical true and false expressionshjk2019-11-011-9/+8
| | | | | Change-Id: I1f85eed5355cd01590bc8cc0082f154e215a9ac3 Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* Merge remote-tracking branch 'origin/4.10' into 4.11Eike Ziller2019-10-281-15/+28
|\ | | | | | | | | | | | | | | Conflicts: src/libs/utils/fancymainwindow.cpp src/plugins/projectexplorer/msvctoolchain.cpp Change-Id: I7aaeeb4f96c95fefd4944c083c1ddf9a19cd81d6
| * Debugger: Avoid recreation of breakpoint markersDavid Schulz2019-10-181-5/+13
| | | | | | | | | | Change-Id: Ie3b160a7b7137257b2028d03878700675142102f Reviewed-by: hjk <hjk@qt.io>
| * Debugger: further untangle of breakpoint item and markerDavid Schulz2019-10-171-6/+15
| | | | | | | | | | Change-Id: I9331912c1b53a0110479f46ef1e576676441ab75 Reviewed-by: hjk <hjk@qt.io>
| * Debugger: Fix crash after breakpoint marker drag&dropDavid Schulz2019-10-171-7/+3
| | | | | | | | | | | | | | | | | | The updateMarker function deletes the marker of the global breakpoint so don't call that function from the marker. Fixes: QTCREATORBUG-23107 Change-Id: I377608f1a08b61451be1fc0be5bc15252252a4a7 Reviewed-by: hjk <hjk@qt.io>
* | Debugger: Introduce a checkboxhjk2019-10-161-0/+8
|/ | | | | | | | | | | | | | ... to propagate breakpoint changes from a running debugger back to the original preset breakpoint. This is currently unused as some changes are already propagated, and some not, so a bit more diligence is needed. For now it is there to have the new label string in safely before string freeze. Change-Id: I8ee4d07bab5a4f66e59bf992ebfd81c56fdb3ecf Reviewed-by: David Schulz <david.schulz@qt.io>
* Debugger: Update breakpoint marker earlierChristian Stenger2019-08-121-1/+1
| | | | | | | | | | | | Since the distinction between global and engine breakpoints we may not update the breakpoint marker correctly which in turn appears as if the breakpoint had been failed to set. Fix this by updating the breakpoint marker already on insertion request. Change-Id: I7c4ed046c26667e6aa1efceb5071c12a6d1e6132 Reviewed-by: hjk <hjk@qt.io>
* Remove more deprecation warningshjk2019-07-051-2/+2
| | | | | Change-Id: Ie50e41737a4bf7bea41f550df7cc765267e8a144 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* More Utils::toSet/toListhjk2019-07-041-1/+1
| | | | | | | ... and unrelated cosmetic changes. Change-Id: I591b17fd5289831e701b683f8fb47816efd1fa67 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* connect() to ambiguous signals/slots: Replace static_cast with QOverloadAlessandro Portale2019-05-281-1/+1
| | | | | Change-Id: I473d7a2a16509cee944a2a21b022a3f6f02cfd8d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Utils: Rename FileName to FilePathhjk2019-05-281-6/+6
| | | | | | | | More in line with QFileInfo terminonlogy which appears to be best-of-breed within Qt. Change-Id: I1d051ff1c8363ebd4ee56376451df45216c4c9ab Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Debugger: Coordinate breakpoint rampdownhjk2019-04-111-3/+7
| | | | | | | | | | The update of the global came too early to properly check the condition whether it is still used. So fully remove usage first, then update, so the check operates on intended data. Fixes: QTCREATORBUG-22284 Change-Id: Iecdbdc371396132c88d0918f7cb253cf2627e0e3 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* TreeView: Fix mapping to source models in case ProxyModels are involvedhjk2019-04-021-3/+3
| | | | | | | Visible e.g. in context menu handling of the debugger's module view. Change-Id: I342ed262c9e3dcdf98590003a7930cb8ef4ca0d2 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Merge remote-tracking branch 'origin/4.8'Eike Ziller2019-01-071-0/+4
|\ | | | | | | | | | | | | Conflicts: src/plugins/coreplugin/dialogs/externaltoolconfig.ui Change-Id: Ie38e9028cee599578c59b22325d85c097335243e
| * Debugger: Update global breakpoint line and filehjk2018-12-191-0/+4
| | | | | | | | | | | | | | | | ... when a breakpoint in an active engine is moved due to code edits. Change-Id: Iac8102b7ac0149342ccb3fd6be6bf16172683036 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* | Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-11-191-4/+5
|\| | | | | | | | | | | | | Conflicts: src/plugins/winrt/winrtdevicefactory.cpp Change-Id: I33b8697e2ebf2bea051d7f1144449e0743ee16a5
| * Debugger: Silence soft assertChristian Stenger2018-11-131-4/+5
| | | | | | | | | | | | | | | | | | Enabling or disabling a multiple break points that have different states will trigger the soft assert for all break points having the destination state already. Change-Id: I61d859c0af548cb1dd9070a28c9aacee241e075b Reviewed-by: hjk <hjk@qt.io>
* | Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-11-091-2/+3
|\| | | | | | | | | | | | | Conflicts: tests/unit/unittest/unittest.pro Change-Id: I4f0ab05f96ee60900a3a35fad4c7331238367593
| * Debugger: Silence breakpoint state transition warninghjk2018-11-071-2/+3
| | | | | | | | | | | | | | ... for "alien" breakpoint that legitimately jump from New to Inserted. Change-Id: Idb8b540a119f6dbd04d86b8ce3f15c2599d4b60c Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-11-061-16/+7
|\| | | | | | | | | | | | | | | | | | | | | | | Conflicts: src/plugins/debugger/debuggermainwindow.cpp src/plugins/qbsprojectmanager/qbsbuildstep.cpp src/plugins/winrt/winrtdevicefactory.cpp tests/unit/unittest/gtest-creator-printing.cpp tests/unit/unittest/gtest-creator-printing.h tests/unit/unittest/unittest.pro Change-Id: Ie9b80b87a8a4fa81baf72a2daa7919b21371c15e
| * Debugger: Implement disabling/enabling subbreakpoints with LLDBhjk2018-11-061-2/+0
| | | | | | | | | | Change-Id: Iaad8716b98d632e5a933b7f5b26549c7cb885ea7 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
| * Debugger: use requested file and line for pending breakpointshjk2018-11-051-14/+7
| | | | | | | | | | | | | | | | | | | | | | Otherwise markers will not be shown. This fixes the visual aspect of the referenced tasks. Choosing a specific engine if more than one is running is still not possible. Task-number: QTCREATORBUG-21361 Task-number: QTCREATORBUG-21330 Change-Id: I5e31adf43ca8a57add83166b307434122498f1e6 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-10-241-6/+0
|\| | | | | | | | | | | | | | | Conflicts: doc/src/editors/creator-only/creator-code-pasting.qdoc src/plugins/android/androidbuildapkwidget.cpp Change-Id: Iea8b7135643d14ffe49d10b14bedb8fa5ac48063
| * Debugger: Remove unused BreakHandler::setBreakpointEnabled()hjk2018-10-221-6/+0
| | | | | | | | | | Change-Id: Ie7ef810e72b3d02663b425c687407cdd2b0cea52 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-10-221-11/+10
|\| | | | | | | | | | | | | | | Conflicts: src/plugins/debugger/debuggeritem.cpp tests/unit/unittest/unittest.pro Change-Id: Id2e4e9c2bc87b2556d7c2845aea3fe2fa11b630b
| * Debugger: Remove wrong state transitionChristian Stenger2018-10-221-1/+0
| | | | | | | | | | Change-Id: Ie199370e6dc9e8c3efe293be76cb89feacb8d4c5 Reviewed-by: hjk <hjk@qt.io>
| * Debugger: Re-enable breakpoint state handling with keyboardChristian Stenger2018-10-161-10/+10
| | | | | | | | | | | | | | | | | | This patch re-enables disabling or enabling breakpoints using the respective keyboard shortcut. Had been disabled since d6911fd10c0d. Change-Id: Iea3ce679bafcc78910be07984fd03b4a6e66eb8b Reviewed-by: hjk <hjk@qt.io>
* | Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-10-161-8/+16
|\| | | | | | | Change-Id: I0ff6f659b7ccd4ff5a79e422a1d54488508fe05f
| * Debugger: Fix breakpoint disabling using context menuhjk2018-10-151-8/+16
| | | | | | | | | | Change-Id: I3fa5ef2dc123f5f7f8292147626453284c1afd76 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | Debugger: Strip QLatin1* where possibleOrgad Shaneh2018-10-131-2/+2
|/ | | | | Change-Id: Idcab23875b5dc2ecf55e3303f417b995e2252720 Reviewed-by: hjk <hjk@qt.io>
* Debugger: Rename snapshothandler.{cpp,h} to enginemanager.{cpp,h}hjk2018-09-281-2/+2
| | | | | | | That's what they are nowadays. Change-Id: I1bd6db18f2142ecf488eba51ca739675eac753c7 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Consolidate breakpoint searchhjk2018-09-041-24/+31
| | | | | | | | | | | | | We already have a concept of Context when action on editor events, use that directly when searching an (almost) matching breakpoint instead of translating it into breakpoint manager's interface language. This also centralizes the guesswork for non-exact matches in one place, making it easier to fix currently wrong matches later. Change-Id: I5579e7e01792d425cad4ccf1dbcbbd1bd56c84ec Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Fix insertion of backend generated breakpointshjk2018-08-291-0/+1
| | | | | Change-Id: Ifb46995a787c111620b5270b2b60e4e7f39eb552 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Identify a breakpoint's requested parameters with preset datahjk2018-08-291-33/+33
| | | | | | | | | | | | This removes the ability to have different enabled/disabled states for the same breakpoint in concurrently running engines, but make the behavior less surprising. At least currently people *do* expect breakpoint changes in a running engine to persist after the engine dies. Change-Id: I911594765b24f2ce58f6747ae5ecab3e608882b8 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Move session load/restore handlinghjk2018-08-291-4/+13
| | | | | | | | | ... to breakpoint and watchhandler. More modular this way. Change-Id: I4a45481fcc2bfde67b164bd7274fb7b2a12cb7ac Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Re-enable breakpoint enabling via gutter context menuhjk2018-08-241-2/+3
| | | | | | Task-number: QTCREATORBUG-20970 Change-Id: Ie8fc2af8e99e82018a9b4262fe6053cb714e7d60 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-18 16:30:10 +0000