aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/ios
Commit message (Collapse)AuthorAgeFilesLines
...
* iOS: Avoid use of RunControl::runConfiguration() in QmlProfiler supporthjk2019-09-031-8/+0
| | | | | Change-Id: Id296ddb364c7503506e32c01d594cdca15715859 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Remove usages of deprecated APIs of QLayoutSona Kurazyan2019-09-021-1/+1
| | | | | | | | | | Replaced: QLayout::setMargin() -> QLayout::setContentsMargins() QLayout::margin() -> QLayout::getContentsMargins() Task-number: QTBUG-76491 Change-Id: If28ef6910b3afe5d04e4746b74f9362a3e3b3c8e Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* iOS: Remove unused IosRunConfiguratoin::profilePath() declarationhjk2019-09-021-1/+0
| | | | | | | Probably unused since the invention of buildKey(). Change-Id: I1bddd5f790e6dfdd509fd47bc5f5209cbaac091c Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Ios: Silence warnings about unnecessary ';'Tobias Hunger2019-09-021-2/+4
| | | | | Change-Id: Ie77d1f49da7eaf970a508f316034741b5d7b94b7 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Ios: Fix spelling in idTobias Hunger2019-08-301-1/+1
| | | | | Change-Id: I96b4a19615560c5d22afca9f07ae715e7ff4e646 Reviewed-by: hjk <hjk@qt.io>
* iOS: Fix/add RunWorker idshjk2019-08-301-1/+5
| | | | | | | Easier to debug worker setup errors. Change-Id: I1d050c715488db2bcce323f4efcd9808d1770eaa Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* iOS: Avoid double-indirection between DeviceTypeAspect and run confighjk2019-08-301-2/+2
| | | | | | | No need to leave the aspect context. Change-Id: I96a93f7c85d8bbb1fdc28352a4c70a29bc510e4c Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* ProjectExplorer: Standardize RunWorker creation logichjk2019-08-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This unifies the remaining paths of RunWorker creation to always use RunWorkerFactories in the plugin pimpls. There were, and are, still effectively three basic kinds of workers: - "toplevel" tools corresponding to the run modes, that are often all that's used for local runs and directly started via the fat buttons or e.g. entries in the analyze menu, with factories already previously located in the plugin pimpls - core "tool helpers", providing tool specific functionality typically used in conjunction with a remote device specific run mechanism, set up via RunControl::registerWorkerCreator - target/device specific runhelper like port gatherers contructed e.g. via *Device::workerCreator(Core::Id id) Worse, these categories are partially overlapping, so it was not clear how a "clean" setup would look like, instead some ad-hoc cobbling "to make it work" happened. In some cases, the runMode id was used throughout the whole ensemble of run workers for a given run, and which worker exactly was created depended on which of the mechanism above was used in which order. With the new central setup, the top-level runmodes remain, but the second kind gets new ids, so the implicit dependencies on order of setup mechanism are avoided. This also helps in the cases where there was previously unclarity of where and how to set up worker factories: It's always and only the plugin pimpl now. Change-Id: Icd9a08e2d53e19abe8b21fe546f469fae353a69f Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Let PortsGatherer produce full URLs instead of ports onlyhjk2019-08-261-2/+5
| | | | | | | This is what the consuming code expects in most cases. Change-Id: I135592039e28b994996186f627215ab1d2f8d6dc Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* iOS: Put common IosDevice constructor code into a functionhjk2019-08-192-10/+12
| | | | | | | It is not even clear that the remaining difference are needed. Change-Id: Ic4418143242793d82a1f4c4c368af69a2e537078 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* ProjectExplorer: Base IDevice::osType on a data memberhjk2019-08-194-12/+3
| | | | | Change-Id: I969563e6e62895a51fb4692c8eb0bab278f0ecae Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* iOS: Remove unused qtsupport includeshjk2019-08-142-4/+0
| | | | | Change-Id: I0f5c867e712d152377d05c3e4105e7705e7a4547 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Drop connections to active target and build config changeshjk2019-08-132-19/+0
| | | | | | | | ... for build step related widgets. These are specifig to a build step which in turn is only interested in its own build config and target. Change-Id: I5ec277ba279932d18a615e528acffaccdc41e307 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Utils/all: Create an OutputFormatterFactoryhjk2019-08-131-3/+0
| | | | | | | | | | | Essentially following the scheme used for the various project configurations. This makes it possible to construct OutputFormatters by Id only, potentially reducing hard plugin dependencies and opening the road to have several output formatters per RunConfiguration/Outputpane/... Change-Id: I4b5fb6fb6be8b0d9a0859f178bb0effc3398b09e Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Merge remote-tracking branch 'origin/4.10'Eike Ziller2019-08-122-7/+18
|\ | | | | | | | | | | | | Conflicts: src/plugins/python/CMakeLists.txt Change-Id: I18808710dd99b97d4e1e7c3d223b7f814083de31
| * iOS: Share code for simulator display nameEike Ziller2019-08-121-3/+7
| | | | | | | | | | Change-Id: Iecfaa43aefc7ed783d4149dec008330ee5c124e9 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
| * iOS: Fix simulator listing with Xcode 11Eike Ziller2019-08-091-4/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Xcode 11 changes the output of simctl slightly. At some point it introduced a bool "isAvailable" in addition to the string "availability". Now the latter has been removed. To avoid listing all devices as available, we need to adapt our simctl output parsing. This already takes effect when installing Xcode 11 Beta, even when not actually using it, since all Xcode versions share the simulator infrastructure. Fixes: QTCREATORBUG-22757 Change-Id: I1ef416f6c544db53d9ee99ccc3b0a2e97dfcc870 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | ProjectExplorer: Re-work setup runworker factorieshjk2019-08-091-6/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This combines two of the previous three paths to create run workers, and refers to RunConfigurations by id, not by type where possible to decrease coupling between the classes. Only allow "type of run configuration" and "type of device" as the only possible kind of restriction and require a uniform RunWorker constructor signature. Adapt user code to fit that pattern. Change-Id: I5a6d49c9a144785fd0235d7586f244b56f67b366 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | ProjectExplorer: Replace Project::projectConfigurationChangedhjk2019-08-022-10/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... by a Project::buildConfigurationChanged. That's the only case used, and saves filtering on the receiver side. Also, the passed bc is (in non-null) the active one, so isActive checks are not necessary. The null case seems to be only possible to trigger when removing the currently active build configuration manually i.e. happens rarely, so having it trigger an unneeded final display update on the dying build config is tolerable, so drop the null check in such cases to achieve a more uniform pattern. Change-Id: I46f72e9e277767214dbd6920dd86b026a7084f46 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | ProjectExplorer::IDevice: Add a default display nameChristian Kandeler2019-08-022-3/+4
| | | | | | | | | | | | Task-number: QTCREATORBUG-16281 Change-Id: Ieff929343b5dc3a84d9ecf5f4f0a032cb4ae4076 Reviewed-by: hjk <hjk@qt.io>
* | Update build step widgets only on changes to the owning build confighjk2019-08-022-8/+6
| | | | | | | | | | | | | | | | Updating on changes to other build config seem excessive, as the updated details only depend the owning build config. Change-Id: Iba86f2b56033ac55381d452dd2a435e5dda72674 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | ProjectExplorer: Remove ProjectConfiguration base from Targethjk2019-07-312-0/+8
| | | | | | | | | | | | | | | | | | Targets are different from {Run,Build,Deployment}Configurations, both regarding the level in the ProjectExplorer hierarchy, and also by the set of supported operations (e.g. aspects). Change-Id: Ia8490e2280a9ecc518395c5e48ce2fd5d6d58fd2 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Compile fix with recent Qt devhjk2019-07-292-15/+7
| | | | | | | | | | | | | | | | | | The reasoning in 1b4766e26c6b did not take into account that the scope of QT_NO_JAVA_STYLE_ITERATORS may change over time, as done with f70905448f6 in Qt base. Change-Id: Ib1966ff26c4d36d5f62e149d6b45baa4aecf825d Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | Utils: Add CommandLine convenience constructorshjk2019-07-233-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | ... taking a QString for the executable. This weakens the very explicit QString -> FileName conversion via the named constructors for the special case of constructing a CommandLine. I think that's worthwhile here, as it reduces the noise on the caller site under circumstance where the nature of the thing is obvious. Change-Id: I27b4a73639728893d053b2e7ba65cb745f0ffe83 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Avoid warning on empty expressionshjk2019-07-235-18/+18
| | | | | | | | | | | | | | | | For some reason, Q_UNUSED includes already a semicolon, adding one on the user side creates an additional empty statement. Change-Id: I9c5e8fac381345a60792cb75e2938fd53958d3b0 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Merge remote-tracking branch 'origin/4.10'Tim Jenssen2019-07-042-5/+6
|\| | | | | | | | | | | | | | | | | | | | | | | Conflicts: qbs/modules/qtc/qtc.qbs qtcreator_ide_branding.pri src/libs/utils/synchronousprocess.cpp src/plugins/baremetal/iarewtoolchain.cpp src/plugins/cmakeprojectmanager/cmakeproject.cpp tests/unit/unittest/CMakeLists.txt Change-Id: I124ad492df403286751e175d27fe36487ddf6d07
| * More Utils::toSet/toListhjk2019-07-041-1/+2
| | | | | | | | | | | | | | ... and unrelated cosmetic changes. Change-Id: I591b17fd5289831e701b683f8fb47816efd1fa67 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
| * Use more toList/toSet to avoid deprecation warningshjk2019-07-031-4/+4
| | | | | | | | | | Change-Id: I43575a54ff944bf0e89d452d13944fcaee270208 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | iOS: Inline IosBuildStepConfigWidgethjk2019-06-266-171/+110
| | | | | | | | | | | | | | In preparation of aspectification. Change-Id: I0a97440aa6c4bc749af51219ccace519982bfaa1 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | ProjectExplorer: Prefer ProcessParameters::setCommandLinehjk2019-06-244-28/+30
| | | | | | | | | | | | | | ... over setting command and args individually. Change-Id: Iec7c8d3a0b05fb8fa0639f7ddbe7ccdc7387d2a2 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | ProjectExplorer: Use Utils::FileName for Runnable::executablehjk2019-06-211-2/+2
| | | | | | | | | | Change-Id: I584bc18aa19a4c9886af7b13e95052dfd4350b34 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | ProjectExplorer: Make Device::displayType a data memberhjk2019-06-194-20/+5
| | | | | | | | | | Change-Id: If650f660e3b10bc28d575ded07a854f59be26f87 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | iOS: Inline createIosToolChain()hjk2019-06-191-26/+10
| | | | | | | | | | | | | | | | Plan is to only let the (base) factory create toolchains, having the 'new' is a separate function complicates the process. Change-Id: I1faff3e2ce4a19a2947ba4ac4e156ed56e5d18e5 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | ProjectExplorer: Add a central ToolChainFactory::createToolChain(type)hjk2019-06-141-2/+2
| | | | | | | | | | | | | | | | | | This is meant to be the only function directly creating tool chain objects in the long run (and also the only one setting ids, removing the need to spell them out in the individual constructors). Change-Id: Idef242612a5a3f7012628b4080a03d6ee70e5ba0 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Use Utils::FilePath in SynchronousProcesshjk2019-06-113-10/+13
|/ | | | | | | Adapt callers and surrounding code. Change-Id: Ie6c1883a44169cf9d790d06b660f46d24dc24c89 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* connect() to ambiguous signals/slots: Replace static_cast with QOverloadAlessandro Portale2019-05-283-3/+3
| | | | | Change-Id: I473d7a2a16509cee944a2a21b022a3f6f02cfd8d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Utils: Rename FileName to FilePathhjk2019-05-2814-61/+61
| | | | | | | | More in line with QFileInfo terminonlogy which appears to be best-of-breed within Qt. Change-Id: I1d051ff1c8363ebd4ee56376451df45216c4c9ab Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* ProjectExplorer: Use an alias for QList<Abi>hjk2019-05-272-3/+3
| | | | | Change-Id: I69231c5974620ae30296bfc4e0ab41c900d95a3c Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* iOS: Use base IDevice::clone() instead of local toMap/fromMaphjk2019-05-271-8/+4
| | | | | | | Some non-persistent data is handled in the base. Change-Id: I5f6c5429b88178115bf26f885b80fa3daebf227e Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* CMake build/macOS: Centrally detect system librariesEike Ziller2019-05-241-3/+1
| | | | | | | | | And realize that at most places (except native help viewer) the code using them is not optional on macOS. Change-Id: I308406a0e8f176dad4151d23a33cd3fc0fb8635c Reviewed-by: Cristian Adam <cristian.adam@qt.io> Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* iOS: Remove remaining FileName::appendPath useshjk2019-05-241-12/+8
| | | | | Change-Id: Ia550151bbcad696a3bd59e630e80a8f89a908e08 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* CMake build: Add ability to disable building of individual pluginsEike Ziller2019-05-231-5/+6
| | | | | | | | | | | | | | Adds a cache entry "BUILD_PLUGIN_${NAME}", defaulting to ON which can be set to OFF to disable building of a plugin. Adds a extend_qtc_plugin function that should be used to add properties to a plugin after add_qtc_plugin, instead of the standard CMake functions target_... . The new function results in a no-op if the plugin was disabled. Change-Id: I57f6799620aea0aaa8b56acead4815ccced95911 Reviewed-by: Cristian Adam <cristian.adam@qt.io> Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Ios: Fix typo in device factory creationChristian Kandeler2019-05-211-1/+1
| | | | | | | | | Introduced in 0c2101d816, but only started to cause problems since 555360c1d4. Fixes: QTCREATORBUG-22449 Change-Id: Id531d7cb94c80b762f7981cf3414348080d0d613 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Qt Creator CMake portCristian Adam2019-05-171-0/+33
| | | | | | | | | | | | | | Based on Tobias Hunger's work from a few months ago. The CMake configuration needs libclang and Qt paths specified as CMAKE_PREFIX_PATH. Auto tests are run with "ctest". At the moment the pass rate is 87%. Change-Id: Iba98e39bf22077d52706dce6c85986be67a6eab0 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> Reviewed-by: Tobias Hunger <tobias.hunger@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* iOS: More FileName::appendPath -> pathAppended changeshjk2019-05-178-28/+21
| | | | | Change-Id: I3db6b1778e6e47e26e243fb2609c481651aa91fe Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* ProjectExplorer: Use Utils::FileName in ProcessParametershjk2019-05-152-8/+8
| | | | | | | For the command and the working directory. Change-Id: Ia69dc7100aeb57bb6e1b35f4dd4f3cf3763d8cda Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Utils: Replace FileName::FileName(QFileInfo) by a named constructorhjk2019-05-131-2/+2
| | | | | | | | | More consistent with the fromString case and avoiding false conversions QString -> QFileInfo -> FileName in case the inheritance of QString suddenly disappears. Change-Id: Ib14646ab1a660fd45dd1ea6862a0b5faa52ad0e3 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* ProjectExplorer: Drop Detection argument from ToolChain constructorhjk2019-05-101-1/+2
| | | | | | | | | | | | | This was used wildly inconsistently. Use a setter instead in circumstances where the context is reasonably clear. The assumption is that this will always be done at some time in all code paths. Use a new 'Uninitialized' value to avoid triggering the first update. Change-Id: I82c38cb9da3ccdbd8fbae8beefcbfa0e559ff794 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* ProjectExplorer: Use the fromMap(toMap()) pattern to clone deviceshjk2019-05-104-27/+5
| | | | | Change-Id: Ie6e73f5ef1019907dd311aac116d71f08b5a5202 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* ProjectExplorer: Replace ToolChainFactory::supportedLanguangehjk2019-05-092-6/+5
| | | | | | | ... by a member-based approach. Change-Id: I5c7fef196df6c37fd26c60a58c774426eca562a0 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-19 08:36:06 +0000