aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/valgrind
Commit message (Collapse)AuthorAgeFilesLines
* Fix lupdate issuesEike Ziller2019-06-271-18/+28
| | | | | | Change-Id: I0a7cc0650b6427d56b4415b2fff6cf39e29c96f9 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Valgrind: Handle CRLF appropriateChristian Stenger2019-06-131-1/+6
| | | | | | | | | | The valgrind parser might be used on Windows and if a device has Windows line endings it might end up with wrong data. Handle the additional line ending character if present. Change-Id: Ia86fa88f78b40e77e6236ed6769820e074a95db6 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Valgrind: Sanitize commandline parameter constructionhjk2019-06-051-9/+8
| | | | | Change-Id: I4d13e92c0e4a474e5edf67671ddc7f2e38c41028 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Valgrind: Shuffle codehjk2019-06-041-41/+41
| | | | | | | | The original idea was to make that use Utils::FilePath, but it looks like the code is not ready for that yet. Change-Id: Ib5466257049675fcbf19abd115ba58a78b45e484 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* connect() to ambiguous signals/slots: Replace static_cast with QOverloadAlessandro Portale2019-05-281-1/+1
| | | | | Change-Id: I473d7a2a16509cee944a2a21b022a3f6f02cfd8d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Utils: Rename FileName to FilePathhjk2019-05-286-8/+8
| | | | | | | | More in line with QFileInfo terminonlogy which appears to be best-of-breed within Qt. Change-Id: I1d051ff1c8363ebd4ee56376451df45216c4c9ab Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* ExtensionSystem: Move away from QListEike Ziller2019-05-272-3/+3
| | | | | | | | Qt 6 API will move away from it. Use QVector for API and some std container for internal things. Change-Id: Iff14d48a47d5ac52ade875d9c8c84ad8a4f577d8 Reviewed-by: hjk <hjk@qt.io>
* CMake build: Add ability to disable building of individual pluginsEike Ziller2019-05-231-9/+9
| | | | | | | | | | | | | | Adds a cache entry "BUILD_PLUGIN_${NAME}", defaulting to ON which can be set to OFF to disable building of a plugin. Adds a extend_qtc_plugin function that should be used to add properties to a plugin after add_qtc_plugin, instead of the standard CMake functions target_... . The new function results in a no-op if the plugin was disabled. Change-Id: I57f6799620aea0aaa8b56acead4815ccced95911 Reviewed-by: Cristian Adam <cristian.adam@qt.io> Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Qt Creator CMake portCristian Adam2019-05-171-0/+63
| | | | | | | | | | | | | | Based on Tobias Hunger's work from a few months ago. The CMake configuration needs libclang and Qt paths specified as CMAKE_PREFIX_PATH. Auto tests are run with "ctest". At the moment the pass rate is 87%. Change-Id: Iba98e39bf22077d52706dce6c85986be67a6eab0 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> Reviewed-by: Tobias Hunger <tobias.hunger@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Valgrind: Use external test data if availableChristian Stenger2019-05-101-13/+33
| | | | | | | | | | External data files will be tried to search inside a path that is specified by the environment variable QTC_TEST_EXTRADATALOCATION and need to be present inside a subdirectory called 'valgrind'. Change-Id: I8f192b2862e4c269ed17b7a81000eb3dabfc2efb Reviewed-by: hjk <hjk@qt.io>
* Fix build after 741950a3aadc199ca2f4491d66b04438001b6f59David Schulz2019-03-261-1/+1
| | | | | Change-Id: I0647c07161935a785ba15efd23a81f2f5bfb8b28 Reviewed-by: hjk <hjk@qt.io>
* Valgrind: Restructure plugin setuphjk2019-03-2510-261/+286
| | | | | | | | | Bring it more in line with the standard pattern. Plus some cosmetics. Change-Id: I2297c4e72892db386c50ece7dc64bdc89f0d9010 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* ProjectExplorer: Replace RunControl::producerhjk2019-03-202-4/+2
| | | | | | | | | | ... by two more specialized canRun() / createMainWorker() functions resulting in somewhat leaner code on the user side and paving the way for introducing a RunWorkerFactory class intended to follow the now-canonical way of having factories as members in the plugin pimpl. Change-Id: Id6fc2043a340203f14ab0b896a8dfa1e298f58a6 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Valgrind: Compile fix with Heobhjk2019-03-141-2/+3
| | | | | | Change-Id: I4d58280a13643f0afff5a9ed2b0aae7bc40e551b Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: hjk <hjk@qt.io>
* ProjectExplorer: Move RunControl related classes to separate file pairhjk2019-03-133-3/+3
| | | | | Change-Id: I5da56f80336673d595907abcc797f628be680cd5 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* ProjectExplorer: Add RunControl accessor to configuration settingshjk2019-03-132-4/+5
| | | | | Change-Id: I30e8f27d4090576d38fe8a778d7fa508ac26cbfa Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* ProjectExplorer: Split RunControl constructorhjk2019-03-122-2/+4
| | | | | | | | | | | Into a trivial bit and two setters. Plan is to use it only with information that is truly there (e.g. kit/device only) at the user side without having to invent a RunConfiguration "handle". Also remove some dead code in the test runner. Change-Id: I987881e41722178b14b91f973b84cbdb67a9f85e Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Avoid some visible uses of RunControl::runConfiguration()hjk2019-03-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For a long time, probably from the very beginning, a RunControl was meant to hold (a copy of) data needed for its operation, that was valid at the time of its construction, to be resilient in cases where RunConfiguration setting were changed while the RunControl was running, or to properly re-run with the original settings. Unfortunately, the task was repetitive, as RunConfiguration classes had no generic access to properties / "aspects" and there was was the runConfiguration() accessor (probably for mostly unrelated reasons in the output pane handling) which made the idea of just casting that to the original runConfiguration and access the data directly there appealing, with all the expected consequences. This patch here partially addresses the issue by copying some more of the related data at RunControl construction time and adjust the using code, avoiding most uses of the runConfiguration() accessor in a mostly mechanical matter. Complete removal appears possible, but will be less mechanical in "difficult" plugins like ios, so this is left for later. The new accessors in RunControl are very much ad-hoc, leaving room for improvement, e.g. by consolidating the access to the run config settings aspects with the other runconfig aspects or similar. For now the goal is to remove the runConfiguration() accessor, and to as much as possible fixed data after RunControl setup is finished. Next step would be to officially allow construction of RunControls without a specific RunConfiguration by setting the necessary data independently, removing the need for the various workarounds that are currently used for the purpose of faking (parts of) the effect of the non-existing RunConfiguration or refusing to operate at all, even if it would be possible. Change-Id: If8e5596da8422c70e90f97270389adbe6d0b46f2 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Squash more deprecation warningshjk2019-02-271-3/+3
| | | | | | | What a pain. Change-Id: I257e06c647933cc0b752c3c7a83a925b8b627e59 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Replace static_casts by QOverload where possiblehjk2019-02-263-9/+9
| | | | | | | | | Mainly to get rid of the QProcess::finished deprecation warning. Also adjust coding style in the surrounding connects when needed. Change-Id: I12f9b248c7974b892c4a069356e578e80f8c59e9 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Fix Qt 5.13 deprecation warning about QFontMetrics::width()Friedemann Kleint2019-02-152-2/+2
| | | | | | | | | Replace by QFontMetrics::horizontalAdvance(), fixing: warning: ‘int QFontMetrics::width(const QString&, int) const’ is deprecated: Use QFontMetrics::horizontalAdvance [-Wdeprecated-declarations] Change-Id: I9991ffefe6e87e872dc35ba291d562e06b28ca64 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* ProjectExplorer: Rename KitInformation to KitAspectChristian Kandeler2019-02-111-3/+3
| | | | | | | | | | | The name "KitInformation" does not properly convey the fact that it represents a certain *aspect* of a kit. The same goes for "KitConfigWidget", which in addition was inconsistent with "KitInformation". We now use "KitAspect" and "KitAspectWidget". Change-Id: I9804ee4cedc4d61fad533ea1dd4e4720e67fde97 Reviewed-by: hjk <hjk@qt.io>
* Fix some deprecation warnings in basic pluginsFriedemann Kleint2019-02-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Fix warnings apppearing in 5.13, for example: warning: ‘QDir& QDir::operator=(const QString&)’ is deprecated: Use QDir::setPath() instead [-Wdeprecated-declarations] ... warning: ‘static QRgb QColorDialog::getRgba(QRgb, bool*, QWidget*)’ is deprecated: Use getColor() [-Wdeprecated-declarations] warning: ‘Qt::DropAction QDrag::start(Qt::DropActions)’ is deprecated: Use QDrag::exec() instead [-Wdeprecated-declarations] warning: ‘void QProcess::finished(int)’ is deprecated: Use QProcess::finished(int, QProcess::ExitStatus) instead [-Wdeprecated-declarations] ... warning: ‘const QRect QDesktopWidget::availableGeometry(int) const’ is deprecated: Use QGuiApplication::screens() [-Wdeprecated-declarations] ... warning: ‘const QBrush& QPalette::background() const’ is deprecated: Use QPalette::window() instead [-Wdeprecated-declarations] ... warning: ‘const QBrush& QPalette::foreground() const’ is deprecated: Use QPalette::windowText() instead [-Wdeprecated-declarations] ... warning: ‘void QTextOption::setTabStop(qreal)’ is deprecated [-Wdeprecated-declarations] warning: ‘void QList<T>::swap(int, int) [with T = ProjectExplorer::BuildStep*]’ is deprecated: Use QList<T>::swapItemsAt() [-Wdeprecated-declarations] warning: ‘void QProcess::setReadChannelMode(QProcess::ProcessChannelMode)’ is deprecated: Use QProcess::setProcessChannelMode() instead [-Wdeprecated-declarations] ... warning: ‘QString QFileInfo::readLink() const’ is deprecated: Use QFileInfo::symLinkTarget() instead [-Wdeprecated-declarations] Change-Id: I1d893d42d372245892f2de8406f52dbe7bbd552a Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Don't detach temporariesAlessandro Portale2019-02-061-38/+38
| | | | | | | [-Wclazy-detaching-temporary] Change-Id: I278873fff8592249f0c4519a4e4a6faff2dff6e3 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Fix warning: "Don't call QVector::first() on temporary QList/QVector"Alessandro Portale2019-01-285-10/+11
| | | | | | | [-Wclazy-detaching-temporary] Change-Id: I23f5cbd80bb92d3f9f1bfb5ae07493818958c5b0 Reviewed-by: hjk <hjk@qt.io>
* fix compile after 0345bcb7ccb4d42bfa8544075c72d022a1ac8ffaDavid Schulz2019-01-251-1/+1
| | | | | Change-Id: Ib51fb7f8b4a2229609fd76d482a4afb753681883 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Fix warning: "Missing emit keyword on signal call"Alessandro Portale2019-01-174-6/+6
| | | | | | | [-Wclazy-incorrect-emit] Change-Id: I93bdc6e23cdaccf35c9899ae16870ccc65a54f80 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* Fix warning: "Don't call QList::last() on temporary"Alessandro Portale2019-01-171-1/+1
| | | | | | | [-Wclazy-detaching-temporary] Change-Id: I5e06e44fc45c80ea1dca518611d4f0c28a738061 Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
* Callgrind: Fix enabling of KCachegrind actionOrgad Shaneh2019-01-031-4/+2
| | | | | Change-Id: I355730ff4bcf6579028066a6f1080cfb790b523e Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* SSH: Use OpenSSH toolsChristian Kandeler2018-12-133-11/+10
| | | | | | | | | | | | | | | | | | | | | | | | ... instead of our own SSH library. Advantages: - Full compatibility with OpenSSH behavior guaranteed. - Minimal maintenance effort. - Less code to build. - Big chunk of 3rd party sources can be removed from our repository. One the downside, Windows users now need to install OpenSSH for RemoteLinux support. Hoewever, people doing embedded development probably have it installed anyway. [ChangeLog] Switched SSH backend to OpenSSH Fixes: QTCREATORBUG-15744 Fixes: QTCREATORBUG-15807 Fixes: QTCREATORBUG-19306 Fixes: QTCREATORBUG-20210 Change-Id: Ifcfefdd39401e45ba1f4aca35d2c5bf7046c7aab Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Valgrind: ModernizeAlessandro Portale2018-12-1053-294/+182
| | | | | | | modernize-* Change-Id: I6db60dce78cf2575e36caa597b1f095adba34fd9 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Valgrind: Fix compile with older QtChristian Stenger2018-12-031-61/+61
| | | | | | | Further amendment of 2c212d48a5a9cef63. Change-Id: I73eb8479d94512e0b824e2ca2284fe4da59d07ae Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Valgrind: Fix compilation with older Qt versionsOrgad Shaneh2018-12-031-2/+2
| | | | | | | Amends commit 2c212d48a5a9cef634807386bf7504f9cfbb36f5. Change-Id: I256c5e8ac38624c333ef344a9274a2b30266e06a Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Callgrind: Support opening last results in KCachegrindOrgad Shaneh2018-12-0311-17/+93
| | | | | Change-Id: Idb3b08ca6a1837f2456b73bcaf19aced5b83179f Reviewed-by: hjk <hjk@qt.io>
* Valgrind: Strip QLatin1*Orgad Shaneh2018-12-0321-316/+315
| | | | | Change-Id: If93ca890ab6d023ab786a5153f50a1dfa03764de Reviewed-by: hjk <hjk@qt.io>
* Merge remote-tracking branch 'origin/4.8'Eike Ziller2018-11-091-3/+3
|\ | | | | | | | | | | | | Conflicts: tests/unit/unittest/unittest.pro Change-Id: I4f0ab05f96ee60900a3a35fad4c7331238367593
| * Callgrind: Avoid an extra call to QDir::entryList()Orgad Shaneh2018-11-081-3/+3
| | | | | | | | | | Change-Id: I22220ccafe64b2eede3ac7d360b8fabe7ccc2b85 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Callgrind: Use member initializers and nullptrOrgad Shaneh2018-11-082-43/+21
|/ | | | | | Change-Id: I5e873e79a36a7bcd88260a3e42d3f66622f69cb4 Reviewed-by: André Hartmann <aha_1980@gmx.de> Reviewed-by: hjk <hjk@qt.io>
* Valgrind: Use multi-arg version of arg()Robert Loehning2018-10-231-2/+1
| | | | | Change-Id: I729641e829ccbd604ea8bb3e45a5425bb83e1a1b Reviewed-by: hjk <hjk@qt.io>
* ProjectExplorer: Rename 'extraAspect' to 'aspect'hjk2018-10-021-1/+1
| | | | | | | | | Using aspects is the standard pattern nowadays, there's nothing 'extra' to them anymore. Change-Id: I446f9d7b1db58a4899e5e44df33ce51f655e7be4 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Merge remote-tracking branch 'origin/4.7' into 4.8Eike Ziller2018-09-261-2/+3
|\ | | | | | | Change-Id: Iaae859601ae4f529c1fa7ada3a5c569820abb0d6
| * Valgrind: Add target executable suffix to heob command lineHannes Domani2018-09-251-2/+3
| | | | | | | | | | | | | | | | | | | | The suffix is needed in case the executable name contains a dot, because then the .exe suffix is not added automatically by CreateProcess(). Change-Id: Ief2cfeaa8dd8ebbfb71f69575ee9574a4f2156d3 Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | ProjectExplorer: Split IRunConfigurationAspecthjk2018-09-184-11/+9
| | | | | | | | | | | | | | | | | | ... into items that can be used generically in project configurations (ProjectConfigurationAspect) and items that have a choice between global and project settings (GlobalOrProjectAspect) Change-Id: I94831237bdbb18c339eb76eba131bf7f928933d6 Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* | ProjectExplorer: Update "generic" run configuration aspectshjk2018-09-131-1/+1
| | | | | | | | | | | | | | | | | | None of the run configuration aspects that are added to each runconfig depend on the actual runconfig, only two need the target, the rest nothing at all. So use target as common denominator. Change-Id: I31829e63ac79d5c707bb068d73fc6a4687cb4c47 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* | ProjectExplorer: Remove IRunConfigurationAspect::runConfigurationhjk2018-09-131-2/+1
| | | | | | | | | | | | | | | | ... and adapt constructors to not take the now-unneeded RunConfiguration pointer. Change-Id: I53ff338f51334ff7b0c22d4bed92bfcfc8225ea7 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* | ProjectExplorer: Remove RunConfigWidget wrapper classhjk2018-09-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Not really needed, a QWidget does the job, too, and de-emphasizes then 'Run' bit. The display name is now taken always from the aspect, but that's what was the practically the case before, albeit with different implementations. Change all names to *[cC]onfigWidget* (in line with ISettingsAspect). Change-Id: Ida0409a2dd0b175dd5ce4202f9b9e94b3f2db421 Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* | ProjectExplorer: Remove direct runconfig dependency from ISettingsAspecthjk2018-09-115-28/+14
| | | | | | | | | | Change-Id: I5d8a6a31f6bf97c34163b64b8d37f9ea070717ba Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* | Debugger: Shift some perspective related API to the perspective classhjk2018-08-232-17/+13
| | | | | | | | | | | | | | Also, use QString uniformly for the (now rarely used) perspective ids. Change-Id: I682062e7d179d0fcfd309e7714713bd1218bd8bb Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* | Shift perspective ownership to pluginshjk2018-08-212-31/+30
| | | | | | | | | | Change-Id: Id146ca771b4dc92f35cf156efbabae154f2d940f Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* | ProjectExplorer: Remove RunWorker::setDisplayNamehjk2018-08-212-2/+2
| | | | | | | | | | | | | | | | It has been an obsolete alias for setId for a while and downstream uses have been adapted. Change-Id: I467370aa67054599c7771e8275d28e62ddc461fa Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-18 18:21:33 +0000