aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/valgrind
Commit message (Collapse)AuthorAgeFilesLines
* Merge remote-tracking branch 'origin/6.0'Eike Ziller2021-11-151-12/+19
|\ | | | | | | | | | | | | | | | | Conflicts: cmake/QtCreatorIDEBranding.cmake qbs/modules/qtc/qtc.qbs qtcreator_ide_branding.pri Change-Id: I366a1a0e378811dfc9b4e6f42ec96426dbb15356
| * Fix a crash on shutdown inside CallgrindToolJarek Kobus2021-11-151-12/+19
| | | | | | | | | | | | | | | | This is a quick fix for 6.0 branch. Fixes: QTCREATORBUG-26563 Change-Id: Ida0f99a90c2e8515a2ea2b89de7a666f3067f908 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | Uniform ApplicationLauncher API: get rid of finished()Jarek Kobus2021-11-103-44/+1
| | | | | | | | | | | | | | Use existing processExited() signal instead. Change-Id: I1eecaa05fa8b3a97d8585fca4ca89e8e1acecec3 Reviewed-by: hjk <hjk@qt.io>
* | Uniform ApplicationLauncher API: get rid of remoteProcessStarted()Jarek Kobus2021-11-101-4/+10
| | | | | | | | | | | | | | | | Use existing processStarted() signal instead. Replace isRemoteRunning() with isLocal(). Change-Id: I58d0204888116c00e793fa43f969707013db06eb Reviewed-by: hjk <hjk@qt.io>
* | Uniform ApplicationLauncher API: get rid of remoteStderr/out()Jarek Kobus2021-11-091-25/+8
| | | | | | | | | | | | | | | | | | | | Use existing appendMessage() for this purpose either with StdErrFormat for remoteStderr() or with StdOutFormat for remoteStdout(). In case when device process is used in ApplicationLauncher no appendMessage() was emitted so far with StdErrFormat or StdOutFormat. Change-Id: I2f6603aaf28113fea2a8bb6bd1738320cc39be75 Reviewed-by: hjk <hjk@qt.io>
* | EditorManager: Remove QString openEditor(At) overloadsEike Ziller2021-11-021-2/+3
|/ | | | | | | | In favor of the FilePath/Link ones. Change-Id: I5caf9e0f8de304ff4ee12329557aa50a6f3a0c69 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: David Schulz <david.schulz@qt.io>
* Valgrind: Use FilePath for some suppression fileshjk2021-10-056-48/+48
| | | | | Change-Id: I48490a77d569d752ada1883554cf307148f2c0cb Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Valgrind: Use FilePath in HeobDialoghjk2021-10-051-3/+3
| | | | | | Change-Id: I1efa5442791f7655c4c887ea639a7a928d769a28 Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: Hannes Domani <ssbssa@yahoo.de>
* Valgrind: Simplify suppression file interfacehjk2021-09-273-88/+14
| | | | | | | | | | | | | | | | The global settings and per-project settings looked the same, but behaved quite differently: The per-project one were a kind of diff against the global one. Besides having "issues" when keeping the temporary and permanent places where relevant parts of the data were kept (settings, manual-applied global, auto-applied local settings), the concept was not clear in the UI at all. This here takes the simple way out: Either local, or global, no diffs. Change-Id: I90439cd20067ab60b88372f1cb03eeef8c2e42d3 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Valgrind: Bring back label for suppression files list in settingshjk2021-09-161-1/+1
| | | | | | | Also, top-align it again. Change-Id: I33ac6e44fd1d47c262e5473a17dea997fa5d1b71 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Valgrind: Fix parsing of remote pidJarek Kobus2021-09-151-9/+9
| | | | | | | | Before we have matched actually "grep valgrind" process pid and the intention was to match valgrind process pid itself. Change-Id: I87576aa6fcf4ac302feb28f046421f7c21c1bcb4 Reviewed-by: hjk <hjk@qt.io>
* Remove unused includes of QThread from cpp filesJarek Kobus2021-09-131-1/+0
| | | | | | Change-Id: I61b8e9182bf03fa96d2aabe399a6c93964fc8d03 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: hjk <hjk@qt.io>
* Utils: Start adding some asynchronous API to FilePathhjk2021-09-011-4/+5
| | | | | | | | | | | | | | | Especially with the "remote" scenarios synchronous operations cannot be expected to work reasonably well. This here starts with adding asynchronous versions to some of the FilePath member functions, taking additional "Continuation" style. This is not necessarily the final syntax (sugar like .then(...) comes to mind...), but is simple enough for now for the few uses we have, and it is too early to see what will be needed in the end. Change-Id: Idf4dde1b77d04cafb81b6c024031145bdd91a762 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Valgrind: Make callgrind work on dockerhjk2021-09-018-90/+71
| | | | | | | | | | | | | | | | Callgrind on Remote Linux did not work for years, so its safe to ignore the remains from the previous remote support and start over. This here now handles the local case and the case where callgrind runs together with the debuggee in the same docker container. Guessing at the output file name is replaced by specifiying it in advance. Cross-setups are not yet supported. Change-Id: I97edeb4eab7475727eddb26d25f8bec650a7eeb9 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Valgrind: Remove some unused QObject parenthjk2021-08-272-4/+3
| | | | | Change-Id: Ieef2c25d64b4a82743ce25da54c9d364548eb8d6 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Rename FilePath::normalizePathName to normalizedPathNamehjk2021-08-261-1/+1
| | | | | Change-Id: Ib7bcc9968749649f762a396d3861f7b67711e926 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Use QtcProcessArtem Sokolovskii2021-08-251-1/+1
| | | | | Change-Id: Ie41a40534f231c68797205e4dd817f5e98963b07 Reviewed-by: hjk <hjk@qt.io>
* Utils: Introduce FilePath::normalizePathName()hjk2021-08-231-1/+1
| | | | | | | | ... as wrapper around FileUtils::normalizePathName, and use it in some places. Change-Id: I42792e1f175b8119c8db930eae80a9f822ac70fa Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Valgrind: some more FilePath in heob codehjk2021-08-231-8/+11
| | | | | Change-Id: I53603b1a984bedd0a9d04aab9f6fbc38d9feee21 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Use more FileUtils based file dialogshjk2021-08-193-16/+16
| | | | | Change-Id: I1e7ec0493c26afe58e17afb8923a2b1023f6dcd4 Reviewed-by: David Schulz <david.schulz@qt.io>
* Utils: Introduce a FilePath constructor from char arrayshjk2021-08-173-4/+4
| | | | | | | | | | | | Similar to QT_RESTRICTED_CAST_FROM_ASCII to avoid the need for decorations in user code. At the same time, drop some convenience constructors and functions in CommandLine and Icon essentially serving the same purpose. Change-Id: Ida4e5ac19c2da0a4298a97b2a8e1511d56bbb79d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* ProjectExplorer: Use Utils::CommandLine in ProjectExplorer::Runnablehjk2021-08-137-17/+17
| | | | | | Change-Id: Id965f1f9047dcbc3ea5c9ddaa550d12668cf8ae6 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils/ProjectExplorer: Use FilePath for Runnable::workingDirectoryhjk2021-08-062-2/+2
| | | | | | | ... and in some using code. Change-Id: I231ea56628908f7d305d13f07eabe8803fe8a791 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* ProjectExplorer: Use FilePaths in project tree nodeshjk2021-07-161-1/+1
| | | | | Change-Id: I31b15c428d9b962333947b1e32641fd80f61d069 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Fix lupdate issuesEike Ziller2021-07-091-0/+2
| | | | | | | | | Some tr functions missing, some places where we need full qualification because lupdate gets confused with namespaces. Change-Id: Ic1d6ef3b31960dda02bc0788a255857117acdca9 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Debugger: filepathify DiagnosticLocationDavid Schulz2021-06-091-1/+3
| | | | | Change-Id: Ibbbf137231b313ec10e3d57c0230217b0c1e0a6c Reviewed-by: hjk <hjk@qt.io>
* Utils: filepathify fileutilsDavid Schulz2021-05-181-4/+4
| | | | | Change-Id: Ic9048369f64d793f5f567cdb0c715488fb5a4ff6 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Utils: Move process arguments class out of QtcProcesshjk2021-05-112-2/+2
| | | | | | | | | | | | The main QtcProcess interface is nowadays a CommandLine, with no explicit references left to QtcProcess::Arguments and related static helper functions, so it only clutters the QtcProcess class interface So move these items out of QtcProcess, later potentially to a separate file pair. Change-Id: I45c300b656f5b30e2e2717232c855fdd97c2d1d7 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Analyzer: Base ISettingsAspect on Utils::AspectContainerhjk2021-04-123-51/+38
| | | | | Change-Id: Ib4c19d0cb167911dc50d989771dd53f3569db087 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Avoid intermediate widgets when using LayoutBuilderhjk2021-03-162-10/+8
| | | | | | | | | | | | In most cases, the layout constructed in the builder was set on a widget which in turn was put into a vbox in the actual widget. This is not necessary, but needs some re-ordering. Also make sure that using not-yet-parented widgets during layout construction does not cause visible artifacts. Change-Id: I75727a571da093d3131ea6fba467c2c646cdb6f1 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Valgrind: Create a SuppressionsAspecthjk2021-03-125-252/+300
| | | | | | | | | | | | | | This is a fairly complex use case, as the corresponding widget looks the same in global settings and Project settings, but behaves differently (Project only stores a diff, is auto-apply). It also use two(!) settings keys in the project case. So while it works, it takes manual help for the cancel/apply and toMap/fromMap. Looks like there is still some basic infrastructure missing. Change-Id: I25ab7b41616ee09ff9133e93b84f34947fc32988 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Valgrind: Aspectify settingshjk2021-03-0411-1305/+387
| | | | | Change-Id: I2fbf8244a05ffb1b642843c6471f92e2b154cf8a Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Valgrind: Do not save defaults to settingsEike Ziller2021-02-221-5/+14
| | | | | | | Task-number: QTCREATORBUG-24762 Change-Id: I10fee50cde9facaa35a67114ac15e8b1daa72ab2 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> Reviewed-by: hjk <hjk@qt.io>
* Valgrind: Allow specifying extra arguments to valgrind etchjk2021-02-177-173/+276
| | | | | | Fixes: QTCREATORBUG-18693 Change-Id: Ibb968dcd82b118340a45329b4a14b28d85700661 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Use qAsConst with non-const Qt containers in range-loopsAlessandro Portale2021-02-171-1/+1
| | | | | | | ... in various places Change-Id: Ic6c0c1b9437a1ed402105c7a14a1f5f9454a68d4 Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* Fix a couple of cmake issues for testingChristian Stenger2021-01-271-1/+1
| | | | | | | Correct expected paths, defines and dependencies. Change-Id: Iae3fa708957e352012d0a6bb9cf97713b9a5c35e Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* OutputFormatter: Reduce usages of DebugFormatChristian Stenger2021-01-211-3/+3
| | | | | | | | | | | | | | This is usually used in a wrong or at least misleading way. Replace most of the usages by newly introduced GeneralMessageFormat as most of the replaced usages just print to General Messages and using any of the existing formats would change the layout of the text. Except for some special debug output inside the valgrind plugin that can use one of the existing formats which also makes it easier to spot them and the runners which print QC internal output. Task-number: QTCREATORBUG-24560 Change-Id: I824dc4250b2f3e4656bab8676b45c98e3407d59c Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Debugger: Rename 'AttachExternal' to 'AttachToLocalProcess'hjk2021-01-071-1/+1
| | | | | | | | | | And AttachCrashedExternal to AttachToCrashedProcess And AttachCore to AttachToCore. Clearer. Change-Id: I47c2eca5cbdbbc0eb38b9f62b2504c96558ff112 Reviewed-by: David Schulz <david.schulz@qt.io>
* Use Q_ENUM instead of obsoleted Q_ENUMSJarek Kobus2020-12-111-2/+1
| | | | | | | | | | | It fixes the following warning: Use Q_ENUM instead of Q_ENUMS [clazy-qenums] In addition, it amends 8588cf268f774dbbc242f0805669787c7bc310ac where WidgetStyle got removed. Change-Id: I4d72dd762a2f18ba8886360b3581b4ef19bf4c5e Reviewed-by: hjk <hjk@qt.io>
* Remove unneeded includeJarek Kobus2020-12-101-1/+0
| | | | | Change-Id: Ia61dd59af9bcb1157f9d601892695680974e31f2 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Merge remote-tracking branch 'origin/4.14'Eike Ziller2020-11-251-0/+1
|\ | | | | | | | | | | | | | | Conflicts: src/plugins/designer/cpp/formclasswizard.h src/plugins/designer/cpp/formclasswizarddialog.h Change-Id: I9f9d166e1a9249022305503f9cbe571136c2a2b1
| * Remove unused variablesJarek Kobus2020-11-201-0/+1
| | | | | | | | | | | | | | | | | | | | | | Mark some of them with Q_UNUSED, since it looks like sometimes the copy is done on purpose, to force detach or used for some hack with memory management. In one case make unused variable used again. Change-Id: I3825cd3399fa63bf6e12173c64509287d4a125e5 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* | Don't access static functions/fields via instanceAlessandro Portale2020-11-191-2/+2
|/ | | | | | | Courtesy of readability-static-accessed-through-instance Change-Id: I71f54244f1e091315dac2943d9e1bfad6efa56a9 Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* Silence the warning about comparing type with different signednessJarek Kobus2020-11-131-1/+1
| | | | | | | | | Silence the warning: warning: comparison of integer expressions of different signedness: ‘const long long unsigned int’ and ‘const long long int’ [-Wsign-compare] Change-Id: I3e0ace4a9aa354f9c8b30814265e9d7516fbdc7d Reviewed-by: hjk <hjk@qt.io>
* Remove unneeded includesJarek Kobus2020-11-121-1/+0
| | | | | Change-Id: I67fee9303509b7080e123a2a5826e200ce498ce2 Reviewed-by: hjk <hjk@qt.io>
* Debugger: Provide keyboard shortcuts for "next" and "previous"Christian Kandeler2020-10-302-0/+2
| | | | | | | | | | | ... to applicable analyzers. Rather than inventing separate shortcut categories for all the analyzers, we make use of the fact that only one analyzer view is active at any given time, and make them use the same shortcuts for consistency. Fixes: QTCREATORBUG-20659 Change-Id: Ifa60080def0e6b32395854cff588ab3af9ea33b9 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Qt6: Sprinkle QLatin1Strings for QStringView comparisonsEike Ziller2020-10-081-53/+51
| | | | | | Task-number: QTCREATORBUG-24098 Change-Id: I2fb79bcfd0537a6704a1ee8db840401d6beca7a0 Reviewed-by: hjk <hjk@qt.io>
* Remove unneeded QStringList forward declarationsEike Ziller2020-09-291-1/+0
| | | | | | | | | Fixes build issue with Qt6, for which QStringList is now a QList<QString>. Task-number: QTCREATORBUG-24098 Change-Id: I0c81aa5bae413b836dbedea0bb6117b46f6f24c2 Reviewed-by: hjk <hjk@qt.io>
* ProjectExplorer: Document source of test data for testAbiOfBinary_dataAlessandro Portale2020-09-231-0/+1
| | | | | Change-Id: I2e9b59d5ac99de0bbb9cf1f64210439e41f403af Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Fix build issues with Qt6Eike Ziller2020-09-183-14/+14
| | | | | | | | Change from QStringRef to QStringView at various places. Task-number: QTCREATORBUG-24098 Change-Id: Ia7a634fa26464fbb2962724d5f0e188cecc68801 Reviewed-by: hjk <hjk@qt.io>