aboutsummaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Fix regression in timelineThomas Hartmann2019-03-122-2/+2
| | | | | | | | Empty keyframe groups were created randomly. Change-Id: I223ac7fe5f0112bafebbab26f05f9a45d59849eb Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* qmljs: Fix variable nameKai Koehne2019-03-071-2/+2
| | | | | Change-Id: I8ea8d18e0471071f3a7a22760c041ecf77dbbe8c Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Fix assert in IoUtils::resolvePathDavid Schulz2019-02-281-2/+2
| | | | | | | | | Having an empty base dir should not assert when passing an absolute path file name without drive letter. Change-Id: Ic9f1278df1a8ba938d893f4d21ce1c0bf9053632 Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Clang: Do not assume that one of the overloads always has parametersIvan Donchevskii2019-02-221-1/+1
| | | | | | Fixes: QTCREATORBUG-21841 Change-Id: I5d4fc5d10cdf38d124e84952862b9aaf66888c88 Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* Fix crash in AndroidBuildApkStep::initRobert Loehning2019-02-211-0/+1
| | | | | | | | Change-Id: Ia0b985eb63389edb58c7d32a1fe89c1bad57a1f8 Done-by: Aleksandr Konovalov Fixes: QTCREATORBUG-22007 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
* Clang: Fix infinite loop when resolving pointer typeNikolai Kosjar2019-02-213-2/+9
| | | | | | Fixes: QTCREATORBUG-22010 Change-Id: I5a2932089e9f7fb1e283635e228192fdb7e59cab Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
* QmlDesigner: Fix crashThomas Hartmann2019-02-202-43/+210
| | | | | | | | | | | | The version number of 'GradientStop' was hardcoded, but does change with QtQuick 5.12. The issue is not consistently triggered. This is a backport from master. Task-number: QDS-472 Change-Id: I939659aa14ae1570fc5d833726f28894c043da02 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io> Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* Clang: Fix stack-use-after-scope sanitizer error in diagnostic filterKirill Burtsev2019-02-191-1/+1
| | | | | Change-Id: I97d69caf9c7b642bef277fdfa0df80820fcdbe2f Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* C++: Fix nullptr references in preprocessorNikolai Kosjar2019-02-141-6/+8
| | | | | | Fixes: QTCREATORBUG-21981 Change-Id: Iaded998eb793fb4284a9f8b22b2fa7a7443a1585 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Debugger: Change workaround for scrambled dock widget layoutshjk2019-02-131-16/+8
| | | | | | | | | | | | | | | | The workaround from 3d92a79a introduces a bug by itself: When a user moves all docks off the bottom area, the workaround will trigger as the condition "nothing below the tool bar" is met. This here changes the condition to toolbar.width() != mainwindow.width(), which will trigger in the known scrambled situations (there was always something to the right of the toolbar), but not in the situation described above. Task-number: QTCREATORBUG-21669 Task-number: QTCREATORBUG-21455 Change-Id: Ic2eabbe2ed07352680add4fc5e3b5f6673600479 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* QmlDesigner: Do not generate auxiliaryDataAsQML for offset -1Thomas Hartmann2019-02-111-2/+9
| | | | | | | If a node does not have a proper offset, then the data is inconsistent. Change-Id: I1fbff3e169b225bc4ca00b1deb21982f30281f9a Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* ExternalToolConfig: Fix choosing executableAndre Hartmann2019-02-111-0/+1
| | | | | | | | | | Somehow the function to select the executable broke and changed to "Choose Directory". Fixes: QTCREATORBUG-21937 Change-Id: Ifc596df276a3e26bb063d5b856fca29f9db227df Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Fix crash while quitting debuggingVikas Pachdha2019-02-101-1/+1
| | | | | | Task-number: QTCREATORBUG-21684 Change-Id: I2a51d0666f2a591daeec34fc88ee12aa50265ff3 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* macOS: Fix broken Info.plistEike Ziller2019-02-081-0/+2
| | | | | | | | | Fixup of dd0156d1facc5422464dc1b430696a0b63db605f For some reason Xcode removed the closing tags when editing the Info.plist file in its editor... Change-Id: Ib9e53dce0be13ad0bb03ae46386c632b448b6a9a Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
* Fix include paths with subfolderRaoul Hecky2019-02-071-4/+19
| | | | | | | | | | | When an autotools project is using SUBDIRS it starts a new parser. The new parser object was not propagating includes/defines/flags to the main parser object, and thus the code model did miss those. This commit fixes that. Task-number: QTCREATORBUG-21618 Change-Id: I19ed4dd3820257378e888f3c4935ebd30e958828 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Fix highlighting of regexp search results in editorEike Ziller2019-02-071-14/+19
| | | | | | | | | | The highlighting in the editor was still done with QRegExp, so if you used Perl regular expression features, highlighting in the editor was incorrect. Fixes: QTCREATORBUG-21940 Change-Id: I785f0b2413a291d9f06de5877b18067a30d58588 Reviewed-by: Marco Bubke <marco.bubke@qt.io>
* macOS 10.14: Allow user applications to request access to servicesEike Ziller2019-02-041-2/+20
| | | | | | | | | | | | | | | | | | In macOS Mojave applications have to provide information about the reason they want to access certain services (Camera, Microphone, etc). If they do not provide this information in their Info.plist, they possibly are even killed by the system. For direct child processes, like user applications are when started from Qt Creator, this information is taken from the parent application, i.e. Qt Creator, even if the child process provides the information in it's own Info.plist. Fixes: QTCREATORBUG-21887 Change-Id: I1bc149fea928a26d59d126f6b1be71649a4369ed Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
* Debugger: Fix gdb detachinghjk2019-02-011-1/+1
| | | | | | | | | | Too much cleverness in python command detection: "attach" is parsed as possible Python command. Make it explicit that it is not. Task-number: QTCREATORBUG-21908 Change-Id: I68444bccfb485ef1befe81b4b6b13243c2c8a500 Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Help: Disable middle-mouse click outside of help modeEike Ziller2019-02-011-1/+2
| | | | | | | | Since only help mode supports it. Fixes: QTCREATORBUG-20554 Change-Id: Ida8cee01c0ab0c8fc5ffacf3c4521feeadf65995 Reviewed-by: David Schulz <david.schulz@qt.io>
* QML: Fix auto-insertion of single quoteEike Ziller2019-02-011-1/+1
| | | | | | | | | After inserting a matching single quote it should not add yet another single quote when typing one explicitly. Change-Id: I568f02e4edbb78ef11665bb7f4a9f3b91cf9b887 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> Reviewed-by: David Schulz <david.schulz@qt.io>
* Android: Fix gdbserver upload for Windows when using Armv8 archVikas Pachdha2019-02-012-25/+71
| | | | | | | | | | The gdbserver is not uploaded to device for armv7 as lib symlink is available and we can use the gdbserver packaged with the apk Task-number: QTCREATORBUG-21317 Change-Id: I263eb48bbf3cf05b969db934a928185dba10373b Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: hjk <hjk@qt.io>
* AutoTest: Fix handling of empty testsChristian Stenger2019-02-011-1/+1
| | | | | | | | | If an item of type MessageCaseStart is going to be updated it might end up in still getting no icon if none of its children is enforcing a change. Change-Id: I7ec6d114c547189a02744f064d4c04cdf31a03d7 Reviewed-by: David Schulz <david.schulz@qt.io>
* winrt: Fix potential race condition when filling mapping file contentOliver Wolff2019-01-301-2/+2
| | | | | | | | | Before starting the process step asynchronously, we have to make sure that m_mappingFileContent is initialized properly. Change-Id: I5a2b51319a35bfe397cff994d5f3512f8d76ccf0 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Debugger: Decouple combined engine rampdown furtherhjk2019-01-281-2/+0
| | | | | | | | | | There are apparently uses where one still want to have a fully functional C++ engine even when QML is already done. (cherry picked from commit 3fdb5f53e31f615836b8ed13cecb9527ba165e3c) Task-number: QTCREATORBUG-21857 Change-Id: I5dfd80e5ff02dcc3e5e2d6b5913a75af071f53d3 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* QFile/QFileInfo: readLink() was replaced by symLinkTarget()Liang Qi2019-01-251-1/+1
| | | | | | | (partially cherry picked from qtbase/7c69f6171ddc76d22e4f6e433be69c5cf365db8f) Change-Id: I8910c8d5255f6ea12589c04eeedcec3d8fd3f277 Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: Christian Ehrlicher <ch.ehrlicher@gmx.de>
* Fix ProjectExplorerPlugin::testProject_setup()Christian Kandeler2019-01-241-4/+14
| | | | | | | | The absolute test paths must be in the right format for the host platform, i.e. have a drive letter on Windows. Change-Id: Ibf08a9e8a8b1f9ee1bb19d5307205b53012049b5 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Fix ProjectExplorerPlugin::testJsonWizardsIconList()Christian Kandeler2019-01-241-2/+2
| | | | | | | | We returned a pointer to temporary data from a function. Amends 6796839da3. Change-Id: I920789b344c93158092ef23e4bb8019cc9c312c9 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Allow a bit more configuration range for auto-completion timeoutEike Ziller2019-01-241-1/+1
| | | | | Change-Id: I82e9baf97e6895675657e6138f930da766b59079 Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* QtSupport: Fix crash in QtSupport unit testsChristian Kandeler2019-01-231-0/+1
| | | | | | | Commit f685e2bfb4 introduced a double delete. Change-Id: Ic871d623d4c826ec18f10f1a96ec4a3adfcf63c5 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* QmlDesigner: Remove write lockerThomas Hartmann2019-01-231-4/+0
| | | | | | | This can be triggered by states changes. Change-Id: I306b39e579eee6953f8c7b0b72aa3f52615c73ec Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* QmlDesigner: Do not set modified to true on loadThomas Hartmann2019-01-212-0/+8
| | | | | | | | This was triggered by restoring the aux data. Task-number: QDS-377 Change-Id: I9cf3c6b2fff3eb318de4a873103d615416912d9c Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* QmlDesigner: Add some extra info to warnings and assertsThomas Hartmann2019-01-212-1/+6
| | | | | Change-Id: Ib9c924f7a619b5e79480b5a99291cb9969e7f629 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* Fix crash with reload prompt in presence of modal dialogEike Ziller2019-01-181-1/+6
| | | | | | | | | | | | When a modal dialog is open, we delay the opening of the reload prompt, which is good. We should not directly open the reload prompt while processing a focus change signal, because that will interfere too much with the focus itself. Queue the signal processing. Fixes: QDS-381 Change-Id: I8973aa986de5a46bf874529cbbda0b325222fcac Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
* Debugger: Switch default positions of preset paneshjk2019-01-181-3/+3
| | | | | | | | | | | The different default positions of the "Breakpoint Preset" and the "Breakpoint" views seem to cause confusion. They are apparently perceived to be the same, and people file complaints about position switching. Change-Id: I29104552291f4e7f057ff8765243592da0b4cf74 Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Fix warningThomas Hartmann2019-01-181-1/+1
| | | | | Change-Id: I646cf0d1c1e7dec7f44baf50a586ff22044cb7f0 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* CPlusPlus: Block function-like macro name for arguments expansionIvan Donchevskii2019-01-172-11/+26
| | | | | | | | | | | | | | Arguments of funstion-like macro may contain the name of this macro. The attempt to expand it results into infinite recursion. Patch solves that by saving the macro name until the arguments are collected to determine that it should not be expanded. Fixes: QTCREATORBUG-21642 Change-Id: Iafb404ecd3959a2f1011c12c1c3f1c0c54ed3547 Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: Erik Verbruggen <erik.verbruggen@qt.io>
* QmlDesigner: Allow more JavaScript functionsThomas Hartmann2019-01-161-13/+17
| | | | | | Task-number: QDS-355 Change-Id: I0f330216b0120857f21b804236d2e3338c812749 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* QmlDesigner: Use proper canocial ordering for auxiliary datav4.8.1Thomas Hartmann2019-01-152-4/+48
| | | | | | | | When saving auxiliary data we haver to use a proper ordering of the node to generate an index. Change-Id: I54101c4770eec359de4fdaffbbe37308416a5714 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Fix that debugger tooltips were overridden by editor tooltipsEike Ziller2019-01-141-1/+0
| | | | | | | | | | | | The debugger tells the editor if the tool tip was handled or not, but since that information is transferred through a reference parameter in a signal/slot connection, a second debugger engine overrode the value of a previous one. So never set it to 'false' so a previous 'true' is not overridden. Fixes: QTCREATORBUG-21825 Change-Id: Iec3d15485f224ab0ad14564656886a53fec62e71 Reviewed-by: hjk <hjk@qt.io>
* Clang: Fix parsing boost headersIvan Donchevskii2019-01-142-19/+28
| | | | | | | | | | | | | The fix for MSVC2013 undefined clang macros to fix some internal Qt stuff failing in Qt 5.7. Now we know exactly which MSVC version is used and can ignore this fix for newer versions. Fixes: QTCREATORBUG-16439 Fixes: QTCREATORBUG-21685 Change-Id: Ie2844428c39d72d212198ee2dd6841420a464974 Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
* Debugger: Fix "Debugger font size follows main editor"hjk2019-01-101-1/+1
| | | | | | | | | ... for the ex-snapshot-now-engine-manager view. Task-number: QTCREATORBUG-21803 Change-Id: I0c0a6199fa1dabc5c045fe6d0740de458dc63cda Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: Tim Blechmann <tim@klingt.org>
* QmlDesigner: Fix compile Qt 5.9 and 5.10Christian Stenger2019-01-101-1/+3
| | | | | | | Broke with 1e711d50dc. Change-Id: I6a4c192d4c924b9a63801b5802aeb17681b2608e Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* QmlDesigner: Fix notifier for navigatorThomas Hartmann2019-01-091-1/+1
| | | | | | | | | We have to update the complete row, since column 1 contains the alias indicator and column 2 contains the visibilty indicator. Task-number: QDS-274 Change-Id: Ib1688b5bceab144f9cd8ff3a784dc1efa6d4ea54 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Android: Find triple from predefined targetsVikas Pachdha2019-01-091-1/+5
| | | | | | Task-number: QTCREATORBUG-21780 Change-Id: Ic6e94a0ef94fc253f8a60383b2d060851b135d9f Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Respect the setting of the version code via the pro fileAndy Shaw2019-01-092-11/+7
| | | | | | | | | | | | As a pro file can now set the version name and code via the pro file, this enables support for the code part as it will default to a variable (similar to the version name). Therefore we need to use QLineEdit for this over QSpinBox so that it is kept intact. Done-with: Markus Maier <markus.maier@rosenberger.de> Change-Id: I0524a90dc94888c11365164c41259a934caffa1c Reviewed-by: Markus Maier <markus.maier@rosenberger.de> Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
* Clang: Stop going to F2 location if invocation context changedNikolai Kosjar2019-01-081-3/+10
| | | | | | | | | If follow symbol takes longer than expected and the user switched to another file or mode, abort processing the result in order to avoid confusion. Change-Id: I0106d49006d2cfd8c8dad0af66d97cee5e5c36de Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
* Clang: Set LC_NUMERIC to "C" for clangbackendNikolai Kosjar2019-01-081-0/+5
| | | | | | | | | | The tidy check SuspiciousMissingCommaCheck uses the locale dependent stod() when reading settings and might throw std::invalid_argument for a locale different than "C". Fixes: QTCREATORBUG-21605 Change-Id: I69bf719a8fd94e13ce67b46238f536c85ab2eaa3 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
* Debugger: Fix step into after switching operate by instructionDavid Schulz2019-01-081-1/+1
| | | | | | | | | Update m_lastOperateByInstruction by calling adjustOperateByInstruction before checking before checking the value. Change-Id: Ic58da417f83381d9a2300ac0e5fcd2c06f41fc34 Fixes: QTCREATORBUG-21708 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* QtOutputFormatter: Fix handling file:// links with following timestampsAndre Hartmann2019-01-071-0/+14
| | | | | | | | Especially on Windows, where drive letters are involved too. Fixes: QTCREATORBUG-20110 Change-Id: I172c8a39d59ce4c8ffadf210eb4c592ef2609f11 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* QtOutputFormatter: Handle Windows-style Qt Test failure linksAndre Hartmann2019-01-071-5/+26
| | | | | | | Fixes: QTCREATORBUG-21744 Change-Id: Iaae1d58df641a0ba72d88c1fba5dbb47412a978c Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>