summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIevgenii Meshcheriakov <ievgenii.meshcheriakov@qt.io>2022-02-10 18:07:40 +0100
committerIevgenii Meshcheriakov <ievgenii.meshcheriakov@qt.io>2022-02-10 17:34:44 +0000
commitc9935bdb8bb03bb3c1b98c7e47d5fd6f95e93be0 (patch)
treef81c2d117f10785f79bb7df37ea53e937d407545
parent4dbe4d250ac3c91b2caaf0a2fc592ecd3eac39db (diff)
tst_qhttpserver: Fix code for ignoring SSL errors
Don't print expected errors. The existing code was printing all errors at least once. Task-number: QTBUG-100479 Change-Id: I970b9e0b59f7abd9c82f2a750017eb9739b1fd24 Reviewed-by: Mikhail Svetkin <mikhail.svetkin@gmail.com> Reviewed-by: MÃ¥rten Nordheim <marten.nordheim@qt.io>
-rw-r--r--tests/auto/qhttpserver/tst_qhttpserver.cpp9
1 files changed, 2 insertions, 7 deletions
diff --git a/tests/auto/qhttpserver/tst_qhttpserver.cpp b/tests/auto/qhttpserver/tst_qhttpserver.cpp
index db07383..37a4162 100644
--- a/tests/auto/qhttpserver/tst_qhttpserver.cpp
+++ b/tests/auto/qhttpserver/tst_qhttpserver.cpp
@@ -395,13 +395,8 @@ void tst_QHttpServer::initTestCase()
[expectedSslErrors](QNetworkReply *reply,
const QList<QSslError> &errors) {
for (const auto &error: errors) {
- for (const auto &expectedError: expectedSslErrors) {
- if (error.error() != expectedError.error() ||
- error.certificate() != expectedError.certificate()) {
- qCritical() << "Got unexpected ssl error:"
- << error << error.certificate();
- }
- }
+ if (!expectedSslErrors.contains(error))
+ qCritical() << "Got unexpected ssl error:" << error << error.certificate();
}
reply->ignoreSslErrors(expectedSslErrors);
});