summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoerg Bornemann <joerg.bornemann@qt.io>2016-06-29 18:23:36 +0200
committerJoerg Bornemann <joerg.bornemann@qt.io>2016-07-05 08:09:34 +0000
commitd397c2af671ca1449106342e89346bfaf4a395a8 (patch)
tree1568753df31d5aaa378fe121ebb471f52bdf9cfe
parentdc528350e4b206260fc28132c7553899c6869b1c (diff)
Avoid double hash lookup
Change-Id: I1d9816d0092c0f6875120fe34e23a453e8b96aa9 Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
-rw-r--r--src/jomlib/dependencygraph.cpp7
1 files changed, 3 insertions, 4 deletions
diff --git a/src/jomlib/dependencygraph.cpp b/src/jomlib/dependencygraph.cpp
index e4af688..d3db7f9 100644
--- a/src/jomlib/dependencygraph.cpp
+++ b/src/jomlib/dependencygraph.cpp
@@ -180,11 +180,10 @@ void DependencyGraph::internalBuild(Node* node)
continue;
}
- Node* child;
- if (m_nodeContainer.contains(dependent)) {
- child = m_nodeContainer.value(dependent);
+ Node* child = m_nodeContainer.value(dependent);
+ if (child)
addEdge(node, child);
- } else
+ else
child = createNode(dependent, node);
internalBuild(child);