diff options
author | Robin Burchell <robin.burchell@crimson.no> | 2017-04-26 13:31:37 +0200 |
---|---|---|
committer | Robin Burchell <robin.burchell@crimson.no> | 2017-04-26 16:05:24 +0000 |
commit | f104e15d05ef7b136f2e922e897012ebd8c1ca34 (patch) | |
tree | 00add267a001e11eeb753d96abe968b6fbbe80b4 | |
parent | ce0bc2626e55b8f710c54498daefc3df88d70e3d (diff) |
Add description to changing_over_isolated_with_clip tests
Change-Id: I1e6a46cc8b85f63e29b1e80de938b6c0feba48d2
Reviewed-by: Gunnar Sletta <gunnar@crimson.no>
-rw-r--r-- | benchmarks/auto/changes/changing_over_isolated_with_clip.qml | 3 | ||||
-rw-r--r-- | benchmarks/auto/changes/changing_over_isolated_with_clip_rotated.qml | 14 |
2 files changed, 15 insertions, 2 deletions
diff --git a/benchmarks/auto/changes/changing_over_isolated_with_clip.qml b/benchmarks/auto/changes/changing_over_isolated_with_clip.qml index cb7a45e..f7a0bc2 100644 --- a/benchmarks/auto/changes/changing_over_isolated_with_clip.qml +++ b/benchmarks/auto/changes/changing_over_isolated_with_clip.qml @@ -1,5 +1,8 @@ import QtQuick 2.0 +// Tests that a single item changing in one subtree, and many items in another +// tree, do not have bad performance when both subtrees are isolated with +// "clip: true". Item { id: root; property int count: 100; diff --git a/benchmarks/auto/changes/changing_over_isolated_with_clip_rotated.qml b/benchmarks/auto/changes/changing_over_isolated_with_clip_rotated.qml index 7c2d085..aefa3be 100644 --- a/benchmarks/auto/changes/changing_over_isolated_with_clip_rotated.qml +++ b/benchmarks/auto/changes/changing_over_isolated_with_clip_rotated.qml @@ -1,5 +1,15 @@ import QtQuick 2.0 +// Tests that a single item changing in one subtree, and many items in another +// tree, do not have bad performance when both subtrees are isolated with +// "clip: true". +// +// Different from changing_over_isolated_with_clip, we also rotate, as this +// can't just be clipped with scissoring. +// +// TODO: consider whether it makes sense to test this as a specific render +// test, changing_over_isolated_with_clip covers the clipping part well enough +// that perhaps we don't need this approach. Useful for now, though. Item { id: root; property int count: 1000; @@ -19,10 +29,10 @@ Item { color: Qt.hsla(Math.random(), 0.9, 0.4) width: 20 height: 20 - clip: true - rotation: 10 x: Math.random() * root.width y: Math.random() * root.height + clip: true + rotation: 10 Text { color: "white" |