Optimize isDescendant function

Change-Id: I6f07088c54420b06d7aa5bfa0bd43d62bf84da2e
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>

1 files changed, 7 insertions, 9 deletions

diff --git a/editorlib/src/editorutils.cpp b/editorlib/src/editorutils.cpp
index eebdb51..37c1cab 100644
--- a/editorlib/src/editorutils.cpp
+++ b/editorlib/src/editorutils.cpp
@@ -1223,16 +1223,14 @@ QVector3D EditorUtils::cameraNormal(Qt3DRender::QCamera *camera)
 
 bool EditorUtils::isDescendant(EditorSceneItem *ancestor, EditorSceneItem *descendantItem)
 {
-    bool descendant = ancestor == descendantItem;
-    if (!descendant) {
-        Q_FOREACH (EditorSceneItem *item, ancestor->childItems()) {
-            if (isDescendant(item, descendantItem)) {
-                descendant = true;
-                break;
-            }
-        }
+    EditorSceneItem *parent = descendantItem->parentItem();
+
+    while (parent) {
+        if (parent == ancestor)
+            return true;
+        parent = parent->parentItem();
     }
-    return descendant;
+    return false;
 }
 
 EditorUtils::InsertableEntities EditorUtils::insertableEntityType(Qt3DCore::QEntity *entity)