summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMikhail Svetkin <mikhail.svetkin@gmail.com>2019-07-06 15:00:17 +0200
committerMikhail Svetkin <mikhail.svetkin@gmail.com>2019-07-11 20:10:31 +0200
commita8777eb51e9e50161f9e6c240d3cf4a7a5aa7e8a (patch)
tree47d84b4ab664e59904d097f41a5953ef40189341
parentb025906bf73a2a571fe4c6ad8aea6331d4cc59b7 (diff)
QHttpServerResponse: use compact mode for json objects
Change-Id: Ia01f2f9a1483b326bc92eda20045f9764616cf66 Reviewed-by: Tasuku Suzuki <tasuku.suzuki@qbc.io> Reviewed-by: MÃ¥rten Nordheim <marten.nordheim@qt.io>
-rw-r--r--src/httpserver/qhttpserverresponse.cpp3
-rw-r--r--tests/auto/qhttpserver/tst_qhttpserver.cpp15
2 files changed, 17 insertions, 1 deletions
diff --git a/src/httpserver/qhttpserverresponse.cpp b/src/httpserver/qhttpserverresponse.cpp
index 72ec7ac..9b04ce0 100644
--- a/src/httpserver/qhttpserverresponse.cpp
+++ b/src/httpserver/qhttpserverresponse.cpp
@@ -71,7 +71,8 @@ QHttpServerResponse::QHttpServerResponse(const QByteArray &data)
}
QHttpServerResponse::QHttpServerResponse(const QJsonObject &data)
- : QHttpServerResponse(mimeApplicationJson, QJsonDocument(data).toJson())
+ : QHttpServerResponse(mimeApplicationJson,
+ QJsonDocument(data).toJson(QJsonDocument::Compact))
{
}
diff --git a/tests/auto/qhttpserver/tst_qhttpserver.cpp b/tests/auto/qhttpserver/tst_qhttpserver.cpp
index dd1e593..69b176c 100644
--- a/tests/auto/qhttpserver/tst_qhttpserver.cpp
+++ b/tests/auto/qhttpserver/tst_qhttpserver.cpp
@@ -42,6 +42,8 @@
#include <QtCore/qbytearray.h>
#include <QtCore/qdatetime.h>
#include <QtCore/qmetaobject.h>
+#include <QtCore/qjsonobject.h>
+#include <QtCore/qjsonvalue.h>
#include <QtNetwork/qnetworkaccessmanager.h>
#include <QtNetwork/qnetworkreply.h>
@@ -196,6 +198,13 @@ void tst_QHttpServer::initTestCase()
return QHttpServerResponse::fromFile(QFINDTESTDATA(QLatin1String("data/") + file));
});
+ httpserver.route("/json-object/", [] () {
+ return QJsonObject{
+ {"property", "test"},
+ {"value", 1}
+ };
+ });
+
urlBase = QStringLiteral("http://localhost:%1%2").arg(httpserver.listen());
}
@@ -360,6 +369,12 @@ void tst_QHttpServer::routeGet_data()
<< 200
<< "application/json"
<< "{ \"key\": \"value\" }";
+
+ QTest::addRow("json-object")
+ << "/json-object/"
+ << 200
+ << "application/json"
+ << "{\"property\":\"test\",\"value\":1}";
}
void tst_QHttpServer::routeGet()