summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Adam <tommyadam@freenet.de>2013-07-03 14:53:20 +0200
committerYoann Lopes <yoann.lopes@digia.com>2013-07-04 15:49:57 +0200
commitc1d67f404d4bde22e8cce51102d939fffaa1c8e1 (patch)
tree788fd93f7a76d22ab5757c476ac98a533de5e1b5
parent9960fda6e59c5dfc0ff5535f85159a6a49d07873 (diff)
Fix resource leak in directshow plugin.
Add two missing release calls to free file handles. Task-number: QTBUG-23822 Change-Id: I27b631e28d48b7a20cc76c0913a8d962ee991ce5 Reviewed-by: Wouter Huysentruit <wouter.huysentruit@dzine.be> Reviewed-by: Yoann Lopes <yoann.lopes@digia.com>
-rw-r--r--plugins/multimedia/directshow/player/directshowplayerservice.cpp4
1 files changed, 4 insertions, 0 deletions
diff --git a/plugins/multimedia/directshow/player/directshowplayerservice.cpp b/plugins/multimedia/directshow/player/directshowplayerservice.cpp
index 4fcf62a446..eb178002ad 100644
--- a/plugins/multimedia/directshow/player/directshowplayerservice.cpp
+++ b/plugins/multimedia/directshow/player/directshowplayerservice.cpp
@@ -576,6 +576,9 @@ void DirectShowPlayerService::doReleaseGraph(QMutexLocker *locker)
control->Release();
}
+ //release m_headerInfo -> decrease ref counter of m_source
+ m_metaDataControl->updateGraph(0, 0);
+
if (m_source) {
m_source->Release();
m_source = 0;
@@ -625,6 +628,7 @@ int DirectShowPlayerService::findStreamTypes(IBaseFilter *source) const
}
}
}
+ pins->Release();
}
filter->Release();
}