diff options
| author | Olivier Goffart <olivier.goffart@nokia.com> | 2010-08-16 17:35:17 +0200 |
|---|---|---|
| committer | Liang Qi <liang.qi@nokia.com> | 2010-08-16 17:35:17 +0200 |
| commit | 34eb6cb58629c58b819d4c82b582106513da03bd (patch) | |
| tree | 6281c6a197f8c38d1fd2471363243df79d64b47e /doc | |
| parent | bc2a71b317724840c695b39f523ca510c28d15e5 (diff) | |
diagramscene example: fix leak and crashes.
In MainWindow::deleteItem, if there is arrow selected, we need to clean
up the items from this arrow. We need to delete them first so there is no
arrow in the list anymore when we calls removeArrows (which before,
deleted arrow that were possibly in the list, resulting in crashes)
Also avoid leak by giving parents to objects that needs it, and destroying items.
Reviewed-by: Geir Vattekar
Task-number: QTBUG-12753
Merge-request: 775
Reviewed-by: Liang Qi <liang.qi@nokia.com>
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/src/examples/diagramscene.qdoc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/doc/src/examples/diagramscene.qdoc b/doc/src/examples/diagramscene.qdoc index f4d6b0d41f..7c643c2d38 100644 --- a/doc/src/examples/diagramscene.qdoc +++ b/doc/src/examples/diagramscene.qdoc @@ -265,7 +265,8 @@ \snippet examples/graphicsview/diagramscene/mainwindow.cpp 3 - This slot deletes the selected item, if any, from the scene. If + This slot deletes the selected item, if any, from the scene. It + deletes the arrows first in order to avoid to delete them twice. If the item to be deleted is a \c DiagramItem, we also need to delete arrows connected to it; we don't want arrows in the scene that aren't connected to items in both ends. |