diff options
| author | Shane Kearns <shane.kearns@accenture.com> | 2010-09-13 14:57:08 +0100 |
|---|---|---|
| committer | Shane Kearns <shane.kearns@accenture.com> | 2010-09-13 15:28:09 +0100 |
| commit | 7f5417353bd71a63e962851ba598f1e2631f4a25 (patch) | |
| tree | 758986884953c82d7c876a5615912900caafc9c0 /src/corelib/io/qfilesystemengine_symbian.cpp | |
| parent | a12e4996b8316badd7784b204ea8f22b7986f032 (diff) | |
Fix setPermissions in symbian
In error, it was checking the read permissions to set the read-only
file attribute, when it should have been checking the write permissions.
read-only = !writable.
Reviewed-By: Thomas Zander
Diffstat (limited to 'src/corelib/io/qfilesystemengine_symbian.cpp')
| -rw-r--r-- | src/corelib/io/qfilesystemengine_symbian.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/corelib/io/qfilesystemengine_symbian.cpp b/src/corelib/io/qfilesystemengine_symbian.cpp index 1ed4ee87cd..6bad860d2c 100644 --- a/src/corelib/io/qfilesystemengine_symbian.cpp +++ b/src/corelib/io/qfilesystemengine_symbian.cpp @@ -290,7 +290,7 @@ bool QFileSystemEngine::removeFile(const QFileSystemEntry &entry) QString targetpath = absoluteName(entry).nativeFilePath(); RFs& fs(qt_s60GetRFs()); TInt err = fs.Delete(qt_QString2TPtrC(targetpath)); - return false; // TODO error reporting; + return err == KErrNone; // TODO error reporting; } //static @@ -300,8 +300,8 @@ bool QFileSystemEngine::setPermissions(const QFileSystemEntry &entry, QFile::Per TUint setmask = 0; TUint clearmask = 0; RFs& fs(qt_s60GetRFs()); - if (permissions & (QFile::ReadOwner | QFile::ReadUser | QFile::ReadGroup | QFile::ReadOther)) - clearmask = KEntryAttReadOnly; + if (permissions & (QFile::WriteOwner | QFile::WriteUser | QFile::WriteGroup | QFile::WriteOther)) + clearmask = KEntryAttReadOnly; //if anyone can write, it's not read-only else setmask = KEntryAttReadOnly; TInt err = fs.SetAtt(qt_QString2TPtrC(targetpath), setmask, clearmask); @@ -310,7 +310,7 @@ bool QFileSystemEngine::setPermissions(const QFileSystemEntry &entry, QFile::Per data->entryFlags |= QFileSystemMetaData::MetaDataFlag(uint(permissions)); data->knownFlagsMask |= QFileSystemMetaData::Permissions; } - return err != KErrNone; // TODO error reporting + return err == KErrNone; // TODO error reporting } QT_END_NAMESPACE |