diff options
| author | Thiago Macieira <thiago.macieira@nokia.com> | 2010-09-02 17:09:13 +0200 |
|---|---|---|
| committer | Thiago Macieira <thiago.macieira@nokia.com> | 2010-09-02 17:10:36 +0200 |
| commit | 4b7346a4bd30705ab5910d448ec56daa6568aa90 (patch) | |
| tree | 292f79d467fcd4ef92f6efbb4428c0c6989cab4b /src/dbus | |
| parent | 71a3b1a0d3ee6429832bdbf0da026cdc3f74080f (diff) | |
Fix remote crash in delivering D-Bus calls with too few arguments
Patch by Christoph Feck.
Task-number: QTBUG-13348
Reviewed by me
Diffstat (limited to 'src/dbus')
| -rw-r--r-- | src/dbus/qdbusintegrator.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/dbus/qdbusintegrator.cpp b/src/dbus/qdbusintegrator.cpp index 7951177fab..3833874aaf 100644 --- a/src/dbus/qdbusintegrator.cpp +++ b/src/dbus/qdbusintegrator.cpp @@ -714,6 +714,9 @@ QDBusCallDeliveryEvent* QDBusConnectionPrivate::prepareReply(QDBusConnectionPriv if (metaTypes[n] == QDBusMetaTypeId::message) --n; + if (msg.arguments().count() < n) + return 0; // too few arguments + // check that types match for (int i = 0; i < n; ++i) if (metaTypes.at(i + 1) != msg.arguments().at(i).userType() && |