summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarc Mutz <marc.mutz@kdab.com>2016-04-28 13:53:32 +0200
committerMarc Mutz <marc.mutz@kdab.com>2016-04-30 20:52:19 +0000
commit62e0265408724f13c472904e0563007f19549fba (patch)
tree7ceada1730383bb2f1cb1c21463328d29a34149e
parent05a54a36854359df445a0e0cbfe1cd038ec0799d (diff)
QRayCastingService: don't iterate over QHash::values()
... iterate over the container itself instead. Avoids creation of a temporary QList. Saves almost 1.5KiB in text size on optimized GCC 6.0 Linux AMD64 builds. Change-Id: I771383f9848999bdbdd96e52f7956d44d5b3b15a Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
-rw-r--r--src/render/raycasting/qraycastingservice.cpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/render/raycasting/qraycastingservice.cpp b/src/render/raycasting/qraycastingservice.cpp
index 3b505b548..31df3df47 100644
--- a/src/render/raycasting/qraycastingservice.cpp
+++ b/src/render/raycasting/qraycastingservice.cpp
@@ -204,11 +204,10 @@ QVector<QCollisionQueryResult> QRayCastingService::fetchAllResults() const
{
Q_D(const QRayCastingService);
- const QList<FutureQueryResult> futureResults = d->m_results.values();
QVector<QCollisionQueryResult> results;
- results.reserve(futureResults.size());
+ results.reserve(d->m_results.size());
- Q_FOREACH (const FutureQueryResult &future, futureResults)
+ for (const FutureQueryResult &future : d->m_results)
results.append(future.result());
return results;