summaryrefslogtreecommitdiffstats
path: root/src/render/renderstates
diff options
context:
space:
mode:
authorMike Krus <mike.krus@kdab.com>2020-04-24 13:43:56 +0100
committerMike Krus <mike.krus@kdab.com>2020-04-27 11:57:33 +0100
commit6c1758d35e20655f46ba3696671068f4862c8878 (patch)
treed4b4fc2ae8f5a4512de4eb015667b024b6a8e6b9 /src/render/renderstates
parentb7967a8abcdac438a1f31800b71e219e3c52c24a (diff)
parent37735f11f9437b916b194cfd48c452c7c70682f8 (diff)
Merge remote-tracking branch 'origin/5.15' into dev
Diffstat (limited to 'src/render/renderstates')
-rw-r--r--src/render/renderstates/qblendequationarguments.h4
-rw-r--r--src/render/renderstates/renderstateset.cpp2
-rw-r--r--src/render/renderstates/renderstateset_p.h5
3 files changed, 6 insertions, 5 deletions
diff --git a/src/render/renderstates/qblendequationarguments.h b/src/render/renderstates/qblendequationarguments.h
index 878534816..b8b0d5ff1 100644
--- a/src/render/renderstates/qblendequationarguments.h
+++ b/src/render/renderstates/qblendequationarguments.h
@@ -66,8 +66,8 @@ public:
One = 1,
SourceColor = 0x0300,
SourceAlpha = 0x0302,
- Source1Alpha,
- Source1Color,
+ Source1Alpha, // ### Qt 6: Fix -> has same value as OneMinusSourceAlpha
+ Source1Color, // ### Qt 6: Fix -> has same value as DestinationAlpha
DestinationColor = 0x0306,
DestinationAlpha = 0x0304,
SourceAlphaSaturate = 0x0308,
diff --git a/src/render/renderstates/renderstateset.cpp b/src/render/renderstates/renderstateset.cpp
index 6b66d2dd7..5b9c4e8b5 100644
--- a/src/render/renderstates/renderstateset.cpp
+++ b/src/render/renderstates/renderstateset.cpp
@@ -102,7 +102,7 @@ StateMaskSet RenderStateSet::stateMask() const
// This modifies our state to add states from others
// if we don't already contain a state with that type set
-void RenderStateSet::merge(RenderStateSet *other)
+void RenderStateSet::merge(const RenderStateSet *other)
{
m_stateMask |= other->stateMask();
const QVector<StateVariant> otherStates = other->states();
diff --git a/src/render/renderstates/renderstateset_p.h b/src/render/renderstates/renderstateset_p.h
index 119f1edca..667c2614d 100644
--- a/src/render/renderstates/renderstateset_p.h
+++ b/src/render/renderstates/renderstateset_p.h
@@ -89,9 +89,10 @@ public:
int changeCost(RenderStateSet* previousState);
StateMaskSet stateMask() const;
- void merge(RenderStateSet *other);
+ void merge(const RenderStateSet *other);
- QVector<StateVariant> states() const { return m_states; }
+ const QVector<StateVariant>& states() const noexcept { return m_states; }
+ QVector<StateVariant>& states() noexcept { return m_states; }
bool canAddStateOfType(StateMask type) const;