diff options
| author | Lars Knoll <lars.knoll@qt.io> | 2017-09-08 17:31:36 +0200 |
|---|---|---|
| committer | Sean Harmer <sean.harmer@kdab.com> | 2017-09-09 09:42:38 +0000 |
| commit | cf038f9059d88271c087b958f04a10e6f468c249 (patch) | |
| tree | c2a2052d404ac29a7197641e39ed7e03d18b4e7e /src | |
| parent | 5212c27c7ca2fb708a563c000debd46a377d72ac (diff) | |
Fix logic error
This should be removeAll instead of remove(). Remove takes an
integer (index into the array). It compiles by chance (but doesn't
do the right thing), as QHandle has a cast operator to int.
Change-Id: If8d59a535021bab3d2553f83bef7cf769c738dd6
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/render/backend/entity.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/render/backend/entity.cpp b/src/render/backend/entity.cpp index a32edab5c..8a97eed81 100644 --- a/src/render/backend/entity.cpp +++ b/src/render/backend/entity.cpp @@ -133,7 +133,7 @@ void Entity::setParentHandle(HEntity parentHandle) // Remove ourselves from previous parent children list Entity *parent = m_nodeManagers->renderNodesManager()->data(parentHandle); if (parent != nullptr && parent->m_childrenHandles.contains(m_handle)) - parent->m_childrenHandles.remove(m_handle); + parent->m_childrenHandles.removeAll(m_handle); m_parentHandle = parentHandle; parent = m_nodeManagers->renderNodesManager()->data(parentHandle); if (parent != nullptr && !parent->m_childrenHandles.contains(m_handle)) |