diff options
author | Robert Griebl <robert.griebl@qt.io> | 2024-06-14 16:01:10 +0200 |
---|---|---|
committer | Robert Griebl <robert.griebl@qt.io> | 2024-06-14 17:48:23 +0200 |
commit | 4cfe79f0b5e196664503d9ea5a0baa1e4e0154e9 (patch) | |
tree | 0930c8aa181d7b3a3ae7f2777f824977feb69f25 /src/manager-lib/application.h | |
parent | a3f04c5ff678b50d93beb8401f226224fd555774 (diff) |
We do rely on the Watchdog object being destructed by making it an
child of qApp. The problem here is that we are now in a situation,
where the qApp's vptr has been changed to make it a QCoreApplication
class, while the watchdog thread's event loop is still running and
accessing the same QCoreApplication instance. Although this shouldn't
be a problem in our case, it's still a TSAN warning that can be avoided
by hooking in to aboutToQuit() and tearing down the watchdog thread
there.
(see https://github.com/google/sanitizers/wiki/ThreadSanitizerPopularDataRaces#data-race-on-vptr)
Also, changed the output to reflect that we are not watching threads
directly, but their event loops.
Change-Id: Ie8efd0cc870b28ed6f99187c1cf880903e53b063
Pick-to: 6.8
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
Diffstat (limited to 'src/manager-lib/application.h')
0 files changed, 0 insertions, 0 deletions