diff options
| author | Robert Griebl <robert.griebl@qt.io> | 2024-02-18 15:06:42 +0100 |
|---|---|---|
| committer | Robert Griebl <robert.griebl@qt.io> | 2024-02-21 18:17:07 +0100 |
| commit | 1b6190534e3de2f9b1bea37bc3803bd061e3a628 (patch) | |
| tree | fecb8f81c56d6e3fa4f2d704606b18228bf3b6fb /src/window-lib | |
| parent | 357e9c84f9f8296d971857827c93399fa23d5596 (diff) | |
Axivion: fix or document most of the reported issues
Change-Id: I5723096b8db71c216b33e189a2469b3130c19504
Pick-to: 6.7
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
Diffstat (limited to 'src/window-lib')
| -rw-r--r-- | src/window-lib/windowmanager.cpp | 9 | ||||
| -rw-r--r-- | src/window-lib/windowmanager_p.h | 2 |
2 files changed, 6 insertions, 5 deletions
diff --git a/src/window-lib/windowmanager.cpp b/src/window-lib/windowmanager.cpp index 3aa85070..d743f3ea 100644 --- a/src/window-lib/windowmanager.cpp +++ b/src/window-lib/windowmanager.cpp @@ -298,7 +298,7 @@ void WindowManager::setSlowAnimations(bool slowAnimations) if (slowAnimations != d->slowAnimations) { d->slowAnimations = slowAnimations; - for (auto view : d->views) + for (auto *view : std::as_const(d->views)) updateViewSlowMode(view); // Update timer of the main, GUI, thread @@ -308,7 +308,8 @@ void WindowManager::setSlowAnimations(bool slowAnimations) RuntimeFactory::instance()->setSlowAnimations(d->slowAnimations); // Update already running applications - for (Application *application : ApplicationManager::instance()->applications()) { + const auto allApplications = ApplicationManager::instance()->applications(); + for (Application *application : allApplications) { auto runtime = application->currentRuntime(); if (runtime) runtime->setSlowAnimations(d->slowAnimations); @@ -521,7 +522,7 @@ Window *WindowManager::window(int index) const QList<Window *> WindowManager::windowsOfApplication(const QString &id) const { QList<Window *> result; - for (Window *window : d->windowsInModel) { + for (Window *window : std::as_const(d->windowsInModel)) { if (window->application() && window->application()->id() == id) result << window; } @@ -673,7 +674,7 @@ void WindowManager::registerCompositorView(QQuickWindow *view) emit internalSignals.compositorAboutToBeCreated(); d->waylandCompositor = new WaylandCompositor(view, d->waylandSocketName); - for (const auto &extraSocket : d->extraWaylandSockets) + for (const auto &extraSocket : std::as_const(d->extraWaylandSockets)) d->waylandCompositor->addSocketDescriptor(extraSocket); connect(d->waylandCompositor, &QWaylandCompositor::surfaceCreated, diff --git a/src/window-lib/windowmanager_p.h b/src/window-lib/windowmanager_p.h index 517c5b52..ddf10778 100644 --- a/src/window-lib/windowmanager_p.h +++ b/src/window-lib/windowmanager_p.h @@ -45,7 +45,7 @@ public: QList<QQuickWindow *> views; QString waylandSocketName; - QQmlEngine *qmlEngine; + QQmlEngine *qmlEngine = nullptr; }; QT_END_NAMESPACE_AM |