diff options
author | Oliver Wolff <oliver.wolff@qt.io> | 2018-10-15 09:51:12 +0200 |
---|---|---|
committer | Oliver Wolff <oliver.wolff@qt.io> | 2018-10-25 11:24:08 +0000 |
commit | e524724f9dc6f64f6f94b842682c751dcd07225f (patch) | |
tree | 8b70e638f8f12c3e654057accf98772049c66beb /.tag | |
parent | ebfad73b4e44fe6db8059200da105b4b87888718 (diff) |
tst_qfilesystemmodel: Do not use nested calls of auto test functions
Calling rowCount inside another auto test function yields unexpected
results, if rowCount fails. Without a check for QTest::currentTestFailed
the failure will not stop the calling function and other functions like
rowsInserted and rowsRemoved might happily continue even though their
requirements are not met. That caused a crash on winrt under certain
circumstances.
In addition to that TRY_WAIT now does not only wait for the given
amount of time, but also gives feedback about its result. Before
this change TRY_WAIT was basically useless, as it gave no indication
about its success/failure.
Fixes: QTBUG-71121
Change-Id: Ibd3f233a0b913db799814be97c4274d510643c74
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Diffstat (limited to '.tag')
0 files changed, 0 insertions, 0 deletions