path: root/cmake
diff options
authorSimon Hausmann <>2019-06-26 10:51:30 +0200
committerSimon Hausmann <>2019-06-26 09:07:20 +0000
commit8c60782124aa7fe54ade1f67bd85b11068735314 (patch)
tree7d308976c19623721d07b8b6b6f73393d01d9c95 /cmake
parenta9d2c5b6d7fa6b7365db8690f57aa78002c8bc4b (diff)
Fix XCB feature detection
The xcb feature controls whether to build the xcb platform plugin. The feature depends among other things on qt_find_package(XCB 1.9 PROVIDED_TARGETS XCB::XCB) to succeed. This means at the moment setting XCB_FOUND to true, that's what the condition checks. Later on, in configure.cmake, we also check for other components in the XCB package, for example: qt_find_package(XCB COMPONENTS XINPUT PROVIDED_TARGETS XCB::XINPUT) If this component is not available, the xcb platform plugin has perhaps reduce functionality, but it should be built and the feature should be abled. However it isn't, because when that find_package call fails, XCB_FOUND will be set to false. And that in turn will disable the feature as the condition fails. Therefore this patch changes the condition to check for the presence of the XCB::XCB target instead. Change-Id: I534087d8c3b7ff5edf81a5ffcf16cc0bb78b9fb7 Reviewed-by: Alexandru Croitor <>
Diffstat (limited to 'cmake')
0 files changed, 0 insertions, 0 deletions