summaryrefslogtreecommitdiffstats
path: root/cmake
diff options
context:
space:
mode:
authorTor Arne Vestbø <tor.arne.vestbo@qt.io>2023-04-12 17:04:24 +0200
committerTor Arne Vestbø <tor.arne.vestbo@qt.io>2023-04-24 14:20:04 +0200
commita92c202b49777696cbc64003f6292e6b61952140 (patch)
tree9d9f2bea11d7d1af833fd4a02cfff350735fbbb9 /cmake
parentc11cfc2d8d5ee5692a309bf5461f3b346f325118 (diff)
macOS: Localize title of edit menu's NSMenuItem via AppKit
In 939b7bfe66221975d3a12a6d0a6dd14d9ad04344 we synced up the NSMenuItem's title to that of the corresponding NSMenu, as AppKit was observed to use the NSMenuItem title for its heuristics of when to add dictation and emoji entries to the menu. But AppKit's heuristics are based on the localized name of the edit menu, so we need to follow suit and look up AppKit's own localizations. This is of course fragile, as we're relying on this localization continuing to live in the InputManager table, but if that changes we'll just fall back to using the title from the NSMenu, as we did before. In addition, AppKit's heuristics also look for menu items in the menu that match selectors such as copy:, paste:, etc, so even if our lookup of the localized title fails, the additional heuristics would in most cases still succeed in detecting the edit menu. Task-number: QTBUG-53085 Task-number: QTBUG-79565 Pick-to: 6.5 Change-Id: I5e12973b86ab35f10a8f7434bcae8a4cf134ecfd Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
Diffstat (limited to 'cmake')
0 files changed, 0 insertions, 0 deletions