diff options
| author | Marc Mutz <marc.mutz@kdab.com> | 2015-12-30 02:30:34 +0100 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@kdab.com> | 2015-12-30 12:05:59 +0000 |
| commit | 96dc9a19ae11ca140d681f0e2605b5f4b953e581 (patch) | |
| tree | f09894eb760b457d66d3b5bb891570114eb9b9dc /configure.bat | |
| parent | 5c8186301996780b90e1b7b37b6142e885f3c9b0 (diff) | |
QUrlQuery: fix a very expensive always-true check
In a non-const function, if (d), d being a QSharedDataPointer,
will resolve to if(d.data()), which detaches and returns a
pointer to an unshared copy of the data. Thus, the test if (d)
is always true.
Fix by explicit use of constData(), as in other QUrlQuery
functions.
Change-Id: Ib926abdcdb069d69e34c3202c4cf451b7fc6a329
Reviewed-by: Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
Diffstat (limited to 'configure.bat')
0 files changed, 0 insertions, 0 deletions