summaryrefslogtreecommitdiffstats
path: root/configure.pri
diff options
context:
space:
mode:
authorMarc Mutz <marc.mutz@kdab.com>2016-07-11 19:55:24 +0200
committerMarc Mutz <marc.mutz@kdab.com>2017-02-06 14:41:46 +0000
commitc876bb1f1333e47722e202b0916415e771137071 (patch)
tree34401974dd6a2993561b577b07b20955a696adb7 /configure.pri
parentbbd091ac5853d7884929369da4e1b5d233ca504c (diff)
QInputDialog: prevent crash in static get*() functions when parent gets deleted
As explained in https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0 creating dialogs on the stack is a bad idea if the application or the dialog's parent window can be closed by means other than user interaction (such as a timer or an IPC call). Since we cannot know whether Qt is used to build such an application, we must assume it is, create the dialog on the heap, and monitor its lifetime with a QPointer. Instead of using manual resource management, add a minimal implementation of QAutoPointer, and use that in all static get*() functions. Task-number: QTBUG-54693 Change-Id: I6157dca18608e02be1ea2c2defbc31641defc9d1 Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com> Reviewed-by: David Faure <david.faure@kdab.com>
Diffstat (limited to 'configure.pri')
0 files changed, 0 insertions, 0 deletions