summaryrefslogtreecommitdiffstats
path: root/dist/changes-0.93
diff options
context:
space:
mode:
authorEdward Welbourne <edward.welbourne@theqtcompany.com>2015-11-12 11:01:31 +0100
committerEdward Welbourne <edward.welbourne@theqtcompany.com>2015-11-20 15:01:38 +0000
commit00a855d64326c03f1e7b05ae335c774e910405d7 (patch)
tree8daad285624871c39bffc614c52b57de7d328e6d /dist/changes-0.93
parentf1d5641d49f676b835c2a81b96deba0c39fd386a (diff)
Avoid having division caught up in parsing of comments.
A loop to skip space and comments was meant to break on anything else but would have not broken on a division operator (where it should) due to it getting caught in the check for a comment-start, without falling back suitably when it didn't complete that check. Managed to contrive a suitably twisted change to findDeps test to reveal the bug; broken previously, now fixed. Not ideal, as it relied on another bug to fail previously - backslash-newline shouldn't end a preprocessing directive line - but it should still pass once that's fixed, too. Exercising a bug in qmake usually involves code that won't compile anyway, making it tricky to write a test that reveals the bug but that passes once it's fixed. Change-Id: I08a1d7cc5e3d7fd1ac0a48e5c09dfdfbb7580b11 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
Diffstat (limited to 'dist/changes-0.93')
0 files changed, 0 insertions, 0 deletions