diff options
author | Edward Welbourne <edward.welbourne@qt.io> | 2018-01-30 21:02:10 +0100 |
---|---|---|
committer | Edward Welbourne <edward.welbourne@qt.io> | 2018-02-01 15:57:23 +0000 |
commit | b44df9937e4b15596b994f8e20822b83ac4bed29 (patch) | |
tree | b5e35a8874ee19517bf830a001e2719478bb9e93 /dist | |
parent | 9b2913377807b3dae107befeec0bc488f4a2cbad (diff) |
Clean-up in QDateTime's parsing of ISODate{,WithMs}
Actually check that there's a T where ISO 8601 wants it (instead of
just skipping over whatever's there), with something after it; move
some declarations later; add some comments; and use the QStringRef API
more cleanly (so that it's easier to see what's going on). Simplify a
loop condition to avoid the need for a post-loop fix-up.
This incidentally prevents an assertion failure (which brought the
mess to my attention) parsing a short string as an ISO date-time; if
there's a T with nothing after it, we won't try to read at index -1 in
the following text. (The actual fail seen had a Z where the T should
have been, with nothing after it.)
Add tests for invalid ISOdate cases that triggered the assertion.
Task-number: QTBUG-66076
Change-Id: Ided9adf62a56d98f144bdf91b40f918e22bd82cd
Reviewed-by: Israel Lins Albuquerque <israelins85@yahoo.com.br>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
(cherry picked from commit a9c111ed8c30a5a8fec3f02244f0d5a4bd08e931)
Diffstat (limited to 'dist')
0 files changed, 0 insertions, 0 deletions