diff options
| author | Olivier Goffart <ogoffart@woboq.com> | 2013-11-15 09:46:02 +0100 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2013-11-26 08:24:25 +0100 |
| commit | f805020410c8ccb0cd223988565bcabde1c5806b (patch) | |
| tree | 4c470de0c3705a5b2ef8da41e80e8f9b26a010a6 /dist | |
| parent | c2f08598e1cc3089505dd8037d333071da0f231f (diff) | |
Fix a race that occurred as we unlock the mutex to destroy the functor in ~QObject
When we unlock the mutex, we need to take in account that the Connection
pointed by 'node' may be destroyed in another thread while it is unlocked
Doing 'node->prev = &node' will make sure that 'node' is actually
updated when it is destroyed.
Setting isSlotObject under the mutex is safer and ensure that no other
thread will attempt to deref the object.
The regression was introduced in 5885b8f775998c30d53f40b7f368c5f6364e6df4
tst_qobjectrace was updated to catch races arising when we are
connecting with function pointers.
Change-Id: Ia0d11ae8df563dad97eb86993a786b579b28cd03
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Diffstat (limited to 'dist')
0 files changed, 0 insertions, 0 deletions