summaryrefslogtreecommitdiffstats
path: root/examples/corelib/serialization/convert/nullconverter.cpp
diff options
context:
space:
mode:
authorEdward Welbourne <edward.welbourne@qt.io>2023-09-04 19:21:58 +0200
committerEdward Welbourne <edward.welbourne@qt.io>2023-11-01 21:28:55 +0100
commit1022b0d111ea401a9aee719f89c75ff0ddb4fe9b (patch)
tree8df9faaab1749a5889fccefe9be47be356015fdd /examples/corelib/serialization/convert/nullconverter.cpp
parent8b8fc42f2c6b08097bcd04038ed7f12667a90875 (diff)
Eliminate duplicate overrides of Converter methods in example
The Out-only converters shouldn't need to implement loadFile(), as it shouldn't be called - a converter is not used for input unless it says it supports input. At the same time, provide the "ground state" implementations for optionsHelp(), outputOptions() and probeFile() to save the trivial implementations the need to duplicate one another. In the process, make the handling of loadFile()'s outputConverter more consistent among those that do implement it. Always set outputConverter if it's initially null (the caller does assert this). Pick-to: 6.6 6.5 Task-number: QTBUG-111228 Change-Id: I856d12c791d1f8e0accdb7dd1412d493117b2302 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'examples/corelib/serialization/convert/nullconverter.cpp')
-rw-r--r--examples/corelib/serialization/convert/nullconverter.cpp19
1 files changed, 0 insertions, 19 deletions
diff --git a/examples/corelib/serialization/convert/nullconverter.cpp b/examples/corelib/serialization/convert/nullconverter.cpp
index 00ae47a086..fb8be5c944 100644
--- a/examples/corelib/serialization/convert/nullconverter.cpp
+++ b/examples/corelib/serialization/convert/nullconverter.cpp
@@ -26,25 +26,6 @@ Converter::Options NullConverter::outputOptions() const
return SupportsArbitraryMapKeys;
}
-const char *NullConverter::optionsHelp() const
-{
- return nullptr;
-}
-
-bool NullConverter::probeFile(QIODevice *f) const
-{
- Q_UNUSED(f);
- return false;
-}
-
-QVariant NullConverter::loadFile(QIODevice *f, const Converter *&outputConverter) const
-{
- Q_UNUSED(f);
- Q_UNUSED(outputConverter);
- outputConverter = this;
- return QVariant();
-}
-
void NullConverter::saveFile(QIODevice *f, const QVariant &contents,
const QStringList &options) const
{