diff options
| author | Edward Welbourne <edward.welbourne@qt.io> | 2023-09-01 13:34:26 +0200 |
|---|---|---|
| committer | Edward Welbourne <edward.welbourne@qt.io> | 2023-09-08 18:17:37 +0200 |
| commit | 77fdd21cbf1a053efe6eec51356c665ed982d47c (patch) | |
| tree | 235aad25951de0a3e9843b4e5c2ffdc93c7b508a /examples/corelib/serialization/convert/xmlconverter.cpp | |
| parent | eaebb5c4d2e2a87b23d63c5406bf54458b4c4a24 (diff) | |
Serialization converter example: const-ify the Converter type
Its methods act on their parameters without changing the converter, so
can all be const. Its instances thus have no non-const members to
exercise, so can always be const.
Pick-to: 6.6 6.5
Task-number: QTBUG-111228
Change-Id: Ifcdb2f2159c2cfcd7998dd118aa327a32d299ccf
Reviewed-by: Dennis Oberst <dennis.oberst@qt.io>
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Diffstat (limited to 'examples/corelib/serialization/convert/xmlconverter.cpp')
| -rw-r--r-- | examples/corelib/serialization/convert/xmlconverter.cpp | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/examples/corelib/serialization/convert/xmlconverter.cpp b/examples/corelib/serialization/convert/xmlconverter.cpp index 3461af46ee..f9da8cfe60 100644 --- a/examples/corelib/serialization/convert/xmlconverter.cpp +++ b/examples/corelib/serialization/convert/xmlconverter.cpp @@ -396,27 +396,27 @@ static void variantToXml(QXmlStreamWriter &xml, const QVariant &v) } } -QString XmlConverter::name() +QString XmlConverter::name() const { return "xml"_L1; } -Converter::Direction XmlConverter::directions() +Converter::Direction XmlConverter::directions() const { return InOut; } -Converter::Options XmlConverter::outputOptions() +Converter::Options XmlConverter::outputOptions() const { return SupportsArbitraryMapKeys; } -const char *XmlConverter::optionsHelp() +const char *XmlConverter::optionsHelp() const { return xmlOptionHelp; } -bool XmlConverter::probeFile(QIODevice *f) +bool XmlConverter::probeFile(QIODevice *f) const { if (QFile *file = qobject_cast<QFile *>(f)) { if (file->fileName().endsWith(".xml"_L1)) @@ -426,7 +426,7 @@ bool XmlConverter::probeFile(QIODevice *f) return f->isReadable() && f->peek(5) == "<?xml"; } -QVariant XmlConverter::loadFile(QIODevice *f, Converter *&outputConverter) +QVariant XmlConverter::loadFile(QIODevice *f, const Converter *&outputConverter) const { if (!outputConverter) outputConverter = this; @@ -442,7 +442,8 @@ QVariant XmlConverter::loadFile(QIODevice *f, Converter *&outputConverter) return v; } -void XmlConverter::saveFile(QIODevice *f, const QVariant &contents, const QStringList &options) +void XmlConverter::saveFile(QIODevice *f, const QVariant &contents, + const QStringList &options) const { bool compact = false; for (const QString &s : options) { |