diff options
author | Christian Ehrlicher <ch.ehrlicher@gmx.de> | 2017-12-24 13:22:48 +0100 |
---|---|---|
committer | Christian Ehrlicher <ch.ehrlicher@gmx.de> | 2017-12-27 18:21:28 +0000 |
commit | a779d68256ba2568f47aab9c5efbcef0cf8c277e (patch) | |
tree | fff116a5114d221eec37fce5132a8a6c42e38084 /examples/corelib | |
parent | d7330140190686f805be9fcd1ac968e3768f0754 (diff) |
MimeTypeBrowser: avoid memleaks
In MainWindow ctor some member values were allocated without a parent
and not cleaned up in dtor. Fixed it by give them a valid parent so they
get automatically cleaned up. Also m_treeView was initialized twice.
Task-number: QTBUG-61862
Change-Id: I5590b87bb517c55db6eb58e700a5d419c0acdba2
Reviewed-by: Topi Reiniƶ <topi.reinio@qt.io>
Reviewed-by: Martin Smith <martin.smith@qt.io>
Diffstat (limited to 'examples/corelib')
-rw-r--r-- | examples/corelib/mimetypes/mimetypebrowser/mainwindow.cpp | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/examples/corelib/mimetypes/mimetypebrowser/mainwindow.cpp b/examples/corelib/mimetypes/mimetypebrowser/mainwindow.cpp index 1d36b7e5ef..bc7ec17d1c 100644 --- a/examples/corelib/mimetypes/mimetypebrowser/mainwindow.cpp +++ b/examples/corelib/mimetypes/mimetypebrowser/mainwindow.cpp @@ -72,8 +72,8 @@ MainWindow::MainWindow(QWidget *parent) : QMainWindow(parent) , m_model(new MimetypeModel(this)) - , m_treeView(new QTreeView) - , m_detailsText(new QTextEdit) + , m_treeView(new QTreeView(this)) + , m_detailsText(new QTextEdit(this)) , m_findIndex(0) { setWindowTitle(tr("Qt Mime Database Browser")); @@ -97,9 +97,8 @@ MainWindow::MainWindow(QWidget *parent) menuBar()->addMenu(tr("&About"))->addAction(tr("&About Qt"), qApp, &QApplication::aboutQt); - QSplitter *centralSplitter = new QSplitter; + QSplitter *centralSplitter = new QSplitter(this); setCentralWidget(centralSplitter); - m_treeView = new QTreeView; m_treeView->setUniformRowHeights(true); m_treeView->setModel(m_model); |