path: root/examples/gui
diff options
authorAnton Kudryavtsev <>2016-07-11 17:23:21 +0300
committerSimon Hausmann <>2016-08-04 19:55:04 +0000
commit9c8a8e90a6514c23bcbeb14073a9d6bdd926d68b (patch)
treeee3eb949e59abd38bc2dcaad25b0847ab772a784 /examples/gui
parent35117590c8f4634ddfdbe75966dd43adeca69369 (diff)
QString: fix append(const QStringRef &str)
Use QStringRef::isNull instead of QStringRef::string() for validation. Non-NULL str.string() may yet leave us with a useless str.unicode(), which is the actual problem here; whereas !str.isNull() does really confirm that str.unicode() is sensible. Such test prevents situation like: const QString a; QString b; b.append(a); // b.isNull() == true b.append(QStringRef(&a)); // b.isNull() == false Auto test updated: create QStringRef from QString directly, without any condition. Change-Id: I082cd58ef656d8a53e3c1223aca01feea82fffb9 Reviewed-by: Thiago Macieira <> Reviewed-by: Marc Mutz <>
Diffstat (limited to 'examples/gui')
0 files changed, 0 insertions, 0 deletions