Merge remote-tracking branch 'origin/dev' into wip/cmake

Change-Id: I4a78428a8ea273b6960792e3b8043f816fa37fcf

4 files changed, 26 insertions, 37 deletions

diff --git a/examples/opengl/qopenglwidget/bubble.cpp b/examples/opengl/qopenglwidget/bubble.cpp
index dbaf460f6f..7e69aac3e7 100644
--- a/examples/opengl/qopenglwidget/bubble.cpp
+++ b/examples/opengl/qopenglwidget/bubble.cpp
@@ -57,15 +57,13 @@ Bubble::Bubble(const QPointF &position, qreal radius, const QPointF &velocity)
 {
     innerColor = randomColor();
     outerColor = randomColor();
-    cache = 0;
     updateBrush();
 }
 
 //! [0]
 void Bubble::updateCache()
 {
-    if (cache)
-        delete cache;
+    delete cache;
     cache = new QImage(qRound(radius * 2 + 2), qRound(radius * 2 + 2), QImage::Format_ARGB32_Premultiplied);
     cache->fill(0x00000000);
     QPainter p(cache);
@@ -80,8 +78,7 @@ void Bubble::updateCache()
 
 Bubble::~Bubble()
 {
-    if (cache)
-        delete cache;
+    delete cache;
 }
 
 void Bubble::updateBrush()
diff --git a/examples/opengl/qopenglwidget/bubble.h b/examples/opengl/qopenglwidget/bubble.h
index 7170803b40..833ea02288 100644
--- a/examples/opengl/qopenglwidget/bubble.h
+++ b/examples/opengl/qopenglwidget/bubble.h
@@ -80,7 +80,7 @@ private:
     qreal radius;
     QColor innerColor;
     QColor outerColor;
-    QImage *cache;
+    QImage *cache = nullptr;
 };
 
 #endif
diff --git a/examples/opengl/qopenglwidget/glwidget.cpp b/examples/opengl/qopenglwidget/glwidget.cpp
index 5057291f12..89c8469662 100644
--- a/examples/opengl/qopenglwidget/glwidget.cpp
+++ b/examples/opengl/qopenglwidget/glwidget.cpp
@@ -68,14 +68,6 @@ const int bubbleNum = 8;
 
 GLWidget::GLWidget(MainWindow *mw, bool button, const QColor &background)
     : m_mainWindow(mw),
-      m_showBubbles(true),
-      m_qtLogo(true),
-      m_frames(0),
-      m_program1(0),
-      m_program2(0),
-      m_texture(0),
-      m_transparent(false),
-      m_btn(0),
       m_hasButton(button),
       m_background(background)
 {
diff --git a/examples/opengl/qopenglwidget/glwidget.h b/examples/opengl/qopenglwidget/glwidget.h
index 0ad2581cb8..99288261c0 100644
--- a/examples/opengl/qopenglwidget/glwidget.h
+++ b/examples/opengl/qopenglwidget/glwidget.h
@@ -98,34 +98,34 @@ private:
     void extrude(qreal x1, qreal y1, qreal x2, qreal y2);
 
     MainWindow *m_mainWindow;
-    qreal m_fAngle;
-    qreal m_fScale;
-    bool m_showBubbles;
+    qreal m_fAngle = 0;
+    qreal m_fScale = 1;
+    bool m_showBubbles = true;
     QVector<QVector3D> m_vertices;
     QVector<QVector3D> m_normals;
-    bool m_qtLogo;
-    QList<Bubble *> m_bubbles;
-    int m_frames;
+    bool m_qtLogo = true;
+    QVector<Bubble *> m_bubbles;
+    int m_frames = 0;
     QElapsedTimer m_time;
-    QOpenGLShader *m_vshader1;
-    QOpenGLShader *m_fshader1;
-    QOpenGLShader *m_vshader2;
-    QOpenGLShader *m_fshader2;
-    QOpenGLShaderProgram *m_program1;
-    QOpenGLShaderProgram *m_program2;
-    QOpenGLTexture *m_texture;
+    QOpenGLShader *m_vshader1 = nullptr;
+    QOpenGLShader *m_fshader1 = nullptr;
+    QOpenGLShader *m_vshader2 = nullptr;
+    QOpenGLShader *m_fshader2 = nullptr;
+    QOpenGLShaderProgram *m_program1 = nullptr;
+    QOpenGLShaderProgram *m_program2 = nullptr;
+    QOpenGLTexture *m_texture = nullptr;
     QOpenGLBuffer m_vbo1;
     QOpenGLBuffer m_vbo2;
-    int m_vertexAttr1;
-    int m_normalAttr1;
-    int m_matrixUniform1;
-    int m_vertexAttr2;
-    int m_normalAttr2;
-    int m_texCoordAttr2;
-    int m_matrixUniform2;
-    int m_textureUniform2;
-    bool m_transparent;
-    QPushButton *m_btn;
+    int m_vertexAttr1 = 0;
+    int m_normalAttr1 = 0;
+    int m_matrixUniform1 = 0;
+    int m_vertexAttr2 = 0;
+    int m_normalAttr2 = 0;
+    int m_texCoordAttr2 = 0;
+    int m_matrixUniform2 = 0;
+    int m_textureUniform2 = 0;
+    bool m_transparent = false;
+    QPushButton *m_btn = nullptr;
     bool m_hasButton;
     QColor m_background;
 };